rayelliott
/
_s
Archived
forked from mirror/_s
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Move aside from the widgets to the entire sidebar. 

It appears that the entire sidebar should be one large aside instead of
making each widget it's own aside. At least that's how I understand it
when reading w3. It would make sense to make each widget it's own aside
if not all of the widgets were asides, but otherwise the entire sidebar
should be considered one aside.

Plus I think this would make more sense for accessibility and with the
widgets titles being h2 because if the entire sidebar had a title that
would be the h1.

https://www.w3.org/wiki/HTML/Elements/aside
This commit is contained in:
Mark Batchelder 2015-11-20 23:14:31 -08:00
parent 53e6f845ad
commit 15cef7e795
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
functions.php
View File

@ -102,8 +102,8 @@ function _s_widgets_init() {
'name' => esc_html__( 'Sidebar', '_s' ), 'name' => esc_html__( 'Sidebar', '_s' ),
'id' => 'sidebar-1', 'id' => 'sidebar-1',
'description' => '', 'description' => '',
'before_widget' => '<aside id="%1$s" class="widget %2$s">', 'before_widget' => '<div id="%1$s" class="widget %2$s">',
'after_widget' => '</aside>', 'after_widget' => '</div>',
'before_title' => '<h2 class="widget-title">', 'before_title' => '<h2 class="widget-title">',
'after_title' => '</h2>', 'after_title' => '</h2>',
) ); ) );

4
sidebar.php
View File

@ -12,6 +12,6 @@ if ( ! is_active_sidebar( 'sidebar-1' ) ) {
} }
?> ?>
<div id="secondary" class="widget-area" role="complementary"> <aside id="secondary" class="widget-area" role="complementary">
<?php dynamic_sidebar( 'sidebar-1' ); ?> <?php dynamic_sidebar( 'sidebar-1' ); ?>
</div><!-- #secondary --> </aside><!-- #secondary -->