rayelliott
/
_s
Archived
forked from mirror/_s
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #1303 from jaredcaraway/fix-aria-expanded 

Remove unnecessary aria-expanded attribute on ul
This commit is contained in:
Ismail El Korchi 2020-04-11 20:53:58 +01:00 committed by GitHub
parent 6d16c0c673 b44cdaecbc
commit 55fafb9558
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/navigation.js
View File

@ -25,7 +25,6 @@
return; return;
} }
menu.setAttribute( 'aria-expanded', 'false' );
if ( -1 === menu.className.indexOf( 'nav-menu' ) ) { if ( -1 === menu.className.indexOf( 'nav-menu' ) ) {
menu.className += ' nav-menu'; menu.className += ' nav-menu';
} }
@ -34,11 +33,9 @@
if ( -1 !== container.className.indexOf( 'toggled' ) ) { if ( -1 !== container.className.indexOf( 'toggled' ) ) {
container.className = container.className.replace( ' toggled', '' ); container.className = container.className.replace( ' toggled', '' );
button.setAttribute( 'aria-expanded', 'false' ); button.setAttribute( 'aria-expanded', 'false' );
menu.setAttribute( 'aria-expanded', 'false' );
} else { } else {
container.className += ' toggled'; container.className += ' toggled';
button.setAttribute( 'aria-expanded', 'true' ); button.setAttribute( 'aria-expanded', 'true' );
menu.setAttribute( 'aria-expanded', 'true' );
} }
}; };
@ -49,7 +46,6 @@
if ( ! isClickInside ) { if ( ! isClickInside ) {
container.className = container.className.replace( ' toggled', '' ); container.className = container.className.replace( ' toggled', '' );
button.setAttribute( 'aria-expanded', 'false' ); button.setAttribute( 'aria-expanded', 'false' );
menu.setAttribute( 'aria-expanded', 'false' );
} }
} ); } );