Commit Graph

21 Commits

Author SHA1 Message Date
Ismail El Korchi 9dee764949 Fix a minor spacing issue 2020-04-10 03:04:28 +01:00
Ron Holt 29b0bb311f Close small menu when user clicks outside #1375 2020-04-10 02:55:53 +01:00
Ismail El Korchi f94fc1e59b Fix PHP, CSS AND JS coding standards 2020-04-05 21:49:27 +01:00
Sami Keijonen 25abf6d66f Remove aria-haspopup. 2016-11-26 19:35:00 +02:00
David A. Kennedy 8b60d6e2a6 Add new line at end of file for JS Hint. 2016-05-26 18:00:54 -04:00
David A. Kennedy a089ad81ac Fix errors in Travis CI from latest PR.
* `navigation.js` had a few spacing issues and variable placement problems causing JS Hint to throw errors.
* See: https://github.com/Automattic/_s/pull/900
2016-05-26 17:47:24 -04:00
Caroline Moore ad8a7c0ac7 Merge pull request #900 from iamtakashi/fix-menu-for-touch
Toggle focus class to allow submenu access on tablets. Props @iamtakashi
2016-05-26 16:03:16 -04:00
sixhours 0ab215d1c8 Clarify TAB key support in navigation header comment 2016-02-26 10:05:46 -05:00
Takashi Irie 7c5b0d8d18 Toggle focus class to allow submenu access on tablets 2016-01-13 11:13:59 +00:00
jrfnl b8d776c59c Slim down the travis script, add js checks and fix js errors thrown up.
What it will now do:
- Lint the php files against relevant PHP versions.
- Lint the js files once - the result won't change across PHP versions.
- Check against WPCS once - the result won't change across PHP versions.

What I have changed:
- Added linting against PHP 7 and HHVM, with HHVM being allowed to fail.
- Added js linting and style check per example from Twenty Sixteen.
- Moved to the faster container based environment for running travis.
- Script will no longer pull in PHPCS, WPCS and the JS linters in every build. Now they will only be pulled in when needed.
- Limited the clone depth for quicker cloning of external repositories.
- Removed the pulling in of WP and running builds against different WP versions as this wasn't used at all in the actual test scripts.
2015-12-13 15:03:43 +01:00
Christopher Crouch 18f843ed03 _s: Tabbable dropdown menus.
Fixes #540.
2015-04-07 13:09:00 -07:00
sixhours 204654ac1f Revert previous (unintentional) commit 2014-12-17 15:09:44 -05:00
sixhours 88f94a9a4e First pass at fixing drop-down menus for touch
This patch allows the user to view a site on a touch screen tablet and
access child menus by clicking on the parent once, or access the parent
by clicking on it twice. Props @iamtakashi for the original fix.
2014-12-17 15:03:17 -05:00
Konstantin Obenland d8d89bc681 _s: Improve menu toggle accessibility.
Makes it a little easier to use the primary navigation with assistive
devices.

See #545.
2014-11-05 17:37:48 -08:00
Philip Arthur Moore 4b883e2aee a11y improvements on primary navigation menu toggle 2014-04-13 04:02:17 -05:00
Shea Bunge e5a8931afc Add missing semicolon 2013-07-14 16:39:03 +10:00
Shea Bunge 4c99b2aba8 Use === and !== instead of == and != 2013-07-14 16:38:08 +10:00
Michael Fields ac3cda4543 Rework Navigation Menu Part 2
* Separate scoping and assignment so that a decision does not need to be made as to whether we should intermix spaces and tabs on the left
 * Restore the previously removed nav-menu class addition to the first unordered list in `#site-navigation`.
 * Restore the `.navigation-main.toggled-on .nav-menu` selector.
 * Remove rules for the `.main-small-navigation ul` selector.
2013-06-25 01:45:52 -07:00
Michael Fields 4c396f6f9b Rework menu navigation: these changes build off pull request #239 for issue #200
* Only set button and menu if container is not null.
 * Break up the "return early" conditional into multiple parts.
 * Shorten the name of the toggled class from `toggled-on` to `toggled`.
 * Restore the "Hide menu toggle button if menu is empty." documentation.
 * Remove the `nav-menu` class. The previous code would replace any custom custom classes applied via `wp_nav_menu()` or template file.
 * Replace the `nav-menu` selector is style.css with selectors that will target both a custom nav menu and a page menu. These changes could use critical feedback. Do you know of an edge case where they might not work as expected?
2013-06-16 20:29:17 -07:00
obenland fa3d86936a _s: Simplify and unify navigation classes throughout Underscores.
For more information about the philosophy behind the new approach,
see http://24ways.org/2012/a-harder-working-class/
2013-02-27 14:47:03 -08:00
Konstantin Kovshenin 22e1613bde Replace small-menu.js with navigation.js inspired by Twenty Twelve.
Doesn't use jQuery, slightly easier to understand, uses a media query for max-width, rather than JS events making it faster to respond.
2012-09-03 21:45:28 +04:00