Commit Graph

881 Commits

Author SHA1 Message Date
Philip Arthur Moore 25a6b98898 Merge pull request #502 from emiluzelac/patch-24
Minor coding standards adjustments for HTML5 markup support declaration. See https://github.com/Automattic/_s/pull/498#issuecomment-44492997.
2014-05-29 16:08:33 +07:00
Emil Uzelac d8a88d2097 Post Formats code re-formatting
See: https://github.com/Automattic/_s/pull/498#issuecomment-44492997
2014-05-29 01:54:04 -05:00
Tammie Lister cbe996bfb9 Merge pull request #501 from emiluzelac/patch-23
Increases text width to 100% which allows for box-sizing. I like this better and if someone wants to add a border or effect they can change the width.
2014-05-28 17:48:20 +01:00
Emil Uzelac 9f295c197d textarea width
We can safely increase the textarea width from 98% to 100%. 

```box-sizing``` handles the layout nicely and it won't allow the overflow. 

If more details is needed, please see: http://davidwalsh.name/textarea-width this is the best example I could find.
2014-05-28 00:05:18 -05:00
Konstantin Obenland 4359baa57f Merge pull request #500 from emiluzelac/patch-22
Simplifies `border-color` attributes.
2014-05-26 17:27:41 -07:00
Emil Uzelac 92128bbc7d Border Color
Minor CSS optimization for border and border color.

For the border itself, we don't need to include the color in ```border: {}```, color is already added in ```border-color: {}```. 

Since the Theme uses shorthands for padding/margins, why not do the same for the border colors as well.
2014-05-26 16:00:23 -05:00
Philip Arthur Moore cf64e34608 Merge pull request #499 from emiluzelac/patch-21
Change `widgettitle` to `widget-title` in 404 template for better consistency throughout all theme files. _s uses `widget-title` as its convention when declaring theme widgets, so we'll go with that.
2014-05-26 15:39:50 +07:00
Philip Arthur Moore 37af1521d8 Merge pull request #493 from davidakennedy/newmenu
Adjust dropdown menu styles so they work with screen readers
2014-05-26 15:29:29 +07:00
Emil Uzelac 6d0886c0d7 widgettitle value
```widgettitle``` doesn't really have any value here or in core. Proposing to change to ```widget-title``` instead and maybe add that into stylesheet too. 

The class is available only in /widgets.php and not present in any of the stylesheet's, at least I could not locate one. As in my previous proposal, this is for the consistency reasons only.
2014-05-24 16:20:23 -05:00
David A. Kennedy f8c52a8114 Change position for left to match WordPress CSS standards. 2014-05-24 13:30:50 -04:00
David A. Kennedy 1365515b74 Merge with upstream/master. 2014-05-20 15:56:31 -04:00
Konstantin Obenland f1dd4b2c2a _s: Revert f955fca630
The leading whitespace is needed to replace this `_s` instance with the theme name.
It's obviously a hack, since it also leaves the theme name with a leading white space, but short of adding a new replace logic for this specific line in `style.css`, it's the easiest way to achieve that.

See #304, where this was brought up before.
2014-05-20 10:53:10 -05:00
Lance Willett 86a0cd531d Pinking shears (remove trailing spaces) in two files. 2014-05-18 13:09:20 -07:00
Lance Willett f955fca630 Remove leading space in stylesheet comment. 2014-05-18 13:08:41 -07:00
Philip Arthur Moore 0463845a4c Merge branch 'mor10-move_skip-to-content_link' 2014-05-16 08:49:27 -05:00
Philip Arthur Moore 513c17268d Move skip-to-content link 2014-05-16 08:49:04 -05:00
Morten Rand-Hendriksen 4df5790db7 Move skip-to-content link to top to make it first focusable element for keyboard navigation. 2014-05-16 00:43:23 -07:00
Konstantin Obenland 2d0ebc79cd Merge pull request #492 from mor10/screen-reader-text_overflow
Fixes overflow issue on .screen-reader-text. See #484.
2014-05-15 05:26:15 -07:00
David A. Kennedy 03fbbf84fd Adjust dropdown menu styles so they work with screen readers and align with Twenty Fourteen techniques. 2014-05-14 22:12:26 -04:00
Morten Rand-Hendriksen bb4bf557c6 Fixes overflow issue when hidden content with the .screen-reader-text class is positioned hard right. 2014-05-14 18:30:36 -07:00
Philip Arthur Moore 57eadcfd17 Merge pull request #486 from swissspidy/issue-483
Improve documentation in search template to explain how to override content output for the file.
2014-05-13 14:49:11 +07:00
Pascal Birchler 27225d5b69 Documentation for content-search.php inclusion 2014-05-13 08:37:56 +02:00
Thomas Guillot 8686937cc2 Merge pull request #473 from sdavis2702/master
_s: Logical approach to function parameters for markup
2014-05-07 09:14:18 +01:00
Konstantin Obenland b1dba82fa0 Merge pull request #479 from psoluch/patch-1
Prevent 'Page %s' from being added to page title on 404 error pages.
2014-05-04 15:36:42 +02:00
Piotr Soluch 54d58d548b fix for a page title error
The same error as https://core.trac.wordpress.org/ticket/16468
2014-05-04 15:34:50 +02:00
James 69930e3786 Update style.css
_s does not support IE6/7 so this is not necessary.
2014-05-02 15:25:46 -04:00
Sean Davis 8b30ee99f7 escape the permalink 2014-05-02 01:17:02 -05:00
Ulrich Pogson fc9910cf96 Split strings into variables 2014-05-01 23:27:08 +02:00
Sean Davis c89d030c6b logical approach to function parameters for markup 2014-05-01 10:30:54 -05:00
Philip Arthur Moore 0d45a9df7a Merge pull request #469 from gatespace/update_s_pot20140428
Update _s.pot : add "Primary Menu" in header.php(L31). And remove 'Menu'.
2014-04-28 11:08:20 +07:00
Kazue Igarashi b848b470c4 Update _s.pot : add "Primary Menu" in header.php(L31). 2014-04-28 10:38:52 +09:00
Philip Arthur Moore 53f62fa23a Merge pull request #459 from philiparthurmoore/menu-a11y
a11y improvements on primary navigation menu toggle
2014-04-27 11:48:11 +07:00
Konstantin Obenland aeaf200a58 _s: Simplify caption styles to work in HTML5 mode.
Since HTML5 captions removed the additional 10px that HTML4 versions
come with, the `max-width: 98%;` rule made images blurry. This slightly
simplifies caption styles while still providing support for both HTML4
and HTML5 versions.

See #443.
2014-04-25 11:25:48 -05:00
Konstantin Obenland 16a0d47af6 Merge pull request #443 from joshmcrty/master
Add support for HTML5 captions.
2014-04-25 11:04:47 -05:00
Konstantin Obenland e389dee561 Merge pull request #463 from gatespace/formating-source-code
Indent multiline PHP code.
2014-04-23 16:42:59 -05:00
Konstantin Obenland 8319773e51 _s: Add context for translations and styles.
The referenced items are decisions we made for `_s`, that a re likely to be brought up again in pull requests or issues. Since our stance on them is not likely to change any time soon, let's include them in the Contributing FAQs.

See #464.
2014-04-21 12:37:29 -07:00
Kazue Igarashi e3ff3dfb5d Add tab to indent 404.php(L43 to L45). 2014-04-18 22:15:42 +09:00
Philip Arthur Moore d3dd7fb3fe Remove style redundancy for menu toggle; cursor pointer is already defined for buttons. 2014-04-18 06:43:25 -05:00
Konstantin Obenland 3f1fe1c400 Merge pull request #461 from jefferyto/patch-2
Removed addEvent support.

See #456.
2014-04-15 12:24:49 -07:00
Konstantin Obenland 7cfc749d70 _s: First version of contributing guidelines.
This might change in the future, based on our experiences, but should
be a good first draft of helpful and friendly guidelines for
contributing.

Props @bungeshea.
Fixes #381.
2014-04-15 11:45:02 -07:00
Shea Bunge 11566d6998 Added contributing guidelines
https://github.com/blog/1184-contributing-guidelines
2014-04-15 11:24:33 -07:00
Jeffery To c6ad689d89 Removed addEvent support
As noted in #456, IE8 is no longer supported.

Also, undefined is falsey in JavaScript, so the typeof check was unnecessary.
2014-04-15 17:40:29 +08:00
Konstantin Obenland 2d2f66f9a1 Merge pull request #458 from Automattic/pr/429
Updated gallery styles to work for both HTML4 and HTML5 versions.

Fixes #425.
Closes #429.
2014-04-14 12:00:56 -07:00
Philip Arthur Moore 4b883e2aee a11y improvements on primary navigation menu toggle 2014-04-13 04:02:17 -05:00
Konstantin Obenland 4dd7a16f36 _s: Simplify gallery styles.
It consolidates the duplicate `.gallery` selectors, and removes image
styles that needlessly override their earlier defined styles.

Also switches to use inline-block over floats, and adds documentation
for caption styles, to be coherent with documentation for gallery
styles.
2014-04-11 13:24:38 -07:00
Konstantin Obenland 32350a8103 _s: Encourage the use of sidebar descriptions.
Sidebar descriptions provide an opportunity to provide context about
where the sidebar is located or when it is loaded. We should encourage
theme developers to use them, similar to how we hint default images for
custom headers and backgrounds.

The callback’s outdated documentation describes the function in an
early state of Toolbox (introduced in r3678-wpcom-themes), the earliest
public record would be
https://themes.trac.wordpress.org/browser/toolbox/0.3/functions.php#L99
This is as good an opportunity to update it as any.

Props @emiluzelac for initial patch.
Fixes #433.
2014-04-10 19:03:23 -07:00
Konstantin Obenland 796d8e8c7e _s: Update function return values.
Adds missing documentation for `_s_categorized_blog()` and removes void
statements, in accordance with WordPress documentation guidelines.

See
http://make.wordpress.org/core/handbook/inline-documentation-standards/p
hp-documentation-standards/#phpdoc-tags
2014-03-30 12:15:29 -07:00
Konstantin Obenland 74e9b10a7a Merge branch 'pr/437'
Conflicts:
	inc/template-tags.php
2014-03-30 12:02:05 -07:00
Konstantin Obenland 7d24be9c97 _s: Resolve merge conflicts from master branch.
This also retains `$all_the_cool_cats` for some flavor. It has been
around since the initial fork of Toolbox and makes people smile:
https://twitter.com/TheFrosty/status/449581069231071232
2014-03-30 12:00:47 -07:00
Konstantin Obenland bd665b9d82 _s: Update pot file.
Last update was a good three months ago and we had some string changes
since then.

Fixes #434.
2014-03-30 10:40:43 -07:00