268a1e2ced
Merge pull request #792 from grantpalin/master
...
Update comparisons to resolve the strict comparison warnings
2015-08-21 19:28:13 -04:00
bdc9a8c52a
Remove _s_wp_title function
...
No longer required under 2 version back support requirements.
2015-08-21 15:10:34 +01:00
149a40d70f
Merge pull request #800 from iamdmitrymayorov/master
...
Remove template-tag shims for versions prior to 4.1. Solves #799 .
2015-08-21 14:11:11 +01:00
72a9a3b7e6
Removing the_posts_navigation(), the_post_navigation(), the_archive_title(), the_archive_description() since 4.3 is out.
2015-08-19 17:40:51 +03:00
6f621af060
Remove _s_render_title()
...
Removing `_s_render_title()`, no longer needed as of 4.3.
2015-08-18 21:55:47 -05:00
af0a4749be
Update comparisons to resolve the strict comparison warnings. See https://github.com/Automattic/_s/issues/784
2015-08-07 09:59:26 -07:00
de9c9888b7
Updated documentation in comments at the top of files.
...
I tried to standardize and expand the documentation and links to
codex.wordpress.org in the comments at the top of most files.
2015-07-12 12:38:18 -04:00
0a0e5c631f
Add post title to `edit_post_link`
...
* Use `__()` instead of `_x()`
* Add translator comment, remove context modifier.
* Remove escaping on `the_title()`; it's trusted data.
Resolves : #774
2015-07-02 17:37:30 -04:00
c60811bf94
Add post title to `edit_post_link`
...
This improves the accessibility of these links, and gives more context for screen reader users. Now, they know exactly where the link goes.
Escaped output with `esc_html_x` and `wp_kses`.
Resolves : #774
2015-06-26 14:22:38 -04:00
175524922c
Fix Codesniffer errors.
2015-05-27 22:19:14 +02:00
2aef92e5a3
Fix remaining PHPCS errors:
...
* Add ignoring in template-tags.php and comments.php.
* Escape header text color in custom-header.php.
2015-05-11 09:18:36 +02:00
6fea1077d8
Escape translations in custom template tags.
...
See #737 .
2015-05-05 12:16:55 +02:00
ef1a884b6c
Escape translation in title shim.
...
See #737 .
2015-05-05 11:59:02 +02:00
7c92e3e138
Update Jetpack URLs to https
...
See #734 .
2015-05-05 11:26:05 +02:00
71d4231cbe
Move template parts into their own dedicated folder and update Infinite Scroll to reflect this change. See #642 . Props @leopuleo.
2015-04-29 08:42:12 +07:00
894bd6b5d3
Use core navigation template tags.
...
* Remove custom arguments from `the_posts_navigation()` and `the_post_navigation()`.
* Adjust fallbacks for `the_posts_navigation()` and `the_post_navigation()`.
* update pot file.
* merge master for style.css and style.scss.
2015-01-07 09:23:28 -08:00
5c6311499b
Update Travis CI build checks. Props @miya0001. See #663 .
2015-01-06 11:48:47 +07:00
3e02659325
Merge pull request #673 from fklein-lu/remove-home-link
...
Remove home link from `wp_page_menu()` args.
2014-12-30 20:21:27 -08:00
2580a0a69f
_s: Remove author data shim.
...
Immediate set up of author data in author archives was added in
WordPress 3.7, so it’s safe to remove.
See https://core.trac.wordpress.org/ticket/14408 .
See a156f2cbab
2014-12-30 20:19:28 -08:00
c4f6755f61
Remove home link from wp_page_menu() args.
2014-12-30 14:53:42 +01:00
37d283481f
Avoid repeatedly checking specific post format.
...
Will only check for a specific post format if it’s a post format
archive page.
See https://core.trac.wordpress.org/changeset/30854
Fixes #664 .
2014-12-22 10:11:39 +01:00
47ee126fb4
Don't check for a private function.
...
Even with WordPress’ commitment to backwards compatibility, we should
probably not bank on private functions being around for ever, and tying
our functionality to it.
This will go old school and do a version check to provide compatibility
with older versions of WordPress. Again, this is only temporary until
4.3 is out.
See #644 .
Fixes #636 .
2014-12-22 10:06:15 +01:00
f2d2495630
Switch in and out of PHP to render fallback title.
...
The upload checks for the .org Theme Directory are rightfully strict about the contents of the title tag.
Switching in and out of PHP should make `_s`-based themes pass those tests again.
See https://github.com/Automattic/_s/pull/644#discussion-diff-22153263
See #644 .
2014-12-22 09:16:13 +01:00
3a25519cc7
Adjust todo notice for wp_title shim.
2014-12-02 20:23:28 +07:00
8b23932190
Merge remote-tracking branch 'origin/master' into title-theme-support
2014-12-02 20:11:14 +07:00
648a5467e9
Better title handling for WordPress 4.1. See #644 .
2014-11-14 08:46:20 +07:00
711ce1967e
Check DOING_AUTOSAVE before flushing transients
...
So that we don’t flush transients more often than necessary.
Fixes #646
2014-11-13 17:44:08 -07:00
bb867c0fcb
_s: Introduce 4.1 archive template tags.
...
Now uses the new archive template tags and makes archive template
titling way simpler!
Added shims for backwards compatibility, which can be removed once
WordPress 4.3 was released.
See https://core.trac.wordpress.org/changeset/30223
Closes #556 .
2014-11-12 15:52:31 -05:00
83792b8566
First pass at better title handling for WordPress 4.1+ with proper back compatibility baked in.
2014-11-11 21:41:10 +07:00
2540fb7b7f
Better WordPress Coding standards.
...
This minor commit kicks off code improvements to _s so that it’s fully in line with WordPress Coding Standards rules.
2014-11-01 07:09:58 +07:00
907403fc52
Merge branch 'Entry-Meta-Output' of https://github.com/Automattic/_s into Entry-Meta-Output
...
Conflicts:
content-single.php
2014-09-10 18:06:15 -07:00
a14b802e75
_s: Move edit link in template tag for consistency
...
Every time `_s_entry_footer()` is used, it’s followed by
`edit_post_link()`. Might as well just move that back in the template
tag.
2014-09-10 17:41:19 -07:00
2990f8260c
_s: Update to entry meta output. See #537
...
* Rename function
* Move edit link outside of function
* Remove comments link on single post
2014-09-04 13:28:24 +02:00
63d8fcb190
Add escaping to custom header example. Make sure that proper attribute escaping is added into the example that's in the custom header include file. Since we're not including this in header.php, we should at least make sure that the example given is proper and passes WordPress Coding Standards checks. See #552 for context.
2014-08-07 11:07:50 +07:00
e6fd8e99cf
Setup is a noun. Set up is a verb. "Setup the WordPress core custom header feature." is incorrect. "Set up the WordPress core custom header feature." is correct.
2014-08-07 10:36:07 +07:00
0d87d0bb70
_s: Continue using a default `time` tag.
...
We only need to change the default markup if published and updated
timestamps are different.
2014-07-30 14:47:16 -05:00
048057ad68
Merge branch 'updated-hAtom' of https://github.com/slobodan/_s into slobodan-updated-hAtom
2014-07-30 14:35:44 -05:00
ba1258f365
_s: Simplify entry meta output
...
- Fix entry-footer inconsistency between content-*.php files
- Move in a function <code>_s_entry_meta()</code> to avoid duplication
---
At the moment there is an inconsistency between content.php and
content-single.php regarding the .entry-footer output.
In my opinion content.php output is would be better to use because it's
easier to translate and allow more customisation.
Finally by moving it into <code>inc/template-tags.php</code> we are
getting rid of some duplicated code.
2014-06-30 16:43:07 +01:00
a78658a393
Revert "_s: Simplify entry meta output"
...
This reverts commit 9e66401930
2014-06-30 16:37:12 +01:00
9e66401930
_s: Simplify entry meta output
...
- Fix entry-footer inconsistency between content-*.php files
- Move in a function <code>_s_entry_meta()</code> to avoid duplication
---
At the moment there is an inconsistency between content.php and
content-single.php regarding the .entry-footer output.
In my opinion content.php output is would be better to use because it's
easier to translate and allow more customisation.
Finally by moving it into <code>inc/template-tags.php</code> we are
getting rid of some duplicated code.
2014-06-30 16:36:36 +01:00
5fffb5e911
Add a non-breaking space to _s_post_nav().
...
Sometimes the title length of a previous or next post would cause
the arrow (larr/rarr) in the link to be wrapped to the next line.
Adding a non-breaking space between the title and the arrow will stick
it to the last word in the title.
2014-06-26 11:50:14 +04:00
00570514d4
Adds .updated class to .entry-date when needed
2014-06-15 13:20:06 +02:00
e24e53e024
Merge pull request #453 from grappler/translation-strings
...
_s: Avoid html tags in "Posted on" string.
2014-06-02 08:28:46 -07:00
86a0cd531d
Pinking shears (remove trailing spaces) in two files.
2014-05-18 13:09:20 -07:00
54d58d548b
fix for a page title error
...
The same error as https://core.trac.wordpress.org/ticket/16468
2014-05-04 15:34:50 +02:00
fc9910cf96
Split strings into variables
2014-05-01 23:27:08 +02:00
796d8e8c7e
_s: Update function return values.
...
Adds missing documentation for `_s_categorized_blog()` and removes void
statements, in accordance with WordPress documentation guidelines.
See
http://make.wordpress.org/core/handbook/inline-documentation-standards/p
hp-documentation-standards/#phpdoc-tags
2014-03-30 12:15:29 -07:00
7d24be9c97
_s: Resolve merge conflicts from master branch.
...
This also retains `$all_the_cool_cats` for some flavor. It has been
around since the initial fork of Toolbox and makes people smile:
https://twitter.com/TheFrosty/status/449581069231071232
2014-03-30 12:00:47 -07:00
5e62b8dc9e
Remove html from string
2014-03-24 00:08:21 +01:00
87ca7b66ad
Prefix transient.
2014-03-18 18:43:00 +04:00
16e0ca504d
Remove redundant package DocBlock within custom header file
2014-03-07 06:41:14 -06:00
09720890a7
_s: Retrieve blog name with the correct context.
...
Passing `'display'` as the second argument will make the blog name filterable and runs it through `wp_texturize()`.
See https://core.trac.wordpress.org/ticket/26811
2014-01-24 09:54:05 -08:00
0f2db471a7
Merge branch 'pr/366'
2014-01-20 20:34:51 -08:00
e55cb8a038
_s: Make it easier to target post navigation links.
...
Removed in 3f4effbFixes #371 .
2014-01-01 17:30:24 -08:00
cb52da6f23
Remove _s_comment
2013-12-22 21:33:16 +01:00
a156f2cbab
_s: Simplify author template.
...
Set up author data for the author template immediately, rather than
waiting for the first the_post() call.
This removes the need to call the_post() and rewind_posts() in an
author template to print information about the author.
Fixes #346 .
2013-12-21 00:00:25 -08:00
3f4effb5f0
_s: Split navigation template tag in context-specific tags.
2013-11-24 18:28:15 +00:00
caff68529f
_s: Update wpcom compat file to wrap contents in a hooked callback.
2013-11-24 18:24:11 +00:00
6264437ff9
Add braces around single-line conditionals. See http://make.wordpress.org/core/2013/11/13/proposed-coding-standards-change-always-require-braces/ .
2013-11-14 19:49:50 +07:00
7c1067eee3
_s: Remove `image.php` and related code. Image attachments will be
...
displayed by `single.php`. See
http://codex.wordpress.org/Template_Hierarchy
2013-11-07 15:59:02 -04:00
6f63a0b39a
_s: Adhere to updated WordPress core code formatting.
...
* Update PHPDoc.
* Add periods to the end of comment sentences.
* Limit line length to 80 chars.
* Use C++-style PHP comments only for function and file documentation.
2013-11-07 15:41:41 -04:00
50a539cd81
Wordpress custom-header functionality seems to require default-text-color to be a six-digit hex code. using less than six digits here causes Appearance > Header to hang on step 3
2013-10-08 14:59:35 -05:00
543cae8bbf
Merge branch 'master' of https://github.com/davidakennedy/_s into titles
...
Conflicts:
image.php
inc/custom-header.php
searchform.php
2013-09-25 14:59:11 -07:00
083d8a580d
_s: Simplify header image markup in admin appearance page.
2013-09-25 14:55:08 -07:00
f572468099
_s: Simplify header image example markup.
...
`get_header_image()` will return the boolean false or an empty string if
there is no header image. Both will be evaluated as false by the if
statement.
Related: http://core.trac.wordpress.org/ticket/25156
2013-09-23 14:39:15 -07:00
48ac0da4e1
Second round of removing title attributes.
2013-08-24 02:06:06 -04:00
966d649f3c
_s: Use comment_reply_link arguments to wrap reply link
...
Avoid empty div if no reply link
2013-08-19 10:18:10 +01:00
810e499b93
_s: Use `<main>` element for main content.
...
See: http://www.w3.org/TR/html51/grouping-content.html#the-main-element
Props @BFTrick for initial patch.
Fixes #222 .
2013-07-30 12:12:45 -07:00
31331b4b64
Switch "navigation-" back to "-navigation"
...
Original edit not needed for `[class*="navigation"]` selector. Matches
other class/id navigation naming conventions.
2013-07-11 16:42:45 -04:00
261acc6099
Merge branch 'open-empty-tags' of https://github.com/bungeshea/_s into
...
bungeshea-open-empty-tags
Conflicts:
searchform.php
2013-07-11 11:45:38 -07:00
d279972455
_s: Simplify 'Posted on' string for easier translation and add a HTML
...
wrapper for easier CSS manipulation. Props @grappler. Fixes #253 .
2013-07-11 08:42:01 -07:00
36ad7cb751
Improve "Posted on" translation string
2013-07-10 22:23:46 +02:00
77b0fa51ae
_s: Simplifies the attached image template tag by only querying for ids.
2013-07-02 17:41:51 -04:00
584ed2a6f2
_s: Remove back compat for custom header/background. Fixes #244 .
2013-06-27 07:14:12 -07:00
39d8f7ad61
_s: Include "entry updated" as part of the hAtom. Props @michiecat. See
...
#131 , fixes #170 .
2013-06-27 06:54:02 -07:00
a4168fdb74
Leave empty tags open in accordance with the HTML5 spec. Resolves #234
2013-06-05 21:08:55 +10:00
6c83cfb5cc
_s: Simplify image.php:
...
* Extracts logic in a custom template tag.
* Reduces switching in and out of php in `.entry-meta`.
* Minor code styling changes.
Fixes #233 .
2013-06-04 13:13:15 -07:00
f0ed253d5b
Merge branch 'custom_header_fix' of https://github.com/iamtakashi/_s
...
into iamtakashi-custom_header_fix
Conflicts:
inc/custom-header.php
2013-05-28 09:31:59 -07:00
95c3bd62cf
_s: Update comment markup to make it forward compatible with html5
...
comments in 3.6. As a result the custom callback can be safely removed
in the future. Also closes #220 .
2013-05-25 12:33:20 +02:00
c7bf07061d
_s: Let's not limit the setup function to IS.
2013-05-20 13:02:30 +02:00
c1960ec122
_s: Cache header text color value;
2013-05-20 13:01:22 +02:00
f367fefd72
Fix unlinked site title in the Customizer
2013-05-08 12:27:48 +01:00
8ceefdcdeb
Fixes the broken display header text option in the Customizer.
2013-04-22 16:47:14 +01:00
c780bc0559
Add trailing commas to the last elements of arrays
2013-04-20 16:45:36 +01:00
7be757759c
Minor code style clean-up
2013-04-20 01:26:43 +01:00
a47b1523dd
Updates to the _s_admin_header_image() callback
...
Adding a ".displaying-header-text" class to the header h1 and to the site description div inside _s_admin_header_image(). This allows the "display text with your image" toggle button to work in the admin preview under Appearance > Header.
2013-04-17 16:46:57 -07:00
6056c1ed66
_s: Re-introduce `nav-` prefix for previous/next links.
...
This way we can select both links with `[class*="nav-"]`.
2013-04-05 09:34:08 -07:00
fe19f5433b
Ditch all @since DocBlocks from theme.
2013-03-18 14:53:23 -05:00
1ba2f62752
_s: Use .screen-reader-text rather than .assistive-text.
...
With 3.6 introducing many HTML5 improvements the need for custom
searchform and comment templates will vanish. To cope with core's
.screen-reader-text class, let's make the switch early.
Commit also adds core's focus styles for screen reader texts, so they
can actually be used.
2013-03-13 15:39:05 -07:00
c4f2aa32ce
_s: Formatting changes:
...
- Reduce element comments to either the element id or the first element
class.
- Tabs > Spaces.
- Improve adherence to formatting guidelines.
2013-03-04 16:41:38 -08:00
c7f2b7a1ee
_s: Enable live preview for Header Text Color in Customizer. Change also
...
removes an !important declaration in Custom Header CSS rules.
2013-03-04 16:13:56 -08:00
9fe1b0d8a8
_s: Aggregate translation strings and make comment edit links easier to
...
style.
2013-03-04 15:18:11 -08:00
dcd62e323c
Manually revert all changes made after debefa8b98 so that the code proposed in #131 gets a proper review.
2013-02-28 01:12:59 -06:00
c8c60b3904
Let us try this one more time. Revert all changes made to _s up until commit debefa merge until #131 has had a proper code review.
2013-02-28 01:04:34 -06:00
fa3d86936a
_s: Simplify and unify navigation classes throughout Underscores.
...
For more information about the philosophy behind the new approach,
see http://24ways.org/2012/a-harder-working-class/
2013-02-27 14:47:03 -08:00
50cee30497
Remove colon from @package DocBlock
2013-02-25 01:15:14 -06:00
c06b9fe571
_s: Minor adjustments to Infinite Scroll's implementation.
2013-02-03 02:12:42 -05:00
16906d44c5
_s: Add basic Infinite Scroll support. Fixes #107 . Fixes #105 . Props @ethitter.
2013-02-03 02:03:40 -05:00
b7563b8a99
Escape dynamic value $nav_id when used as an attribute and html comment. Fixes #146 props @ounziw
2013-02-02 05:03:08 -10:00
10c87aeefc
Merge pull request #93 from kwight/patch-2
...
Remove invalid pubdate value from time elements in template-tags.php. See #93
2012-12-28 17:24:21 -08:00
David A. Kennedy
Tom de Bruin
sarah ✈ semark
Dmitry Mayorov
Emil Uzelac
Grant Palin
PJ
Fränk Klein
Philip Arthur Moore
Kazue Igarashi
Konstantin Obenland
Nick Daugherty
Thomas Guillot
Konstantin Kovshenin
Slobodan Manic
Lance Willett
Piotr Soluch
Ulrich Pogson
obenland
Philip Arthur Moore
Greg Johnson
michaeldcain
Shea Bunge
Takashi Irie
michiecat
Philip Arthur Moore
Michael Fields