812fefd66e
Merge pull request #1101 from jrfnl/feature/i18n-and-code-layout
...
I18n and code layout improvements.
* Fixes missing /* translators */ comments for translatable text strings containing placeholders.
* Fixes infractions against the "For associative arrays, values should start on a new line." code style rule.
2017-06-09 11:51:46 -04:00
d2b58f60fe
Merge pull request #1100 from jrfnl/feature/i18n-translation-call-context
...
I18n: Fix a translation call for a text string which needs context
2017-06-09 11:25:37 -04:00
a65be48368
CS: Fix code layout of nested function calls with associative arrays.
2017-04-03 00:46:36 +02:00
8cefd8f258
I18n: ensure all text strings with placeholders have translators comments.
2017-04-03 00:46:24 +02:00
9c0cb095c7
Code obfuscation: Fix assignment within a condition
2017-04-03 00:44:57 +02:00
5c27fded17
I18n: Fix a translation call for a text string which needs context
2017-04-03 00:39:36 +02:00
dfab67a260
Allow category display in post preview even when only one category
...
Via: https://core.trac.wordpress.org/changeset/40023
2017-01-31 12:54:55 -06:00
5a2f2893da
santize translation
2017-01-03 20:27:16 +02:00
1f1def7496
update comment
2017-01-03 18:23:33 +02:00
b3287e9b58
Make sure the translation of the post editing link doesn't break because of screen reader text
2017-01-03 18:14:17 +02:00
6e04a5f802
Merge pull request #1035 from bjorn2404/master
...
The header change to use a get_bloginfo : props @bjorn2404
Can you please make sure you explain beyond just using technical calls.
2016-12-23 14:48:15 +00:00
3c7fe6f91e
Merge pull request #1051 from samikeijonen/issue/1041
...
Remove link around header image: props @samikeijonen
2016-12-23 14:29:25 +00:00
59fc136158
Merge pull request #991 from grappler/custom-header
...
Remove deprecated constant HEADER_TEXTCOLOR : props @grappler
2016-12-23 14:22:52 +00:00
2370c59676
Use the_header_image_tag() function.
2016-11-27 12:57:24 +02:00
31a9e90437
Remove link around header image.
2016-11-26 19:26:12 +02:00
8e1367bce3
_s_pingback_header should use get_bloginfo instead of bloginfo because echo is already being used to output the link tag (entire line)
2016-10-18 17:48:16 -05:00
1ed9d1a85e
Remove period from file header
2016-09-27 12:05:53 +06:00
d362be1e30
Remove period from file header
2016-09-27 12:05:33 +06:00
f3ee8eb485
Remove period from file header
2016-09-27 12:04:56 +06:00
99cc3ff5b4
Update customizer.php
2016-09-27 12:04:03 +06:00
394e02a5d5
Remove period from file header
2016-09-27 12:03:40 +06:00
c19b43fe3a
Remove period from file header
2016-09-27 11:58:22 +06:00
ff4b374d6b
Merge pull request #853 from jrfnl/feature/conditional-pingback-header
...
Only generate pingback url header tag when relevant.
2016-09-02 19:37:25 -04:00
71771d92d7
Remove deprecated constant HEADER_TEXTCOLOR
2016-07-24 21:22:27 +02:00
d1ea3e1a75
Using tabs instead of mixed tabs/spaces
...
Mixed usage of tabs/spaces for `/inc/jetpack.php` and `/sass/style.scss`.
2016-07-05 13:04:11 +09:00
21208ab381
Merge pull request #915 from samikeijonen/master
...
comments_popup_link arguments props @samikeijonen.
I think Travis is having a moment about other issues so going to commit as on testing this it does work. Thanks.
2016-03-29 00:01:17 +01:00
ff3b49e7ae
New Jetpack domain
2016-03-10 13:36:21 +02:00
6ae11474be
Merge pull request #888 from jrfnl/feature/slim-down-travis
...
Slim down the travis script - remove superfluous checks.
Fixes #881 .
2016-02-11 09:42:09 -10:00
21e812e748
Let the Core handle all the others arguments but the first one. This is better
...
for accessibility. And fewer strings to translate in your theme.
2016-02-10 13:51:10 +02:00
4a3cd975ec
Let's not forget to clear the js cache as they have changed.
2015-12-15 10:38:37 +01:00
cdd101e16c
Remove comments not ending in a period.
...
Helps avoid Travis CI errors for wrongly formatted comments. Most of
these end of function comments (if not all) are useless anyway.
Props @WPAddiction for reporting.
Fixes #891 .
2015-12-14 18:05:14 -08:00
9638b7e3c6
Only generate pingback url header tag when relevant.
...
Rationale:
1. The principle of pingbacks is based on articles. Pingbacks are a special kind of comments and the article being 'pinged-back' has to be identifiable (which they're not on archive pages and the like).
2. WP only registers a ping if it can identify the article which is supposed to have been 'pung'. See: https://developer.wordpress.org/reference/classes/wp_xmlrpc_server/pingback_ping/
3. Pingbacks, like comments, can be disabled on a per article basis.
Therefore, having the pingback url auto-discovery header in place, only makes sense on singular pages where pings are open.
2015-12-04 16:44:38 +01:00
ead318fd20
Remove custom header admin callbacks.
...
These haven't been needed since 4.1, when the Header page under
Appearance was deprecated and linked to the Customizer instead.
2015-12-03 20:29:32 +00:00
4433c1f0b7
Last 3 non-https WordPress URLs updated and custom header link updated too - issue #734
2015-12-01 21:06:47 +01:00
be085c6d0c
Last 3 non-https WordPress URLs updated - issue #734
2015-12-01 19:34:53 +01:00
22b035ad55
Fix failing Travis build because of extra whitespace
2015-11-11 17:51:13 -05:00
2eb3836006
Merge pull request #848 from ernilambar/master
...
respect content-search.php for search result in Jetpack Infinite Scroll
Merging as comments and second opinion given in ticket.
2015-11-11 20:33:37 +00:00
7c2d3ce6eb
Merge pull request #820 from sixhours/master
...
Remove hfeed from header.php, add to body_class filter. See #740
2015-11-11 20:27:21 +00:00
a64e3a8092
respect content-search.php for search result in Jetpack Infinite Scroll
2015-11-10 11:22:39 +05:45
82e852c454
Fix failing build in Travis
...
* See: https://travis-ci.org/Automattic/_s
* Build failed because of empty lines are not allowed in multi-line function.
2015-10-29 12:25:14 -04:00
6f39c5ecf8
Update PHP Documentation
2015-10-26 16:33:55 +01:00
a29f4497a8
Add theme support for Responsive Videos.
2015-10-13 12:39:42 +02:00
cdd7f9b333
Simplify check for hidden header text.
2015-09-17 16:58:03 +01:00
1f85e9b067
Add 'hfeed' class via body_class
...
* Only add the 'hfeed' class when viewing a non-singular page, such as an index or archive
2015-09-16 15:08:02 -04:00
b1b13f58d8
Merge pull request #775 from davidakennedy/editlinkposttitle
...
Add post title to `edit_post_link`
2015-09-16 19:58:22 +01:00
268a1e2ced
Merge pull request #792 from grantpalin/master
...
Update comparisons to resolve the strict comparison warnings
2015-08-21 19:28:13 -04:00
bdc9a8c52a
Remove _s_wp_title function
...
No longer required under 2 version back support requirements.
2015-08-21 15:10:34 +01:00
149a40d70f
Merge pull request #800 from iamdmitrymayorov/master
...
Remove template-tag shims for versions prior to 4.1. Solves #799 .
2015-08-21 14:11:11 +01:00
72a9a3b7e6
Removing the_posts_navigation(), the_post_navigation(), the_archive_title(), the_archive_description() since 4.3 is out.
2015-08-19 17:40:51 +03:00
6f621af060
Remove _s_render_title()
...
Removing `_s_render_title()`, no longer needed as of 4.3.
2015-08-18 21:55:47 -05:00
af0a4749be
Update comparisons to resolve the strict comparison warnings. See https://github.com/Automattic/_s/issues/784
2015-08-07 09:59:26 -07:00
de9c9888b7
Updated documentation in comments at the top of files.
...
I tried to standardize and expand the documentation and links to
codex.wordpress.org in the comments at the top of most files.
2015-07-12 12:38:18 -04:00
0a0e5c631f
Add post title to `edit_post_link`
...
* Use `__()` instead of `_x()`
* Add translator comment, remove context modifier.
* Remove escaping on `the_title()`; it's trusted data.
Resolves : #774
2015-07-02 17:37:30 -04:00
c60811bf94
Add post title to `edit_post_link`
...
This improves the accessibility of these links, and gives more context for screen reader users. Now, they know exactly where the link goes.
Escaped output with `esc_html_x` and `wp_kses`.
Resolves : #774
2015-06-26 14:22:38 -04:00
175524922c
Fix Codesniffer errors.
2015-05-27 22:19:14 +02:00
2aef92e5a3
Fix remaining PHPCS errors:
...
* Add ignoring in template-tags.php and comments.php.
* Escape header text color in custom-header.php.
2015-05-11 09:18:36 +02:00
6fea1077d8
Escape translations in custom template tags.
...
See #737 .
2015-05-05 12:16:55 +02:00
ef1a884b6c
Escape translation in title shim.
...
See #737 .
2015-05-05 11:59:02 +02:00
7c92e3e138
Update Jetpack URLs to https
...
See #734 .
2015-05-05 11:26:05 +02:00
71d4231cbe
Move template parts into their own dedicated folder and update Infinite Scroll to reflect this change. See #642 . Props @leopuleo.
2015-04-29 08:42:12 +07:00
894bd6b5d3
Use core navigation template tags.
...
* Remove custom arguments from `the_posts_navigation()` and `the_post_navigation()`.
* Adjust fallbacks for `the_posts_navigation()` and `the_post_navigation()`.
* update pot file.
* merge master for style.css and style.scss.
2015-01-07 09:23:28 -08:00
5c6311499b
Update Travis CI build checks. Props @miya0001. See #663 .
2015-01-06 11:48:47 +07:00
3e02659325
Merge pull request #673 from fklein-lu/remove-home-link
...
Remove home link from `wp_page_menu()` args.
2014-12-30 20:21:27 -08:00
2580a0a69f
_s: Remove author data shim.
...
Immediate set up of author data in author archives was added in
WordPress 3.7, so it’s safe to remove.
See https://core.trac.wordpress.org/ticket/14408 .
See a156f2cbab
2014-12-30 20:19:28 -08:00
c4f6755f61
Remove home link from wp_page_menu() args.
2014-12-30 14:53:42 +01:00
37d283481f
Avoid repeatedly checking specific post format.
...
Will only check for a specific post format if it’s a post format
archive page.
See https://core.trac.wordpress.org/changeset/30854
Fixes #664 .
2014-12-22 10:11:39 +01:00
47ee126fb4
Don't check for a private function.
...
Even with WordPress’ commitment to backwards compatibility, we should
probably not bank on private functions being around for ever, and tying
our functionality to it.
This will go old school and do a version check to provide compatibility
with older versions of WordPress. Again, this is only temporary until
4.3 is out.
See #644 .
Fixes #636 .
2014-12-22 10:06:15 +01:00
f2d2495630
Switch in and out of PHP to render fallback title.
...
The upload checks for the .org Theme Directory are rightfully strict about the contents of the title tag.
Switching in and out of PHP should make `_s`-based themes pass those tests again.
See https://github.com/Automattic/_s/pull/644#discussion-diff-22153263
See #644 .
2014-12-22 09:16:13 +01:00
3a25519cc7
Adjust todo notice for wp_title shim.
2014-12-02 20:23:28 +07:00
8b23932190
Merge remote-tracking branch 'origin/master' into title-theme-support
2014-12-02 20:11:14 +07:00
648a5467e9
Better title handling for WordPress 4.1. See #644 .
2014-11-14 08:46:20 +07:00
711ce1967e
Check DOING_AUTOSAVE before flushing transients
...
So that we don’t flush transients more often than necessary.
Fixes #646
2014-11-13 17:44:08 -07:00
bb867c0fcb
_s: Introduce 4.1 archive template tags.
...
Now uses the new archive template tags and makes archive template
titling way simpler!
Added shims for backwards compatibility, which can be removed once
WordPress 4.3 was released.
See https://core.trac.wordpress.org/changeset/30223
Closes #556 .
2014-11-12 15:52:31 -05:00
83792b8566
First pass at better title handling for WordPress 4.1+ with proper back compatibility baked in.
2014-11-11 21:41:10 +07:00
2540fb7b7f
Better WordPress Coding standards.
...
This minor commit kicks off code improvements to _s so that it’s fully in line with WordPress Coding Standards rules.
2014-11-01 07:09:58 +07:00
907403fc52
Merge branch 'Entry-Meta-Output' of https://github.com/Automattic/_s into Entry-Meta-Output
...
Conflicts:
content-single.php
2014-09-10 18:06:15 -07:00
a14b802e75
_s: Move edit link in template tag for consistency
...
Every time `_s_entry_footer()` is used, it’s followed by
`edit_post_link()`. Might as well just move that back in the template
tag.
2014-09-10 17:41:19 -07:00
2990f8260c
_s: Update to entry meta output. See #537
...
* Rename function
* Move edit link outside of function
* Remove comments link on single post
2014-09-04 13:28:24 +02:00
63d8fcb190
Add escaping to custom header example. Make sure that proper attribute escaping is added into the example that's in the custom header include file. Since we're not including this in header.php, we should at least make sure that the example given is proper and passes WordPress Coding Standards checks. See #552 for context.
2014-08-07 11:07:50 +07:00
e6fd8e99cf
Setup is a noun. Set up is a verb. "Setup the WordPress core custom header feature." is incorrect. "Set up the WordPress core custom header feature." is correct.
2014-08-07 10:36:07 +07:00
0d87d0bb70
_s: Continue using a default `time` tag.
...
We only need to change the default markup if published and updated
timestamps are different.
2014-07-30 14:47:16 -05:00
048057ad68
Merge branch 'updated-hAtom' of https://github.com/slobodan/_s into slobodan-updated-hAtom
2014-07-30 14:35:44 -05:00
ba1258f365
_s: Simplify entry meta output
...
- Fix entry-footer inconsistency between content-*.php files
- Move in a function <code>_s_entry_meta()</code> to avoid duplication
---
At the moment there is an inconsistency between content.php and
content-single.php regarding the .entry-footer output.
In my opinion content.php output is would be better to use because it's
easier to translate and allow more customisation.
Finally by moving it into <code>inc/template-tags.php</code> we are
getting rid of some duplicated code.
2014-06-30 16:43:07 +01:00
a78658a393
Revert "_s: Simplify entry meta output"
...
This reverts commit 9e66401930
2014-06-30 16:37:12 +01:00
9e66401930
_s: Simplify entry meta output
...
- Fix entry-footer inconsistency between content-*.php files
- Move in a function <code>_s_entry_meta()</code> to avoid duplication
---
At the moment there is an inconsistency between content.php and
content-single.php regarding the .entry-footer output.
In my opinion content.php output is would be better to use because it's
easier to translate and allow more customisation.
Finally by moving it into <code>inc/template-tags.php</code> we are
getting rid of some duplicated code.
2014-06-30 16:36:36 +01:00
5fffb5e911
Add a non-breaking space to _s_post_nav().
...
Sometimes the title length of a previous or next post would cause
the arrow (larr/rarr) in the link to be wrapped to the next line.
Adding a non-breaking space between the title and the arrow will stick
it to the last word in the title.
2014-06-26 11:50:14 +04:00
00570514d4
Adds .updated class to .entry-date when needed
2014-06-15 13:20:06 +02:00
e24e53e024
Merge pull request #453 from grappler/translation-strings
...
_s: Avoid html tags in "Posted on" string.
2014-06-02 08:28:46 -07:00
86a0cd531d
Pinking shears (remove trailing spaces) in two files.
2014-05-18 13:09:20 -07:00
54d58d548b
fix for a page title error
...
The same error as https://core.trac.wordpress.org/ticket/16468
2014-05-04 15:34:50 +02:00
fc9910cf96
Split strings into variables
2014-05-01 23:27:08 +02:00
796d8e8c7e
_s: Update function return values.
...
Adds missing documentation for `_s_categorized_blog()` and removes void
statements, in accordance with WordPress documentation guidelines.
See
http://make.wordpress.org/core/handbook/inline-documentation-standards/p
hp-documentation-standards/#phpdoc-tags
2014-03-30 12:15:29 -07:00
7d24be9c97
_s: Resolve merge conflicts from master branch.
...
This also retains `$all_the_cool_cats` for some flavor. It has been
around since the initial fork of Toolbox and makes people smile:
https://twitter.com/TheFrosty/status/449581069231071232
2014-03-30 12:00:47 -07:00
5e62b8dc9e
Remove html from string
2014-03-24 00:08:21 +01:00
87ca7b66ad
Prefix transient.
2014-03-18 18:43:00 +04:00
16e0ca504d
Remove redundant package DocBlock within custom header file
2014-03-07 06:41:14 -06:00
09720890a7
_s: Retrieve blog name with the correct context.
...
Passing `'display'` as the second argument will make the blog name filterable and runs it through `wp_texturize()`.
See https://core.trac.wordpress.org/ticket/26811
2014-01-24 09:54:05 -08:00
0f2db471a7
Merge branch 'pr/366'
2014-01-20 20:34:51 -08:00
e55cb8a038
_s: Make it easier to target post navigation links.
...
Removed in 3f4effbFixes #371 .
2014-01-01 17:30:24 -08:00
cb52da6f23
Remove _s_comment
2013-12-22 21:33:16 +01:00
David A. Kennedy
jrfnl
Tomas M
Yoav Farh
Tammie Lister
Sami Keijonen
Bjorn
Bappi
Ulrich Pogson
Kazue Igarashi
Eugene Kopich
Konstantin Obenland
Konstantin Obenland
sarah
patryk
ernilambar
Thomas Guillot
Caroline Moore
Tom de Bruin
Dmitry Mayorov
Emil Uzelac
Grant Palin
PJ
Fränk Klein
Philip Arthur Moore
Nick Daugherty
Konstantin Kovshenin
Slobodan Manic
Lance Willett
Piotr Soluch