Commit Graph

90 Commits

Author SHA1 Message Date
Eli McMakin 44398c68a3 Fixed Issue #354: Removed link on line 90 that was going to a page that no longer exists. 2013-12-09 21:51:18 -06:00
Emil Uzelac 9c6aff64f6 List for main-navigation
Hey guys, I am proposing to remove li in front of the current_page_item and current-menu-item. It's slightly more efficient without and of course all works the same :)
2013-12-02 20:31:15 -06:00
Tracy Rotton 924b5a0a60 Fixed typo in inline comments. 2013-11-17 22:24:13 -05:00
obenland 6f63a0b39a _s: Adhere to updated WordPress core code formatting.
* Update PHPDoc.
* Add periods to the end of comment sentences.
* Limit line length to 80 chars.
* Use C++-style PHP comments only for function and file documentation.
2013-11-07 15:41:41 -04:00
Emil Uzelac a0eec6c63b html input
Proposing to remove html input from the button class. It overrides more than is needed. For example it will interfere with bbPress editor styles. It's safer to leave input[type="button"] as-is. Please see: http://i.imgur.com/Q98uqBH.png
2013-10-20 20:05:11 -05:00
Vinod Dalvi 430d379f4b Fixed minor WordPress coding standard issues. 2013-09-30 22:32:42 -07:00
Vinod Dalvi dbb5797ca5 Fixed some minor spacing issues. 2013-09-14 09:25:32 -07:00
Vinod Dalvi c7f8623716 Made Changes in CSS to Make it Adhere to WordPress CSS Coding Standards. 2013-09-12 14:15:25 -07:00
obenland dff92a0e9e _s: Be more specific about clearing elements.
(Introduced in b1d3b53)

While class attribute selectors are very powerful and might help in
keeping stylesheets concise and easier to maintain, they don't work very
well with a project like WordPress. Not only can third-party scripts
insert and rely on specific class names that get picked up by attribute
selectors for common class names. But more importantly WordPress passes
category and tag slugs on to post classes, which can result in
unpredictible results.

Fixes #284, fixes #309.
2013-09-12 13:11:38 +09:00
obenland 0ac069a0bf _s: Update selectors to reflect the changes in 810e499. Fixes #288. 2013-08-21 10:38:39 -04:00
Konstantin Obenland a462ad5720 Merge pull request #280 from jayj/jayj-underscores-url-selector
Add `url` to the list of input selectors.
2013-08-11 15:06:15 -07:00
Konstantin Obenland 3c4b905086 Merge pull request #279 from jayj/jayj-underscores-heading-spacing
Add spaces between heading selectors.
2013-08-07 08:26:21 -07:00
Jesper Johansen b5864622ee Add the <main> element to the list of HTML5 selectors 2013-08-07 00:59:28 +02:00
Jesper Johansen c8ca427356 Add a space between the heading selectors 2013-08-07 00:58:31 +02:00
Jesper Johansen 1108a8a582 Add `url` to the list of input selectors 2013-08-07 00:57:17 +02:00
Konstantin Kovshenin 167197dd07 Add a domain path header to the stylesheet for translation 2013-07-30 23:45:55 +04:00
obenland 1f15c20995 _s: Make theme headers translatable. Props @grappler. Fixes #203. 2013-07-30 11:58:13 -07:00
Calvin Winter 7276a13a4b Fixed bug where menu does not toggle on click
fixes the error described here: https://github.com/Automattic/_s/issues/261
2013-07-17 23:28:49 -04:00
michaeldcain 31331b4b64 Switch "navigation-" back to "-navigation"
Original edit not needed for `[class*="navigation"]` selector. Matches
other class/id navigation naming conventions.
2013-07-11 16:42:45 -04:00
michaeldcain d480e820c3 Switch ".navigation-main" back to ".main-navigation"
Original edit not needed for `[class*="navigation"]` selector. Matches
other class/id navigation naming conventions.
2013-07-11 16:17:12 -04:00
obenland d406dc8f8c _s: Add `.page-content` class to `style.css` to encourage styling. Also
removes some redundant comments.
2013-07-11 12:18:47 -07:00
obenland 6e22132768 _s: Update search form markup to make it forward compatible with HTML5
search form in 3.6. As a result, `searchfornm.php` can be safely
removed in the future. Also fixes #240.
2013-06-29 16:19:10 -04:00
obenland 39d8f7ad61 _s: Include "entry updated" as part of the hAtom. Props @michiecat. See
#131, fixes #170.
2013-06-27 06:54:02 -07:00
Michael Fields ac3cda4543 Rework Navigation Menu Part 2
* Separate scoping and assignment so that a decision does not need to be made as to whether we should intermix spaces and tabs on the left
 * Restore the previously removed nav-menu class addition to the first unordered list in `#site-navigation`.
 * Restore the `.navigation-main.toggled-on .nav-menu` selector.
 * Remove rules for the `.main-small-navigation ul` selector.
2013-06-25 01:45:52 -07:00
Michael Fields 4c396f6f9b Rework menu navigation: these changes build off pull request #239 for issue #200
* Only set button and menu if container is not null.
 * Break up the "return early" conditional into multiple parts.
 * Shorten the name of the toggled class from `toggled-on` to `toggled`.
 * Restore the "Hide menu toggle button if menu is empty." documentation.
 * Remove the `nav-menu` class. The previous code would replace any custom custom classes applied via `wp_nav_menu()` or template file.
 * Replace the `nav-menu` selector is style.css with selectors that will target both a custom nav menu and a page menu. These changes could use critical feedback. Do you know of an edge case where they might not work as expected?
2013-06-16 20:29:17 -07:00
obenland 99f6d17f9c _s: Revert reset changes. They were accidentally committed after
resolving merge conflicts.
2013-05-28 09:39:02 -07:00
obenland f0ed253d5b Merge branch 'custom_header_fix' of https://github.com/iamtakashi/_s
into iamtakashi-custom_header_fix

Conflicts:
	inc/custom-header.php
2013-05-28 09:31:59 -07:00
Philip Arthur Moore 1ea2ccd909 Remove hgroup from theme. It's dead now: http://www.sitepoint.com/html5-hgroup-element-dropped/. In its place a div will be use that inherits the old class that was being applied to header. 2013-04-23 15:45:23 +09:00
gatespace 48702363eb `nav-` prefix for css class 'previous/next'.
Re-introduce nav- prefix for previous/next links (see 6056c1e).
nav- prefix for css class 'previous/next'.
2013-04-22 20:08:49 +09:00
Philip Arthur Moore 790b765ac2 Ditch license.txt from theme and change License URI to canonical source of information on version 2 of the GNU General Public License. Also adjust theme license DocBlock to explicitly state that _s is GPL v2 or later. 2013-04-22 08:58:10 +09:00
Philip Arthur Moore ee7323950a Update copyright/license notice. The capital S in _S felt really weird. Also, shorten copyright text and re-arrange link to Underscores.me. 2013-04-04 11:45:57 -07:00
Philip Arthur Moore 5c3689cd67 Update stylesheet to include proper copyright and license attribution in style.css. Fixes #10 and also reverts the changes that were made in 06463db11d, since we can now use this copyright notice to find out which themes are based on Underscores. 2013-04-04 11:01:38 -07:00
obenland f424711c65 _s: Simplify the way we do responsive images. Props @philiparthurmoore.
Fixes #120.
2013-03-27 11:37:20 -07:00
obenland 4c120839ec _s: Remove vendor prefixes on box-shadow and some legacy IE6/7
adjustments. Props @SeamlessThemes. Fixes #176.
2013-03-26 15:39:48 -07:00
obenland 1ba2f62752 _s: Use .screen-reader-text rather than .assistive-text.
With 3.6 introducing many HTML5 improvements the need for custom
searchform and comment templates will vanish. To cope with core's
.screen-reader-text class, let's make the switch early.

Commit also adds core's focus styles for screen reader texts, so they
can actually be used.
2013-03-13 15:39:05 -07:00
Philip Arthur Moore 06463db11d Add an identifier into style.css that will allow us — the WordPress.com Theme Team — to easily search for themes that have been built with _s. Now there will be no more scratching our heads whenever someone asks, "What have you built with _s?" :) 2013-03-07 18:30:21 -06:00
obenland b1d3b5369c _s: Introduce a default for clearing floats.
Selectors provide clearing out of the box for the site container,
header, footer, main container, content container, entry content, and
comment content.

Also, theme developers can optionally use .clear as a utility class. Or
delete it.

For more information about the philosophy behind the approach of
selecting class elements, see
http://24ways.org/2012/a-harder-working-class/

Fixes #88.
2013-03-04 17:16:44 -08:00
obenland c4f2aa32ce _s: Formatting changes:
- Reduce element comments to either the element id or the first element
class.
- Tabs > Spaces.
- Improve adherence to formatting guidelines.
2013-03-04 16:41:38 -08:00
obenland 914c6c21de _s: Simpler selector for lists within lists. 2013-03-04 15:14:51 -08:00
michiecat afd1db501e Update style.css 2013-02-27 23:34:26 -08:00
michiecat 35c3162e4f Update style.css 2013-02-27 23:33:51 -08:00
Philip Arthur Moore dcd62e323c Manually revert all changes made after debefa8b98 so that the code proposed in #131 gets a proper review. 2013-02-28 01:12:59 -06:00
Philip Arthur Moore c8c60b3904 Let us try this one more time. Revert all changes made to _s up until commit debefa merge until #131 has had a proper code review. 2013-02-28 01:04:34 -06:00
obenland fa3d86936a _s: Simplify and unify navigation classes throughout Underscores.
For more information about the philosophy behind the new approach,
see http://24ways.org/2012/a-harder-working-class/
2013-02-27 14:47:03 -08:00
obenland a1b163e8ea Merge branch 'master' of https://github.com/Automattic/_s.git 2013-02-27 13:36:08 -08:00
obenland ebe5c56c42 _s: Update layouts to use classes when appropriate. Fixes #55. 2013-02-27 13:35:28 -08:00
sixhours 620b8e5e53 Merge pull request #66 from kovshenin/patch-8
Replace small-menu.js with navigation.js inspired by Twenty Twelve.
2013-02-27 13:28:31 -08:00
Takashi Irie ed6a89fa20 Change the search form text input to search type and add the basic style for it 2013-02-27 20:26:16 +00:00
Philip Arthur Moore dc730a3bc5 Reduce default padding on buttons and reset/submit inputs. Fixes #161. 2013-02-27 11:32:42 -06:00
Philip Arthur Moore fbb50c4e90 Fix incorrect rem value. See #160. Props @dollseb. 2013-02-22 18:04:12 -06:00