Konstantin Obenland
70db168dc6
Merge pull request #702 from Automattic/fix-701
...
Sanitize location.hash before passing it to getElementById.
See #701 .
2015-02-17 10:16:21 -08:00
Konstantin Obenland
4309cd6c56
Merge pull request #700 from pixelstrolch/comment-navigation
...
Consistent navigation.
Fixes #699 .
2015-02-17 10:00:45 -08:00
Miguel Fonseca
dea243f2eb
Sanitize location.hash before passing it to getElementById
...
There is no actual vulnerability in the existing implementation, as we
can only fetch existing elements (no DOM injection is possible). Plus,
the only call occurring on those elements is `HTMLElement#focus`.
Consider this an extra, more future-proof precaution.
2015-02-17 17:52:36 +00:00
Stefan Brechbühl
e45aff27ed
Consistent navigation
...
Handle the comment navigation the same way as the new the_post_navigation() and the_posts_navigation().
2015-02-14 12:21:53 +01:00
Konstantin Obenland
56bad5250d
Merge pull request #698 from slushman/master
...
Remove duplicate b & strong and improve SASS inheritance.
2015-02-10 08:25:07 -08:00
Chris Wilcoxson
7ef388656e
Removed duplicate b & strong styling, changed SASS files to make use of parent selector: _menu, _galleries, _buttons, _fields, and _elements.
2015-02-09 23:11:59 -06:00
Konstantin Obenland
41f33d3c9a
Merge pull request #695 from FStop/694-css-small-twice
...
Remove duplicate CSS rule for `small`.
Fixes #694 .
2015-02-07 10:16:17 -08:00
Gabriel Luethje
b83c659915
Remove duplicate CSS rules for `small` - refs #694
2015-02-06 16:23:37 -07:00
Cor van Noorloos
084794098c
update travis.yml
...
In short this updates `travis.yml`'s indent size to 2 spaces as per
WordPress' development repo and Jetpack.
Inserts final newline.
Uses a period at the end of each sentence.
2015-01-23 23:55:02 +01:00
Konstantin Obenland
ea84ceec95
Merge branch 'issue/617'
2015-01-14 09:37:03 -08:00
Konstantin Obenland
ec2a5e212a
Fixed merge conflicts.
2015-01-14 09:35:02 -08:00
Konstantin Obenland
60a6eeb6a5
Merge pull request #679 from iandunn/center-block-margins
...
Remove unnecessary margin-top and margin-bottom from center-block mixin.
2015-01-12 13:36:42 -08:00
Ian Dunn
6b0c7717c9
Set a fixed table-layout in the clearfix to avoid max-width conflict.
...
Some browsers ignore the max-width property on children of elements with display: table.
See http://www.carsonshold.com/2014/07/css-display-table-cell-child-width-bug-in-firefox-and-ie/
2015-01-11 13:50:06 -08:00
Ian Dunn
3d6bd4df39
Remove unnecessary margin-top and margin-bottom from center-block mixin.
...
Setting top and bottom margins is not necessary to center the element, and it can potentially override the margins set by another rule.
2015-01-11 11:33:19 -08:00
Mignon Style
c482072932
Reflect the change of color in the customizer.
...
Fixed ".site-title" to ".site-title a".
2015-01-09 17:09:22 +09:00
Konstantin Obenland
6b2e7c8b44
Merge branch 'pr/667'
2015-01-07 09:43:31 -08:00
Konstantin Obenland
e6366f4474
Revert "Merge branch 'pr/667'"
...
This reverts commit a7c2f89982
.
Been meaning to give proper attribution, but Git lost the commit after
I edited the merge commit.
See #667 .
2015-01-07 09:40:24 -08:00
Konstantin Obenland
a7c2f89982
Merge branch 'pr/667'
...
Fixes #667 .
Props @gatespace.
2015-01-07 09:35:26 -08:00
Kazue Igarashi
894bd6b5d3
Use core navigation template tags.
...
* Remove custom arguments from `the_posts_navigation()` and `the_post_navigation()`.
* Adjust fallbacks for `the_posts_navigation()` and `the_post_navigation()`.
* update pot file.
* merge master for style.css and style.scss.
2015-01-07 09:23:28 -08:00
Philip Arthur Moore
5c6311499b
Update Travis CI build checks. Props @miya0001. See #663 .
2015-01-06 11:48:47 +07:00
Philip Arthur Moore
e5e31d472c
Update WP versions that are being used in Travis checks. [skip ci]
2015-01-06 10:45:45 +07:00
Konstantin Obenland
115221ea34
Bring back box-sizing reset.
...
Props @chrisdc.
See #674 .
2014-12-31 12:27:05 -08:00
Konstantin Obenland
396dea5656
Merge pull request #670 from JulienMelissas/patch-1
...
Add braces around if statement.
2014-12-31 12:16:57 -08:00
Konstantin Obenland
75c5023576
_s: Use semantic versioning.
...
Fairly minor and noncommittal change. It does encourage theme authors
to think about semantically versioning their themes but doesn’t require
`_s` to take a strong stand on it.
It also removes an obstacle from submitting the generated theme to the
WordPress.org Theme Directory, as it refuses themes with non-numeric
version numbers.
Fixes https://github.com/Automattic/underscores.me/issues/8
Closes https://github.com/Automattic/underscores.me/pull/20
Props @ScottSmith95.
2014-12-30 20:34:51 -08:00
Konstantin Obenland
3e02659325
Merge pull request #673 from fklein-lu/remove-home-link
...
Remove home link from `wp_page_menu()` args.
2014-12-30 20:21:27 -08:00
Konstantin Obenland
2580a0a69f
_s: Remove author data shim.
...
Immediate set up of author data in author archives was added in
WordPress 3.7, so it’s safe to remove.
See https://core.trac.wordpress.org/ticket/14408 .
See a156f2cbab
.
2014-12-30 20:19:28 -08:00
Konstantin Obenland
01819a8a0a
_s: Update copyright year in anticipation of 2015.
2014-12-30 20:08:44 -08:00
Konstantin Obenland
9711e6d542
_s: Remove leading white space in style.scss.
...
See de7a9b576b
.
2014-12-30 20:07:35 -08:00
Konstantin Obenland
de7a9b576b
_s: Remove leading white space for theme name.
...
At some point in the past it was believed that a leading whitespace was
necessary for a proper replacement.
Let’s see if the existing replace handler can indeed handle it without
it.
See
https://github.com/Automattic/underscores.me/commit/7671cad5685ae8df50a0
2f871a1ae28119b8dbf1
2014-12-30 20:05:47 -08:00
Fränk Klein
c4f6755f61
Remove home link from wp_page_menu() args.
2014-12-30 14:53:42 +01:00
Konstantin Obenland
6c47be98c1
Normalize rather than Reset.
...
The reset we used was a mix of Normalize, the Paul Irish reset,
sprinkled with some blueprint.css, and base styles. It was hard to
maintain and just seemed outdated (setting the base font-size to 10px
instead of 16px, among other things).
Normalize sets saner defaults and is generally just not as disruptive
as a full reset.
The code was added as is, has only its comments stripped (for now), and
is not mixed with any styles to make future updates to it as easy as
possible.
See #3 , #44 , #174 , #267 , #617 .
2014-12-30 01:28:19 +01:00
Julien Melissas
67fb1af3f3
Add braces around if statement.
...
Running jshint on this file returned an error, adding braces fixed it. Please add braces around if statements!!! :)
2014-12-24 00:19:34 -05:00
Konstantin Obenland
37d283481f
Avoid repeatedly checking specific post format.
...
Will only check for a specific post format if it’s a post format
archive page.
See https://core.trac.wordpress.org/changeset/30854
Fixes #664 .
2014-12-22 10:11:39 +01:00
Konstantin Obenland
47ee126fb4
Don't check for a private function.
...
Even with WordPress’ commitment to backwards compatibility, we should
probably not bank on private functions being around for ever, and tying
our functionality to it.
This will go old school and do a version check to provide compatibility
with older versions of WordPress. Again, this is only temporary until
4.3 is out.
See #644 .
Fixes #636 .
2014-12-22 10:06:15 +01:00
Konstantin Obenland
f2d2495630
Switch in and out of PHP to render fallback title.
...
The upload checks for the .org Theme Directory are rightfully strict about the contents of the title tag.
Switching in and out of PHP should make `_s`-based themes pass those tests again.
See https://github.com/Automattic/_s/pull/644#discussion-diff-22153263
See #644 .
2014-12-22 09:16:13 +01:00
sixhours
204654ac1f
Revert previous (unintentional) commit
2014-12-17 15:09:44 -05:00
sixhours
88f94a9a4e
First pass at fixing drop-down menus for touch
...
This patch allows the user to view a site on a touch screen tablet and
access child menus by clicking on the parent once, or access the parent
by clicking on it twice. Props @iamtakashi for the original fix.
2014-12-17 15:03:17 -05:00
Philip Arthur Moore
108799d104
Revert #638 for a bit.
2014-12-03 18:46:33 +07:00
Philip Arthur Moore
687e5e6e92
Merge branch 'grappler-child-theme-support'
2014-12-03 17:06:24 +07:00
Philip Arthur Moore
c000d6489a
Merge branch 'child-theme-support' of github.com:grappler/_s into grappler-child-theme-support
2014-12-03 17:00:09 +07:00
Philip Arthur Moore
0750bd029b
Update POT. Fixes #645 .
2014-12-03 16:47:10 +07:00
Philip Arthur Moore
cfda0096b3
Merge pull request #644 from Automattic/title-theme-support
...
Better WordPress title handling for WordPress 4.1+ with proper back compat.
2014-12-02 20:25:57 +07:00
Philip Arthur Moore
3a25519cc7
Adjust todo notice for wp_title shim.
2014-12-02 20:23:28 +07:00
Philip Arthur Moore
8b23932190
Merge remote-tracking branch 'origin/master' into title-theme-support
2014-12-02 20:11:14 +07:00
Konstantin Obenland
b550416497
Merge pull request #648 from nickdaugherty/check-autosaves
...
Check DOING_AUTOSAVE before flushing transients.
Fixes #646 .
2014-11-14 00:33:57 -05:00
Philip Arthur Moore
648a5467e9
Better title handling for WordPress 4.1. See #644 .
2014-11-14 08:46:20 +07:00
Nick Daugherty
711ce1967e
Check DOING_AUTOSAVE before flushing transients
...
So that we don’t flush transients more often than necessary.
Fixes #646
2014-11-13 17:44:08 -07:00
Konstantin Obenland
bb867c0fcb
_s: Introduce 4.1 archive template tags.
...
Now uses the new archive template tags and makes archive template
titling way simpler!
Added shims for backwards compatibility, which can be removed once
WordPress 4.3 was released.
See https://core.trac.wordpress.org/changeset/30223
Closes #556 .
2014-11-12 15:52:31 -05:00
Konstantin Obenland
6c783cd09f
Merge pull request #580 from jgclarke/patch-1
...
Use `div`s consistently throughout templates.
2014-11-12 14:49:17 -05:00
Konstantin Obenland
e142af3a27
Merge pull request #643 from Automattic/aria-toggle
...
Improve menu toggle accessibility.
Fixes #575 .
2014-11-12 14:35:29 -05:00