Commit Graph

150 Commits

Author SHA1 Message Date
jrfnl 8470f55f92 Avoid going in and out of PHP unnecessarily.
Closes #854

Includes minor alignment changes for easier readability/detection of start/end of conditions.
2015-11-11 22:59:40 +01:00
Tammie Lister 2eb3836006 Merge pull request #848 from ernilambar/master
respect content-search.php for search result in Jetpack Infinite Scroll
Merging as comments and second opinion given in ticket.
2015-11-11 20:33:37 +00:00
Tammie Lister 7c2d3ce6eb Merge pull request #820 from sixhours/master
Remove hfeed from header.php, add to body_class filter. See #740
2015-11-11 20:27:21 +00:00
ernilambar a64e3a8092 respect content-search.php for search result in Jetpack Infinite Scroll 2015-11-10 11:22:39 +05:45
David A. Kennedy 82e852c454 Fix failing build in Travis
* See: https://travis-ci.org/Automattic/_s
* Build failed because of empty lines are not allowed in multi-line function.
2015-10-29 12:25:14 -04:00
Thomas Guillot 6f39c5ecf8 Update PHP Documentation 2015-10-26 16:33:55 +01:00
Thomas Guillot a29f4497a8 Add theme support for Responsive Videos. 2015-10-13 12:39:42 +02:00
sarah cdd7f9b333 Simplify check for hidden header text. 2015-09-17 16:58:03 +01:00
Caroline Moore 1f85e9b067 Add 'hfeed' class via body_class
* Only add the 'hfeed' class when viewing a non-singular page, such as an index or archive
2015-09-16 15:08:02 -04:00
sarah ✈ semark b1b13f58d8 Merge pull request #775 from davidakennedy/editlinkposttitle
Add post title to `edit_post_link`
2015-09-16 19:58:22 +01:00
David A. Kennedy 268a1e2ced Merge pull request #792 from grantpalin/master
Update comparisons to resolve the strict comparison warnings
2015-08-21 19:28:13 -04:00
Tom de Bruin bdc9a8c52a Remove _s_wp_title function
No longer required under 2 version back support requirements.
2015-08-21 15:10:34 +01:00
sarah ✈ semark 149a40d70f Merge pull request #800 from iamdmitrymayorov/master
Remove template-tag shims for versions prior to 4.1. Solves #799.
2015-08-21 14:11:11 +01:00
Dmitry Mayorov 72a9a3b7e6 Removing the_posts_navigation(), the_post_navigation(), the_archive_title(), the_archive_description() since 4.3 is out. 2015-08-19 17:40:51 +03:00
Emil Uzelac 6f621af060 Remove _s_render_title()
Removing `_s_render_title()`, no longer needed as of 4.3.
2015-08-18 21:55:47 -05:00
Grant Palin af0a4749be Update comparisons to resolve the strict comparison warnings. See https://github.com/Automattic/_s/issues/784 2015-08-07 09:59:26 -07:00
PJ de9c9888b7 Updated documentation in comments at the top of files.
I tried to standardize and expand the documentation and links to
codex.wordpress.org in the comments at the top of most files.
2015-07-12 12:38:18 -04:00
David A. Kennedy 0a0e5c631f Add post title to `edit_post_link`
* Use `__()` instead of `_x()`
* Add translator comment, remove context modifier.
* Remove escaping on `the_title()`; it's trusted data.

Resolves: #774
2015-07-02 17:37:30 -04:00
David A. Kennedy c60811bf94 Add post title to `edit_post_link`
This improves the accessibility of these links, and gives more context for screen reader users. Now, they know exactly where the link goes.

Escaped output with `esc_html_x` and `wp_kses`.

Resolves: #774
2015-06-26 14:22:38 -04:00
Fränk Klein 175524922c Fix Codesniffer errors. 2015-05-27 22:19:14 +02:00
Fränk Klein 2aef92e5a3 Fix remaining PHPCS errors:
* Add ignoring in template-tags.php and comments.php.
* Escape header text color in custom-header.php.
2015-05-11 09:18:36 +02:00
Fränk Klein 6fea1077d8 Escape translations in custom template tags.
See #737.
2015-05-05 12:16:55 +02:00
Fränk Klein ef1a884b6c Escape translation in title shim.
See #737.
2015-05-05 11:59:02 +02:00
Fränk Klein 7c92e3e138 Update Jetpack URLs to https
See #734.
2015-05-05 11:26:05 +02:00
Philip Arthur Moore 71d4231cbe Move template parts into their own dedicated folder and update Infinite Scroll to reflect this change. See #642. Props @leopuleo. 2015-04-29 08:42:12 +07:00
Kazue Igarashi 894bd6b5d3 Use core navigation template tags.
* Remove custom arguments from `the_posts_navigation()` and `the_post_navigation()`.
* Adjust fallbacks for `the_posts_navigation()` and `the_post_navigation()`.
* update pot file.
* merge master for style.css and style.scss.
2015-01-07 09:23:28 -08:00
Philip Arthur Moore 5c6311499b Update Travis CI build checks. Props @miya0001. See #663. 2015-01-06 11:48:47 +07:00
Konstantin Obenland 3e02659325 Merge pull request #673 from fklein-lu/remove-home-link
Remove home link from `wp_page_menu()` args.
2014-12-30 20:21:27 -08:00
Konstantin Obenland 2580a0a69f _s: Remove author data shim.
Immediate set up of author data in author archives was added in
WordPress 3.7, so it’s safe to remove.

See https://core.trac.wordpress.org/ticket/14408.
See a156f2cbab.
2014-12-30 20:19:28 -08:00
Fränk Klein c4f6755f61 Remove home link from wp_page_menu() args. 2014-12-30 14:53:42 +01:00
Konstantin Obenland 37d283481f Avoid repeatedly checking specific post format.
Will only check for a specific post format if it’s a post format
archive page.

See https://core.trac.wordpress.org/changeset/30854
Fixes #664.
2014-12-22 10:11:39 +01:00
Konstantin Obenland 47ee126fb4 Don't check for a private function.
Even with WordPress’ commitment to backwards compatibility, we should
probably not bank on private functions being around for ever, and tying
our functionality to it.

This will go old school and do a version check to provide compatibility
with older versions of WordPress. Again, this is only temporary until
4.3 is out.

See #644.
Fixes #636.
2014-12-22 10:06:15 +01:00
Konstantin Obenland f2d2495630 Switch in and out of PHP to render fallback title.
The upload checks for the .org Theme Directory are rightfully strict about the contents of the title tag.
Switching in and out of PHP should make `_s`-based themes pass those tests again.

See https://github.com/Automattic/_s/pull/644#discussion-diff-22153263
See #644.
2014-12-22 09:16:13 +01:00
Philip Arthur Moore 3a25519cc7 Adjust todo notice for wp_title shim. 2014-12-02 20:23:28 +07:00
Philip Arthur Moore 8b23932190 Merge remote-tracking branch 'origin/master' into title-theme-support 2014-12-02 20:11:14 +07:00
Philip Arthur Moore 648a5467e9 Better title handling for WordPress 4.1. See #644. 2014-11-14 08:46:20 +07:00
Nick Daugherty 711ce1967e Check DOING_AUTOSAVE before flushing transients
So that we don’t flush transients more often than necessary.

Fixes #646
2014-11-13 17:44:08 -07:00
Konstantin Obenland bb867c0fcb _s: Introduce 4.1 archive template tags.
Now uses the new archive template tags and makes archive template
titling way simpler!

Added shims for backwards compatibility, which can be removed once
WordPress 4.3 was released.

See https://core.trac.wordpress.org/changeset/30223
Closes #556.
2014-11-12 15:52:31 -05:00
Philip Arthur Moore 83792b8566 First pass at better title handling for WordPress 4.1+ with proper back compatibility baked in. 2014-11-11 21:41:10 +07:00
Philip Arthur Moore 2540fb7b7f Better WordPress Coding standards.
This minor commit kicks off code improvements to _s so that it’s fully in line with WordPress Coding Standards rules.
2014-11-01 07:09:58 +07:00
Konstantin Obenland 907403fc52 Merge branch 'Entry-Meta-Output' of https://github.com/Automattic/_s into Entry-Meta-Output
Conflicts:
	content-single.php
2014-09-10 18:06:15 -07:00
Konstantin Obenland a14b802e75 _s: Move edit link in template tag for consistency
Every time `_s_entry_footer()` is used, it’s followed by
`edit_post_link()`. Might as well just move that back in the template
tag.
2014-09-10 17:41:19 -07:00
Thomas Guillot 2990f8260c _s: Update to entry meta output. See #537
* Rename function
* Move edit link outside of function
* Remove comments link on single post
2014-09-04 13:28:24 +02:00
Philip Arthur Moore 63d8fcb190 Add escaping to custom header example. Make sure that proper attribute escaping is added into the example that's in the custom header include file. Since we're not including this in header.php, we should at least make sure that the example given is proper and passes WordPress Coding Standards checks. See #552 for context. 2014-08-07 11:07:50 +07:00
Philip Arthur Moore e6fd8e99cf Setup is a noun. Set up is a verb. "Setup the WordPress core custom header feature." is incorrect. "Set up the WordPress core custom header feature." is correct. 2014-08-07 10:36:07 +07:00
Konstantin Obenland 0d87d0bb70 _s: Continue using a default `time` tag.
We only need to change the default markup if published and updated
timestamps are different.
2014-07-30 14:47:16 -05:00
Konstantin Obenland 048057ad68 Merge branch 'updated-hAtom' of https://github.com/slobodan/_s into slobodan-updated-hAtom 2014-07-30 14:35:44 -05:00
Thomas Guillot ba1258f365 _s: Simplify entry meta output
- Fix entry-footer inconsistency between content-*.php files
- Move in a function <code>_s_entry_meta()</code> to avoid duplication

---

At the moment there is an inconsistency between content.php and
content-single.php regarding the .entry-footer output.

In my opinion content.php output is would be better to use because it's
easier to translate and allow more customisation.

Finally by moving it into <code>inc/template-tags.php</code> we are
getting rid of some duplicated code.
2014-06-30 16:43:07 +01:00
Thomas Guillot a78658a393 Revert "_s: Simplify entry meta output"
This reverts commit 9e66401930.
2014-06-30 16:37:12 +01:00
Thomas Guillot 9e66401930 _s: Simplify entry meta output
- Fix entry-footer inconsistency between content-*.php files
- Move in a function <code>_s_entry_meta()</code> to avoid duplication

---

At the moment there is an inconsistency between content.php and
content-single.php regarding the .entry-footer output.

In my opinion content.php output is would be better to use because it's
easier to translate and allow more customisation.

Finally by moving it into <code>inc/template-tags.php</code> we are
getting rid of some duplicated code.
2014-06-30 16:36:36 +01:00