rayelliott
/
_s
Archived
forked from mirror/_s
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,275 Commits 2 Branches 0 Tags 32 MiB
Commit Graph

73 Commits

Author SHA1 Message Date
jrfnl 98e3e75109 CS: prefix all variables 
While template files are intended to be included from within a function, this doesn't guarantee they always will be.

Therefore all variables declared within template files also need to be prefixed with a theme specific prefix.

As these are "local" variables, renaming them does not constitute a BC-break.
 2018-02-27 14:34:54 +01:00
Ulrich Pogson b26b6ebfa4 Move PHP tags on it’s own line & correct indention 
This fixes a few of the errors from the news sniffs in WPCS 0.12.0 and also standardizes the indention between the PHP and HTML
 2018-02-27 14:34:53 +01:00
Bappi 32a9dbd5d5 Proper Indentation 
Metas and Links within Head should be indented as it is a common practice
 2017-07-10 09:33:38 +06:00
David A. Kennedy 2bef512355 _s: Add basic custom logo support 
See: https://codex.wordpress.org/Theme_Logo

Closes #922
 2017-06-26 18:47:12 -04:00
David A. Kennedy f56a070c2b Remove landmark roles 
* With better browser support, these roles aren't needed now.
* Most newer browsers imply them via HTML5 semantics. See: http://html5doctor.com/on-html-belts-and-aria-braces/

Fixes #1132
 2017-06-23 12:41:05 -04:00
David A. Kennedy 606e1135dd Merge pull request #1093 from B-07/patch-2 
Make doctype lowercase for better consistency with other HTML tags
 2017-06-09 23:02:24 -04:00
jrfnl a65be48368 CS: Fix code layout of nested function calls with associative arrays. 2017-04-03 00:46:36 +02:00
Bappi 095f3422f7 doctype uppercase to lowercase 2017-03-16 01:15:18 +06:00
Tammie Lister 9700947f74 Merge pull request #1018 from mrwweb/tux-menu-naming 
Change primary menu idea to menu-1: props @mrwweb
 2016-12-23 14:40:15 +00:00
Tammie Lister bd858e4e96 Merge pull request #1028 from B-07/master 
Remove period from file header
 2016-12-23 12:19:50 +00:00
Bappi c5cdd97c40 Remove period from file header 2016-09-27 12:21:35 +06:00
mrwweb 396b9cbcd4 change primary menu idea to menu-1 to align with new Automattic "Theme User Experiences Requirements" 2016-09-15 18:06:11 -07:00
David A. Kennedy 44f41babcd Fix skip to content link. 
* Reverts this commit: https://github.com/Automattic/_s/pull/927 The issue for that, #928 referenced an old commit. The `id` is still in the source though.
* Brought up by #982. The `id` was correct, should not have been changed and this fixes everything.

Fixes #982
 2016-07-15 09:53:29 -04:00
Jasper de Groot 0f81201b53 Correct href for skip to content link 2016-02-27 13:26:48 +01:00
jrfnl 9638b7e3c6 Only generate pingback url header tag when relevant. 
Rationale:
1. The principle of pingbacks is based on articles. Pingbacks are a special kind of comments and the article being 'pinged-back' has to be identifiable (which they're not on archive pages and the like).
2. WP only registers a ping if it can identify the article which is supposed to have been 'pung'. See: https://developer.wordpress.org/reference/classes/wp_xmlrpc_server/pingback_ping/
3. Pingbacks, like comments, can be disabled on a per article basis.

Therefore, having the pingback url auto-discovery header in place, only makes sense on singular pages where pings are open.
 2015-12-04 16:44:38 +01:00
jrfnl 8470f55f92 Avoid going in and out of PHP unnecessarily. 
Closes #854

Includes minor alignment changes for easier readability/detection of start/end of conditions.
 2015-11-11 22:59:40 +01:00
Tammie Lister 7c2d3ce6eb Merge pull request #820 from sixhours/master 
Remove hfeed from header.php, add to body_class filter. See #740
 2015-11-11 20:27:21 +00:00
jrfnl 6ba9dbcf6b Ignore WPCS output escape warning for description as it *is* already correctly escaped. 
Fixes failing travis build.
 2015-11-11 15:34:03 +01:00
Ty Carlson 9bfae01ae4 only output tagline markup when tagline exists or is_customize_preview 2015-09-21 16:59:28 -05:00
Caroline Moore 3e8580d518 Remove 'hfeed' class from header.php 
* This was moved to inc/extras.php to be added via body_class filter
 2015-09-16 15:09:09 -04:00
Konstantin Obenland 4b36cf3053 Merge pull request #781 from PJ-Finlay/add-documentation-in-comments 
Updated file documentation.
 2015-08-03 12:13:35 -07:00
PJ de9c9888b7 Updated documentation in comments at the top of files. 
I tried to standardize and expand the documentation and links to
codex.wordpress.org in the comments at the top of most files.
 2015-07-12 12:38:18 -04:00
Morten Rand-Hendriksen 069d708834 Amended patch to display site-title as paragraph on single posts and pages as per discussion in PR. 2015-07-03 14:04:38 -07:00
Morten Rand-Hendriksen dc6d3fa08c New heading structure - redux of #651. Provides proper semantic structure for titles throughout theme: 
In header.php: Site title set to H1 on front page, div on other pages
In functions.php: Widget title set to H2 for semantic hierarchy
In content-search.php and content.php: Heading set to H2 as page title is "Search" or "Archive title" etc.
 2015-06-28 12:06:02 -07:00
Sagar Jadhav 8d7f3b9c11 Updated Tagline markup as per WC3 guidelines. 2015-05-29 19:55:58 +05:30
Fränk Klein 175524922c Fix Codesniffer errors. 2015-05-27 22:19:14 +02:00
Philip Arthur Moore 1c7f560662 Better coding standards for theme header. See #737. 2015-04-29 08:58:07 +07:00
Jasper de Groot 412bdd8b81 Header: Made aria-controls refer to an ID instead of a class 2015-02-27 11:56:43 +01:00
Philip Arthur Moore 8b23932190 Merge remote-tracking branch 'origin/master' into title-theme-support 2014-12-02 20:11:14 +07:00
Philip Arthur Moore 83792b8566 First pass at better title handling for WordPress 4.1+ with proper back compatibility baked in. 2014-11-11 21:41:10 +07:00
Konstantin Obenland d8d89bc681 _s: Improve menu toggle accessibility. 
Makes it a little easier to use the primary navigation with assistive
devices.

See #545.
 2014-11-05 17:37:48 -08:00
Emil Uzelac 78afbb911b Closing DIV comment for site-branding 
Call it OCD, but I feel like we need a closing DIV comment for  ```site-branding``` :)
 2014-11-02 22:40:09 -06:00
Jack Lenox b6ad3b341a Changed lone uppercase H to lower 2014-06-25 00:04:59 +01:00
Philip Arthur Moore 513c17268d Move skip-to-content link 2014-05-16 08:49:04 -05:00
Morten Rand-Hendriksen 4df5790db7 Move skip-to-content link to top to make it first focusable element for keyboard navigation. 2014-05-16 00:43:23 -07:00
Philip Arthur Moore 4b883e2aee a11y improvements on primary navigation menu toggle 2014-04-13 04:02:17 -05:00
Ulrich Pogson 88cdc5222e Remove wpcom actions 2014-02-10 21:19:41 +01:00
obenland 628ec71614 _s: Simplify skip link markup. 2013-10-15 21:07:14 +02:00
David A. Kennedy 3ae7a5e310 Make skip link focusable. 2013-10-01 21:30:53 -04:00
obenland 543cae8bbf Merge branch 'master' of https://github.com/davidakennedy/_s into titles 
Conflicts:
	image.php
	inc/custom-header.php
	searchform.php
 2013-09-25 14:59:11 -07:00
Vinod Dalvi 1a60b6cf85 Corrected wrong comments. 2013-09-14 03:29:53 -07:00
obenland 129c238239 _s: Define initial-scale for a better mobile experience when changing 
device orientation. Fixes: #285.
 2013-09-02 17:33:32 -07:00
David A. Kennedy 22e859857e Fix merge conflict. 2013-08-23 23:58:40 -04:00
David A. Kennedy 889491de53 First round of removing title attributes. 2013-08-23 23:48:19 -04:00
Matias Vad 7145d9fb58 <div id="main"> in comments corrected to the new <main>-element 2013-08-04 20:32:11 +02:00
obenland 810e499b93 _s: Use `<main>` element for main content. 
See: http://www.w3.org/TR/html51/grouping-content.html#the-main-element

Props @BFTrick for initial patch.
Fixes #222.
 2013-07-30 12:12:45 -07:00
michaeldcain d480e820c3 Switch ".navigation-main" back to ".main-navigation" 
Original edit not needed for `[class*="navigation"]` selector. Matches
other class/id navigation naming conventions.
 2013-07-11 16:17:12 -04:00
Shea Bunge a4168fdb74 Leave empty tags open in accordance with the HTML5 spec. Resolves #234 2013-06-05 21:08:55 +10:00
Philip Arthur Moore c186c5ee0b Remove HTML5Shiv from _s. See #215. 2013-05-11 10:00:08 +09:00
Philip Arthur Moore 07c44bbeef Restore site-header class to header element and give site-branding class to title and description wrapper div. See #206. 2013-04-24 15:08:06 +09:00