Commit Graph

160 Commits

Author SHA1 Message Date
Konstantin Obenland 907403fc52 Merge branch 'Entry-Meta-Output' of https://github.com/Automattic/_s into Entry-Meta-Output
Conflicts:
	content-single.php
2014-09-10 18:06:15 -07:00
Konstantin Obenland a14b802e75 _s: Move edit link in template tag for consistency
Every time `_s_entry_footer()` is used, it’s followed by
`edit_post_link()`. Might as well just move that back in the template
tag.
2014-09-10 17:41:19 -07:00
Thomas Guillot 2990f8260c _s: Update to entry meta output. See #537
* Rename function
* Move edit link outside of function
* Remove comments link on single post
2014-09-04 13:28:24 +02:00
Philip Arthur Moore 63d8fcb190 Add escaping to custom header example. Make sure that proper attribute escaping is added into the example that's in the custom header include file. Since we're not including this in header.php, we should at least make sure that the example given is proper and passes WordPress Coding Standards checks. See #552 for context. 2014-08-07 11:07:50 +07:00
Philip Arthur Moore e6fd8e99cf Setup is a noun. Set up is a verb. "Setup the WordPress core custom header feature." is incorrect. "Set up the WordPress core custom header feature." is correct. 2014-08-07 10:36:07 +07:00
Konstantin Obenland 0d87d0bb70 _s: Continue using a default `time` tag.
We only need to change the default markup if published and updated
timestamps are different.
2014-07-30 14:47:16 -05:00
Konstantin Obenland 048057ad68 Merge branch 'updated-hAtom' of https://github.com/slobodan/_s into slobodan-updated-hAtom 2014-07-30 14:35:44 -05:00
Thomas Guillot ba1258f365 _s: Simplify entry meta output
- Fix entry-footer inconsistency between content-*.php files
- Move in a function <code>_s_entry_meta()</code> to avoid duplication

---

At the moment there is an inconsistency between content.php and
content-single.php regarding the .entry-footer output.

In my opinion content.php output is would be better to use because it's
easier to translate and allow more customisation.

Finally by moving it into <code>inc/template-tags.php</code> we are
getting rid of some duplicated code.
2014-06-30 16:43:07 +01:00
Thomas Guillot a78658a393 Revert "_s: Simplify entry meta output"
This reverts commit 9e66401930.
2014-06-30 16:37:12 +01:00
Thomas Guillot 9e66401930 _s: Simplify entry meta output
- Fix entry-footer inconsistency between content-*.php files
- Move in a function <code>_s_entry_meta()</code> to avoid duplication

---

At the moment there is an inconsistency between content.php and
content-single.php regarding the .entry-footer output.

In my opinion content.php output is would be better to use because it's
easier to translate and allow more customisation.

Finally by moving it into <code>inc/template-tags.php</code> we are
getting rid of some duplicated code.
2014-06-30 16:36:36 +01:00
Konstantin Kovshenin 5fffb5e911 Add a non-breaking space to _s_post_nav().
Sometimes the title length of a previous or next post would cause
the arrow (larr/rarr) in the link to be wrapped to the next line.
Adding a non-breaking space between the title and the arrow will stick
it to the last word in the title.
2014-06-26 11:50:14 +04:00
Slobodan Manic 00570514d4 Adds .updated class to .entry-date when needed 2014-06-15 13:20:06 +02:00
Konstantin Obenland e24e53e024 Merge pull request #453 from grappler/translation-strings
_s: Avoid html tags in "Posted on" string.
2014-06-02 08:28:46 -07:00
Lance Willett 86a0cd531d Pinking shears (remove trailing spaces) in two files. 2014-05-18 13:09:20 -07:00
Piotr Soluch 54d58d548b fix for a page title error
The same error as https://core.trac.wordpress.org/ticket/16468
2014-05-04 15:34:50 +02:00
Ulrich Pogson fc9910cf96 Split strings into variables 2014-05-01 23:27:08 +02:00
Konstantin Obenland 796d8e8c7e _s: Update function return values.
Adds missing documentation for `_s_categorized_blog()` and removes void
statements, in accordance with WordPress documentation guidelines.

See
http://make.wordpress.org/core/handbook/inline-documentation-standards/p
hp-documentation-standards/#phpdoc-tags
2014-03-30 12:15:29 -07:00
Konstantin Obenland 7d24be9c97 _s: Resolve merge conflicts from master branch.
This also retains `$all_the_cool_cats` for some flavor. It has been
around since the initial fork of Toolbox and makes people smile:
https://twitter.com/TheFrosty/status/449581069231071232
2014-03-30 12:00:47 -07:00
Ulrich Pogson 5e62b8dc9e Remove html from string 2014-03-24 00:08:21 +01:00
Konstantin Kovshenin 87ca7b66ad Prefix transient. 2014-03-18 18:43:00 +04:00
Philip Arthur Moore 16e0ca504d Remove redundant package DocBlock within custom header file 2014-03-07 06:41:14 -06:00
Konstantin Obenland 09720890a7 _s: Retrieve blog name with the correct context.
Passing `'display'` as the second argument will make the blog name filterable and runs it through `wp_texturize()`.

See https://core.trac.wordpress.org/ticket/26811
2014-01-24 09:54:05 -08:00
obenland 0f2db471a7 Merge branch 'pr/366' 2014-01-20 20:34:51 -08:00
obenland e55cb8a038 _s: Make it easier to target post navigation links.
Removed in 3f4effb when we split the template tag, this will restore
parity with `_s_paging_nav()`.

Props @gatespace for initial patch. Fixes #371.
2014-01-01 17:30:24 -08:00
Ulrich Pogson cb52da6f23 Remove _s_comment 2013-12-22 21:33:16 +01:00
obenland a156f2cbab _s: Simplify author template.
Set up author data for the author template immediately, rather than
waiting for the first the_post() call.
This removes the need to call the_post() and rewind_posts() in an
author template to print information about the author.

Fixes #346.
2013-12-21 00:00:25 -08:00
obenland 3f4effb5f0 _s: Split navigation template tag in context-specific tags. 2013-11-24 18:28:15 +00:00
obenland caff68529f _s: Update wpcom compat file to wrap contents in a hooked callback. 2013-11-24 18:24:11 +00:00
Philip Arthur Moore 6264437ff9 Add braces around single-line conditionals. See http://make.wordpress.org/core/2013/11/13/proposed-coding-standards-change-always-require-braces/. 2013-11-14 19:49:50 +07:00
obenland 7c1067eee3 _s: Remove `image.php` and related code. Image attachments will be
displayed by `single.php`. See
http://codex.wordpress.org/Template_Hierarchy
2013-11-07 15:59:02 -04:00
obenland 6f63a0b39a _s: Adhere to updated WordPress core code formatting.
* Update PHPDoc.
* Add periods to the end of comment sentences.
* Limit line length to 80 chars.
* Use C++-style PHP comments only for function and file documentation.
2013-11-07 15:41:41 -04:00
Greg Johnson 50a539cd81 Wordpress custom-header functionality seems to require default-text-color to be a six-digit hex code. using less than six digits here causes Appearance > Header to hang on step 3 2013-10-08 14:59:35 -05:00
obenland 543cae8bbf Merge branch 'master' of https://github.com/davidakennedy/_s into titles
Conflicts:
	image.php
	inc/custom-header.php
	searchform.php
2013-09-25 14:59:11 -07:00
obenland 083d8a580d _s: Simplify header image markup in admin appearance page. 2013-09-25 14:55:08 -07:00
obenland f572468099 _s: Simplify header image example markup.
`get_header_image()` will return the boolean false or an empty string if
there is no header image. Both will be evaluated as false by the if
statement.

Related: http://core.trac.wordpress.org/ticket/25156
2013-09-23 14:39:15 -07:00
David A. Kennedy 48ac0da4e1 Second round of removing title attributes. 2013-08-24 02:06:06 -04:00
Thomas Guillot 966d649f3c _s: Use comment_reply_link arguments to wrap reply link
Avoid empty div if no reply link
2013-08-19 10:18:10 +01:00
obenland 810e499b93 _s: Use `<main>` element for main content.
See: http://www.w3.org/TR/html51/grouping-content.html#the-main-element

Props @BFTrick for initial patch.
Fixes #222.
2013-07-30 12:12:45 -07:00
michaeldcain 31331b4b64 Switch "navigation-" back to "-navigation"
Original edit not needed for `[class*="navigation"]` selector. Matches
other class/id navigation naming conventions.
2013-07-11 16:42:45 -04:00
obenland 261acc6099 Merge branch 'open-empty-tags' of https://github.com/bungeshea/_s into
bungeshea-open-empty-tags

Conflicts:
	searchform.php
2013-07-11 11:45:38 -07:00
obenland d279972455 _s: Simplify 'Posted on' string for easier translation and add a HTML
wrapper for easier CSS manipulation. Props @grappler. Fixes #253.
2013-07-11 08:42:01 -07:00
Ulrich Pogson 36ad7cb751 Improve "Posted on" translation string 2013-07-10 22:23:46 +02:00
obenland 77b0fa51ae _s: Simplifies the attached image template tag by only querying for ids. 2013-07-02 17:41:51 -04:00
obenland 584ed2a6f2 _s: Remove back compat for custom header/background. Fixes #244. 2013-06-27 07:14:12 -07:00
obenland 39d8f7ad61 _s: Include "entry updated" as part of the hAtom. Props @michiecat. See
#131, fixes #170.
2013-06-27 06:54:02 -07:00
Shea Bunge a4168fdb74 Leave empty tags open in accordance with the HTML5 spec. Resolves #234 2013-06-05 21:08:55 +10:00
obenland 6c83cfb5cc _s: Simplify image.php:
* Extracts logic in a custom template tag.
* Reduces switching in and out of php in `.entry-meta`.
* Minor code styling changes.

Fixes #233.
2013-06-04 13:13:15 -07:00
obenland f0ed253d5b Merge branch 'custom_header_fix' of https://github.com/iamtakashi/_s
into iamtakashi-custom_header_fix

Conflicts:
	inc/custom-header.php
2013-05-28 09:31:59 -07:00
obenland 95c3bd62cf _s: Update comment markup to make it forward compatible with html5
comments in 3.6. As a result the custom callback can be safely removed
in the future. Also closes #220.
2013-05-25 12:33:20 +02:00
obenland c7bf07061d _s: Let's not limit the setup function to IS. 2013-05-20 13:02:30 +02:00
obenland c1960ec122 _s: Cache header text color value; 2013-05-20 13:01:22 +02:00
Takashi Irie f367fefd72 Fix unlinked site title in the Customizer 2013-05-08 12:27:48 +01:00
Takashi Irie 8ceefdcdeb Fixes the broken display header text option in the Customizer. 2013-04-22 16:47:14 +01:00
Takashi Irie c780bc0559 Add trailing commas to the last elements of arrays 2013-04-20 16:45:36 +01:00
Takashi Irie 7be757759c Minor code style clean-up 2013-04-20 01:26:43 +01:00
michiecat a47b1523dd Updates to the _s_admin_header_image() callback
Adding a ".displaying-header-text" class to the header h1 and to the site description div inside _s_admin_header_image(). This allows the "display text with your image" toggle button to work in the admin preview under Appearance > Header.
2013-04-17 16:46:57 -07:00
obenland 6056c1ed66 _s: Re-introduce `nav-` prefix for previous/next links.
This way we can select both links with `[class*="nav-"]`.
2013-04-05 09:34:08 -07:00
Philip Arthur Moore fe19f5433b Ditch all @since DocBlocks from theme. 2013-03-18 14:53:23 -05:00
obenland 1ba2f62752 _s: Use .screen-reader-text rather than .assistive-text.
With 3.6 introducing many HTML5 improvements the need for custom
searchform and comment templates will vanish. To cope with core's
.screen-reader-text class, let's make the switch early.

Commit also adds core's focus styles for screen reader texts, so they
can actually be used.
2013-03-13 15:39:05 -07:00
obenland c4f2aa32ce _s: Formatting changes:
- Reduce element comments to either the element id or the first element
class.
- Tabs > Spaces.
- Improve adherence to formatting guidelines.
2013-03-04 16:41:38 -08:00
obenland c7f2b7a1ee _s: Enable live preview for Header Text Color in Customizer. Change also
removes an !important declaration in Custom Header CSS rules.
2013-03-04 16:13:56 -08:00
obenland 9fe1b0d8a8 _s: Aggregate translation strings and make comment edit links easier to
style.
2013-03-04 15:18:11 -08:00
Philip Arthur Moore dcd62e323c Manually revert all changes made after debefa8b98 so that the code proposed in #131 gets a proper review. 2013-02-28 01:12:59 -06:00
Philip Arthur Moore c8c60b3904 Let us try this one more time. Revert all changes made to _s up until commit debefa merge until #131 has had a proper code review. 2013-02-28 01:04:34 -06:00
obenland fa3d86936a _s: Simplify and unify navigation classes throughout Underscores.
For more information about the philosophy behind the new approach,
see http://24ways.org/2012/a-harder-working-class/
2013-02-27 14:47:03 -08:00
Philip Arthur Moore 50cee30497 Remove colon from @package DocBlock 2013-02-25 01:15:14 -06:00
Philip Arthur Moore c06b9fe571 _s: Minor adjustments to Infinite Scroll's implementation. 2013-02-03 02:12:42 -05:00
Philip Arthur Moore 16906d44c5 _s: Add basic Infinite Scroll support. Fixes #107. Fixes #105. Props @ethitter. 2013-02-03 02:03:40 -05:00
Michael Fields b7563b8a99 Escape dynamic value $nav_id when used as an attribute and html comment. Fixes #146 props @ounziw 2013-02-02 05:03:08 -10:00
Michael Fields 10c87aeefc Merge pull request #93 from kwight/patch-2
Remove invalid pubdate value from time elements in template-tags.php. See #93
2012-12-28 17:24:21 -08:00
Konstantin Obenland de29437d5f Merge pull request #115 from obenland/master
Remove generic Theme Options page in favor of the Customizer.

Having a set of sample options encourages their use — we shouldn’t do this, it’s simple enough to code options up whenever we need them.

Customizer support is activated by default and comes with a working sample implementation. For more information about the Customizer and how to leverage it's API please see http://ottopress.com/tag/customizer/
2012-12-28 09:10:49 -08:00
Konstantin Obenland faf979bb4d Add a space to let it shine. 2012-12-28 08:38:18 -08:00
Michael Fields b1c1073f91 get_the_author() should not be escaped when used as text. Escaping should only occur when used in an attribute. 2012-12-19 17:31:04 -08:00
obenland 5bfc37093b Follow through with 'customizer' naming convention. 2012-11-30 09:26:37 -08:00
obenland c7d3e37fc6 s/theme-customizer/customizer 2012-11-30 09:13:05 -08:00
obenland 181c363800 Theme Customizer > Theme Options
* Removes sample theme options
* Adds Theme Customizer enhancement (actually working!)

Goal: Emphasize the use of the Customizer versus out of style Theme
Options.
2012-11-28 14:51:38 -08:00
Konstantin Obenland ba4af1262a Merge pull request #79 from kovshenin/patch-11
* Introduces a filter for wp_title instead of hard-coding things in header.php
* Renames inc/tweaks.php to inc/extras.php
* Includes inc/extras.php by default in functions.php

See #12, #13, #33
2012-11-28 09:24:23 -08:00
Cor van Noorloos 064daacda6 Space before colon
Minor formatting
2012-11-03 23:02:36 +01:00
Kirk Wight ca76e89d0e Removed dangling pubdate attributes
The <time> attribute "pubdate" appears to no longer be part of the HTML5 spec, so remove them (they weren't being used anyways)
2012-10-11 18:02:14 -03:00
Konstantin Kovshenin 3517c7a36b Use a filter for wp_title instead of hard-coding things in header.php 2012-09-14 20:49:06 +04:00
Konstantin Kovshenin b01b14a467 Renaming inc/tweaks.php to inc/extras.php and including by default in functions.php 2012-09-14 20:43:20 +04:00
Ian Stewart 46f6a664a9 Merge pull request #38 from kovshenin/patch-6
Don't print markup in _s_content_nav() when it is not needed. Fixes #28. props @kovshenin
2012-09-13 17:28:40 -07:00
Michael Fields c041ea2b48 Add todo tags to the DocBlocks of functions that contain backward compatibility with previous versions of WordPress stating when back compat should be removed. _s supports the current stable version of WordPress as well as two prior major releases. 2012-08-27 14:25:10 -07:00
Konstantin Kovshenin 6465b5ae9f Don't print markup in _s_content_nav() when it is not needed. Fixes #28.
Added checks for previous (or parent) and next post in _s_content_nav() before printing any navigation-specific markup. Same approach for when using the function to print pagination links on a posts set for less than two pages.
2012-08-15 17:05:42 +04:00
Lance Willett 7a4aa04261 Merge pull request #16 from obenland/patch-1
Use get_header_textcolor() for forward compatibility, props obenland.
2012-08-06 16:21:19 -07:00
Lance Willett 098bacfe24 Merge pull request #26 from SimpliZine/patch-1
Add missing attribute assignment equals sign, props SimpliZine.
2012-08-06 16:19:17 -07:00
Lance Willett 587d0c2da1 Merge pull request #22 from jasongottschalk/incorrect-value-select-options-array
Fixed incorrect value in select options array. Props jasongottschalk.
2012-08-06 16:12:08 -07:00
SimpliZine d56ae9234d Line #172: Added missing '=' in '<label for="sample-checkbox">'. 2012-07-02 17:38:46 +02:00
Jason Gottschalk 5f44856a45 Fixed incorrect value in select options array. 2012-06-06 14:01:50 -03:00
Michael Fields 6a0c5d2d78 _s: WordPress coding standards. Cleanup whitespace. props @corvannoorloos
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9648 d957f892-c61d-0410-b221-f235e6eecf30
2012-05-26 23:43:53 +00:00
Michael Fields c4a02323c6 _s: Remove notice in Theme Options screen in WordPress 3.4. props @corvannoorloos
* Replace deprecated get_current_theme() with wp_get_theme()
 * Providing back-compat with prior versions of WordPress.


git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9647 d957f892-c61d-0410-b221-f235e6eecf30
2012-05-26 23:39:53 +00:00
Michael Fields 966679f25b _s: Update Custom Header Code. fixes #1212
* Use WordPress 3.4's registration method providing backward compatibility for previous versions.
* Implement shiv for get_custom_header(). props @obenland
* Allow all custom header args to be filtered via child theme/plugin.
* Update example code in DocBlock to use get_custom_header().



git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9484 d957f892-c61d-0410-b221-f235e6eecf30
2012-04-24 14:38:15 -05:00
Michael Fields 2cd6317a4e _s: Only set theme options if necessary. fixes #1151
* Remove call to add_option() during admin_init.
* Rework _s_get_theme_options() so that it merges default values into the stored settings.
* Rework _s_theme_options_validate() to only return recognized values if they are present in the $_POST request - only store what is absolutely necessary.
* Updated the docs in a few places.
* Note: _s now requires PHP5. see L161 array_intersect_key().


git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9483 d957f892-c61d-0410-b221-f235e6eecf30
2012-04-24 14:38:15 -05:00
Michael Fields f705f1c5f9 _s: Update Custom Header Code. fixes #1212
* Use WordPress 3.4's registration method providing backward compatibility for previous versions.
* Implement shiv for get_custom_header(). props @obenland
* Allow all custom header args to be filtered via child theme/plugin.
* Update example code in DocBlock to use get_custom_header().



git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9484 d957f892-c61d-0410-b221-f235e6eecf30
2012-04-23 22:52:48 +00:00
Michael Fields c30057cd92 _s: Only set theme options if necessary. fixes #1151
* Remove call to add_option() during admin_init.
* Rework _s_get_theme_options() so that it merges default values into the stored settings.
* Rework _s_theme_options_validate() to only return recognized values if they are present in the $_POST request - only store what is absolutely necessary.
* Updated the docs in a few places.
* Note: _s now requires PHP5. see L161 array_intersect_key().


git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9483 d957f892-c61d-0410-b221-f235e6eecf30
2012-04-23 21:35:30 +00:00
obenland 036f80fd9a Use get_header_textcolor() for forward compatibility 2012-04-05 22:56:13 +03:00
Ian Stewart fc97fbd34d Merge branch 'master' of github.com:Automattic/_s
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9022 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-29 15:43:18 +00:00
Giuseppe Capizzi 1b8246a7ee Update inc/tweaks.php 2012-02-25 16:22:30 +01:00
Michael Fields 6817af282c _s: needs to be declared globally.
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@8964 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-20 23:54:21 -07:00
Michael Fields 1d680edf9c _s: needs to be declared globally.
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@8964 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-17 22:34:53 +00:00