rayelliott
/
_s
Archived
forked from mirror/_s
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
778 Commits 2 Branches 0 Tags 32 MiB
Commit Graph

24 Commits

Author SHA1 Message Date
Philip Arthur Moore 2540fb7b7f Better WordPress Coding standards. 
This minor commit kicks off code improvements to _s so that it’s fully in line with WordPress Coding Standards rules.
 2014-11-01 07:09:58 +07:00
Philip Arthur Moore 63d8fcb190 Add escaping to custom header example. Make sure that proper attribute escaping is added into the example that's in the custom header include file. Since we're not including this in header.php, we should at least make sure that the example given is proper and passes WordPress Coding Standards checks. See #552 for context. 2014-08-07 11:07:50 +07:00
Philip Arthur Moore e6fd8e99cf Setup is a noun. Set up is a verb. "Setup the WordPress core custom header feature." is incorrect. "Set up the WordPress core custom header feature." is correct. 2014-08-07 10:36:07 +07:00
Philip Arthur Moore 16e0ca504d Remove redundant package DocBlock within custom header file 2014-03-07 06:41:14 -06:00
Philip Arthur Moore 6264437ff9 Add braces around single-line conditionals. See http://make.wordpress.org/core/2013/11/13/proposed-coding-standards-change-always-require-braces/. 2013-11-14 19:49:50 +07:00
Greg Johnson 50a539cd81 Wordpress custom-header functionality seems to require default-text-color to be a six-digit hex code. using less than six digits here causes Appearance > Header to hang on step 3 2013-10-08 14:59:35 -05:00
obenland 543cae8bbf Merge branch 'master' of https://github.com/davidakennedy/_s into titles 
Conflicts:
	image.php
	inc/custom-header.php
	searchform.php
 2013-09-25 14:59:11 -07:00
obenland 083d8a580d _s: Simplify header image markup in admin appearance page. 2013-09-25 14:55:08 -07:00
obenland f572468099 _s: Simplify header image example markup. 
`get_header_image()` will return the boolean false or an empty string if
there is no header image. Both will be evaluated as false by the if
statement.

Related: http://core.trac.wordpress.org/ticket/25156
 2013-09-23 14:39:15 -07:00
David A. Kennedy 48ac0da4e1 Second round of removing title attributes. 2013-08-24 02:06:06 -04:00
obenland 261acc6099 Merge branch 'open-empty-tags' of https://github.com/bungeshea/_s into 
bungeshea-open-empty-tags

Conflicts:
	searchform.php
 2013-07-11 11:45:38 -07:00
obenland 584ed2a6f2 _s: Remove back compat for custom header/background. Fixes #244. 2013-06-27 07:14:12 -07:00
Shea Bunge a4168fdb74 Leave empty tags open in accordance with the HTML5 spec. Resolves #234 2013-06-05 21:08:55 +10:00
obenland f0ed253d5b Merge branch 'custom_header_fix' of https://github.com/iamtakashi/_s 
into iamtakashi-custom_header_fix

Conflicts:
	inc/custom-header.php
 2013-05-28 09:31:59 -07:00
obenland c1960ec122 _s: Cache header text color value; 2013-05-20 13:01:22 +02:00
Takashi Irie 8ceefdcdeb Fixes the broken display header text option in the Customizer. 2013-04-22 16:47:14 +01:00
michiecat a47b1523dd Updates to the _s_admin_header_image() callback 
Adding a ".displaying-header-text" class to the header h1 and to the site description div inside _s_admin_header_image(). This allows the "display text with your image" toggle button to work in the admin preview under Appearance > Header.
 2013-04-17 16:46:57 -07:00
Philip Arthur Moore fe19f5433b Ditch all @since DocBlocks from theme. 2013-03-18 14:53:23 -05:00
obenland c7f2b7a1ee _s: Enable live preview for Header Text Color in Customizer. Change also 
removes an !important declaration in Custom Header CSS rules.
 2013-03-04 16:13:56 -08:00
Michael Fields c041ea2b48 Add todo tags to the DocBlocks of functions that contain backward compatibility with previous versions of WordPress stating when back compat should be removed. _s supports the current stable version of WordPress as well as two prior major releases. 2012-08-27 14:25:10 -07:00
Lance Willett 7a4aa04261 Merge pull request #16 from obenland/patch-1 
Use get_header_textcolor() for forward compatibility, props obenland.
 2012-08-06 16:21:19 -07:00
Michael Fields f705f1c5f9 _s: Update Custom Header Code. fixes #1212 
* Use WordPress 3.4's registration method providing backward compatibility for previous versions.
* Implement shiv for get_custom_header(). props @obenland
* Allow all custom header args to be filtered via child theme/plugin.
* Update example code in DocBlock to use get_custom_header().



git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9484 d957f892-c61d-0410-b221-f235e6eecf30
 2012-04-23 22:52:48 +00:00
obenland 036f80fd9a Use get_header_textcolor() for forward compatibility 2012-04-05 22:56:13 +03:00
Ian Stewart 761e93ad32 _s: adding a sample custom header, commented out 2012-01-31 20:18:40 +00:00