Commit Graph

81 Commits

Author SHA1 Message Date
obenland 7c1067eee3 _s: Remove `image.php` and related code. Image attachments will be
displayed by `single.php`. See
http://codex.wordpress.org/Template_Hierarchy
2013-11-07 15:59:02 -04:00
obenland 6f63a0b39a _s: Adhere to updated WordPress core code formatting.
* Update PHPDoc.
* Add periods to the end of comment sentences.
* Limit line length to 80 chars.
* Use C++-style PHP comments only for function and file documentation.
2013-11-07 15:41:41 -04:00
Greg Johnson 50a539cd81 Wordpress custom-header functionality seems to require default-text-color to be a six-digit hex code. using less than six digits here causes Appearance > Header to hang on step 3 2013-10-08 14:59:35 -05:00
obenland 543cae8bbf Merge branch 'master' of https://github.com/davidakennedy/_s into titles
Conflicts:
	image.php
	inc/custom-header.php
	searchform.php
2013-09-25 14:59:11 -07:00
obenland 083d8a580d _s: Simplify header image markup in admin appearance page. 2013-09-25 14:55:08 -07:00
obenland f572468099 _s: Simplify header image example markup.
`get_header_image()` will return the boolean false or an empty string if
there is no header image. Both will be evaluated as false by the if
statement.

Related: http://core.trac.wordpress.org/ticket/25156
2013-09-23 14:39:15 -07:00
David A. Kennedy 48ac0da4e1 Second round of removing title attributes. 2013-08-24 02:06:06 -04:00
Thomas Guillot 966d649f3c _s: Use comment_reply_link arguments to wrap reply link
Avoid empty div if no reply link
2013-08-19 10:18:10 +01:00
obenland 810e499b93 _s: Use `<main>` element for main content.
See: http://www.w3.org/TR/html51/grouping-content.html#the-main-element

Props @BFTrick for initial patch.
Fixes #222.
2013-07-30 12:12:45 -07:00
michaeldcain 31331b4b64 Switch "navigation-" back to "-navigation"
Original edit not needed for `[class*="navigation"]` selector. Matches
other class/id navigation naming conventions.
2013-07-11 16:42:45 -04:00
obenland 261acc6099 Merge branch 'open-empty-tags' of https://github.com/bungeshea/_s into
bungeshea-open-empty-tags

Conflicts:
	searchform.php
2013-07-11 11:45:38 -07:00
obenland d279972455 _s: Simplify 'Posted on' string for easier translation and add a HTML
wrapper for easier CSS manipulation. Props @grappler. Fixes #253.
2013-07-11 08:42:01 -07:00
Ulrich Pogson 36ad7cb751 Improve "Posted on" translation string 2013-07-10 22:23:46 +02:00
obenland 77b0fa51ae _s: Simplifies the attached image template tag by only querying for ids. 2013-07-02 17:41:51 -04:00
obenland 584ed2a6f2 _s: Remove back compat for custom header/background. Fixes #244. 2013-06-27 07:14:12 -07:00
obenland 39d8f7ad61 _s: Include "entry updated" as part of the hAtom. Props @michiecat. See
#131, fixes #170.
2013-06-27 06:54:02 -07:00
Shea Bunge a4168fdb74 Leave empty tags open in accordance with the HTML5 spec. Resolves #234 2013-06-05 21:08:55 +10:00
obenland 6c83cfb5cc _s: Simplify image.php:
* Extracts logic in a custom template tag.
* Reduces switching in and out of php in `.entry-meta`.
* Minor code styling changes.

Fixes #233.
2013-06-04 13:13:15 -07:00
obenland f0ed253d5b Merge branch 'custom_header_fix' of https://github.com/iamtakashi/_s
into iamtakashi-custom_header_fix

Conflicts:
	inc/custom-header.php
2013-05-28 09:31:59 -07:00
obenland 95c3bd62cf _s: Update comment markup to make it forward compatible with html5
comments in 3.6. As a result the custom callback can be safely removed
in the future. Also closes #220.
2013-05-25 12:33:20 +02:00
obenland c7bf07061d _s: Let's not limit the setup function to IS. 2013-05-20 13:02:30 +02:00
obenland c1960ec122 _s: Cache header text color value; 2013-05-20 13:01:22 +02:00
Takashi Irie f367fefd72 Fix unlinked site title in the Customizer 2013-05-08 12:27:48 +01:00
Takashi Irie 8ceefdcdeb Fixes the broken display header text option in the Customizer. 2013-04-22 16:47:14 +01:00
Takashi Irie c780bc0559 Add trailing commas to the last elements of arrays 2013-04-20 16:45:36 +01:00
Takashi Irie 7be757759c Minor code style clean-up 2013-04-20 01:26:43 +01:00
michiecat a47b1523dd Updates to the _s_admin_header_image() callback
Adding a ".displaying-header-text" class to the header h1 and to the site description div inside _s_admin_header_image(). This allows the "display text with your image" toggle button to work in the admin preview under Appearance > Header.
2013-04-17 16:46:57 -07:00
obenland 6056c1ed66 _s: Re-introduce `nav-` prefix for previous/next links.
This way we can select both links with `[class*="nav-"]`.
2013-04-05 09:34:08 -07:00
Philip Arthur Moore fe19f5433b Ditch all @since DocBlocks from theme. 2013-03-18 14:53:23 -05:00
obenland 1ba2f62752 _s: Use .screen-reader-text rather than .assistive-text.
With 3.6 introducing many HTML5 improvements the need for custom
searchform and comment templates will vanish. To cope with core's
.screen-reader-text class, let's make the switch early.

Commit also adds core's focus styles for screen reader texts, so they
can actually be used.
2013-03-13 15:39:05 -07:00
obenland c4f2aa32ce _s: Formatting changes:
- Reduce element comments to either the element id or the first element
class.
- Tabs > Spaces.
- Improve adherence to formatting guidelines.
2013-03-04 16:41:38 -08:00
obenland c7f2b7a1ee _s: Enable live preview for Header Text Color in Customizer. Change also
removes an !important declaration in Custom Header CSS rules.
2013-03-04 16:13:56 -08:00
obenland 9fe1b0d8a8 _s: Aggregate translation strings and make comment edit links easier to
style.
2013-03-04 15:18:11 -08:00
Philip Arthur Moore dcd62e323c Manually revert all changes made after debefa8b98 so that the code proposed in #131 gets a proper review. 2013-02-28 01:12:59 -06:00
Philip Arthur Moore c8c60b3904 Let us try this one more time. Revert all changes made to _s up until commit debefa merge until #131 has had a proper code review. 2013-02-28 01:04:34 -06:00
obenland fa3d86936a _s: Simplify and unify navigation classes throughout Underscores.
For more information about the philosophy behind the new approach,
see http://24ways.org/2012/a-harder-working-class/
2013-02-27 14:47:03 -08:00
Philip Arthur Moore 50cee30497 Remove colon from @package DocBlock 2013-02-25 01:15:14 -06:00
Philip Arthur Moore c06b9fe571 _s: Minor adjustments to Infinite Scroll's implementation. 2013-02-03 02:12:42 -05:00
Philip Arthur Moore 16906d44c5 _s: Add basic Infinite Scroll support. Fixes #107. Fixes #105. Props @ethitter. 2013-02-03 02:03:40 -05:00
Michael Fields b7563b8a99 Escape dynamic value $nav_id when used as an attribute and html comment. Fixes #146 props @ounziw 2013-02-02 05:03:08 -10:00
Michael Fields 10c87aeefc Merge pull request #93 from kwight/patch-2
Remove invalid pubdate value from time elements in template-tags.php. See #93
2012-12-28 17:24:21 -08:00
Konstantin Obenland de29437d5f Merge pull request #115 from obenland/master
Remove generic Theme Options page in favor of the Customizer.

Having a set of sample options encourages their use — we shouldn’t do this, it’s simple enough to code options up whenever we need them.

Customizer support is activated by default and comes with a working sample implementation. For more information about the Customizer and how to leverage it's API please see http://ottopress.com/tag/customizer/
2012-12-28 09:10:49 -08:00
Konstantin Obenland faf979bb4d Add a space to let it shine. 2012-12-28 08:38:18 -08:00
Michael Fields b1c1073f91 get_the_author() should not be escaped when used as text. Escaping should only occur when used in an attribute. 2012-12-19 17:31:04 -08:00
obenland 5bfc37093b Follow through with 'customizer' naming convention. 2012-11-30 09:26:37 -08:00
obenland c7d3e37fc6 s/theme-customizer/customizer 2012-11-30 09:13:05 -08:00
obenland 181c363800 Theme Customizer > Theme Options
* Removes sample theme options
* Adds Theme Customizer enhancement (actually working!)

Goal: Emphasize the use of the Customizer versus out of style Theme
Options.
2012-11-28 14:51:38 -08:00
Konstantin Obenland ba4af1262a Merge pull request #79 from kovshenin/patch-11
* Introduces a filter for wp_title instead of hard-coding things in header.php
* Renames inc/tweaks.php to inc/extras.php
* Includes inc/extras.php by default in functions.php

See #12, #13, #33
2012-11-28 09:24:23 -08:00
Cor van Noorloos 064daacda6 Space before colon
Minor formatting
2012-11-03 23:02:36 +01:00
Kirk Wight ca76e89d0e Removed dangling pubdate attributes
The <time> attribute "pubdate" appears to no longer be part of the HTML5 spec, so remove them (they weren't being used anyways)
2012-10-11 18:02:14 -03:00