jrfnl
ec877e48c3
CS: fix up embedded PHP inconsistencies introduced in the mean time.
2018-02-27 14:34:54 +01:00
Ulrich Pogson
b26b6ebfa4
Move PHP tags on it’s own line & correct indention
...
This fixes a few of the errors from the news sniffs in WPCS 0.12.0 and also standardizes the indention between the PHP and HTML
2018-02-27 14:34:53 +01:00
Truong Giang
9fcb8dab40
Correct code indentation
2017-07-27 00:37:56 +07:00
Tammie Lister
3c7fe6f91e
Merge pull request #1051 from samikeijonen/issue/1041
...
Remove link around header image: props @samikeijonen
2016-12-23 14:29:25 +00:00
Tammie Lister
59fc136158
Merge pull request #991 from grappler/custom-header
...
Remove deprecated constant HEADER_TEXTCOLOR : props @grappler
2016-12-23 14:22:52 +00:00
Sami Keijonen
2370c59676
Use the_header_image_tag() function.
2016-11-27 12:57:24 +02:00
Sami Keijonen
31a9e90437
Remove link around header image.
2016-11-26 19:26:12 +02:00
Bappi
394e02a5d5
Remove period from file header
2016-09-27 12:03:40 +06:00
Ulrich Pogson
71771d92d7
Remove deprecated constant HEADER_TEXTCOLOR
2016-07-24 21:22:27 +02:00
Konstantin Obenland
cdd101e16c
Remove comments not ending in a period.
...
Helps avoid Travis CI errors for wrongly formatted comments. Most of
these end of function comments (if not all) are useless anyway.
Props @WPAddiction for reporting.
Fixes #891 .
2015-12-14 18:05:14 -08:00
sarah
ead318fd20
Remove custom header admin callbacks.
...
These haven't been needed since 4.1, when the Header page under
Appearance was deprecated and linked to the Customizer instead.
2015-12-03 20:29:32 +00:00
patryk
4433c1f0b7
Last 3 non-https WordPress URLs updated and custom header link updated too - issue #734
2015-12-01 21:06:47 +01:00
patryk
be085c6d0c
Last 3 non-https WordPress URLs updated - issue #734
2015-12-01 19:34:53 +01:00
sarah
cdd7f9b333
Simplify check for hidden header text.
2015-09-17 16:58:03 +01:00
Grant Palin
af0a4749be
Update comparisons to resolve the strict comparison warnings. See https://github.com/Automattic/_s/issues/784
2015-08-07 09:59:26 -07:00
PJ
de9c9888b7
Updated documentation in comments at the top of files.
...
I tried to standardize and expand the documentation and links to
codex.wordpress.org in the comments at the top of most files.
2015-07-12 12:38:18 -04:00
Fränk Klein
175524922c
Fix Codesniffer errors.
2015-05-27 22:19:14 +02:00
Fränk Klein
2aef92e5a3
Fix remaining PHPCS errors:
...
* Add ignoring in template-tags.php and comments.php.
* Escape header text color in custom-header.php.
2015-05-11 09:18:36 +02:00
Philip Arthur Moore
2540fb7b7f
Better WordPress Coding standards.
...
This minor commit kicks off code improvements to _s so that it’s fully in line with WordPress Coding Standards rules.
2014-11-01 07:09:58 +07:00
Philip Arthur Moore
63d8fcb190
Add escaping to custom header example. Make sure that proper attribute escaping is added into the example that's in the custom header include file. Since we're not including this in header.php, we should at least make sure that the example given is proper and passes WordPress Coding Standards checks. See #552 for context.
2014-08-07 11:07:50 +07:00
Philip Arthur Moore
e6fd8e99cf
Setup is a noun. Set up is a verb. "Setup the WordPress core custom header feature." is incorrect. "Set up the WordPress core custom header feature." is correct.
2014-08-07 10:36:07 +07:00
Philip Arthur Moore
16e0ca504d
Remove redundant package DocBlock within custom header file
2014-03-07 06:41:14 -06:00
Philip Arthur Moore
6264437ff9
Add braces around single-line conditionals. See http://make.wordpress.org/core/2013/11/13/proposed-coding-standards-change-always-require-braces/ .
2013-11-14 19:49:50 +07:00
Greg Johnson
50a539cd81
Wordpress custom-header functionality seems to require default-text-color to be a six-digit hex code. using less than six digits here causes Appearance > Header to hang on step 3
2013-10-08 14:59:35 -05:00
obenland
543cae8bbf
Merge branch 'master' of https://github.com/davidakennedy/_s into titles
...
Conflicts:
image.php
inc/custom-header.php
searchform.php
2013-09-25 14:59:11 -07:00
obenland
083d8a580d
_s: Simplify header image markup in admin appearance page.
2013-09-25 14:55:08 -07:00
obenland
f572468099
_s: Simplify header image example markup.
...
`get_header_image()` will return the boolean false or an empty string if
there is no header image. Both will be evaluated as false by the if
statement.
Related: http://core.trac.wordpress.org/ticket/25156
2013-09-23 14:39:15 -07:00
David A. Kennedy
48ac0da4e1
Second round of removing title attributes.
2013-08-24 02:06:06 -04:00
obenland
261acc6099
Merge branch 'open-empty-tags' of https://github.com/bungeshea/_s into
...
bungeshea-open-empty-tags
Conflicts:
searchform.php
2013-07-11 11:45:38 -07:00
obenland
584ed2a6f2
_s: Remove back compat for custom header/background. Fixes #244 .
2013-06-27 07:14:12 -07:00
Shea Bunge
a4168fdb74
Leave empty tags open in accordance with the HTML5 spec. Resolves #234
2013-06-05 21:08:55 +10:00
obenland
f0ed253d5b
Merge branch 'custom_header_fix' of https://github.com/iamtakashi/_s
...
into iamtakashi-custom_header_fix
Conflicts:
inc/custom-header.php
2013-05-28 09:31:59 -07:00
obenland
c1960ec122
_s: Cache header text color value;
2013-05-20 13:01:22 +02:00
Takashi Irie
8ceefdcdeb
Fixes the broken display header text option in the Customizer.
2013-04-22 16:47:14 +01:00
michiecat
a47b1523dd
Updates to the _s_admin_header_image() callback
...
Adding a ".displaying-header-text" class to the header h1 and to the site description div inside _s_admin_header_image(). This allows the "display text with your image" toggle button to work in the admin preview under Appearance > Header.
2013-04-17 16:46:57 -07:00
Philip Arthur Moore
fe19f5433b
Ditch all @since DocBlocks from theme.
2013-03-18 14:53:23 -05:00
obenland
c7f2b7a1ee
_s: Enable live preview for Header Text Color in Customizer. Change also
...
removes an !important declaration in Custom Header CSS rules.
2013-03-04 16:13:56 -08:00
Michael Fields
c041ea2b48
Add todo tags to the DocBlocks of functions that contain backward compatibility with previous versions of WordPress stating when back compat should be removed. _s supports the current stable version of WordPress as well as two prior major releases.
2012-08-27 14:25:10 -07:00
Lance Willett
7a4aa04261
Merge pull request #16 from obenland/patch-1
...
Use get_header_textcolor() for forward compatibility, props obenland.
2012-08-06 16:21:19 -07:00
Michael Fields
f705f1c5f9
_s: Update Custom Header Code. fixes #1212
...
* Use WordPress 3.4's registration method providing backward compatibility for previous versions.
* Implement shiv for get_custom_header(). props @obenland
* Allow all custom header args to be filtered via child theme/plugin.
* Update example code in DocBlock to use get_custom_header().
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9484 d957f892-c61d-0410-b221-f235e6eecf30
2012-04-23 22:52:48 +00:00
obenland
036f80fd9a
Use get_header_textcolor() for forward compatibility
2012-04-05 22:56:13 +03:00
Ian Stewart
761e93ad32
_s: adding a sample custom header, commented out
2012-01-31 20:18:40 +00:00