Remove #primary
Remove #primary, take 2
Change primary layout module to CSS grid.
Remove ::before / ::after based clearfixes. When using flex and grid, pseudo-elements are considered flex/grid elements and cause unexpected behavior. Clearfix is a tool to resolve clearing when using float-based layouts. Modern flex/grid-based layouts do not need them.
Main menu: Use flex as layout module.
Main menu cleanup.
Comments, Posts, and Post Navigation: Use flex for layout. Automatic RTL.
Remove errant test data.
- Fixed skip to content link to point to main content (#primary).
- Changed ID for <main> to #primary to preserve original separation between main and sidebar (#secondary).
- Removed superfluous ID reference to #secondary in CSS.
- Cleaned up whitespace triggering Travis errors.
Fix wpcs issues
Cleaning the rebase
Compile CSS
Remove primary div from WooCommerce too
grid-template-columns property doesn't support negative values
While template files are intended to be included from within a function, this doesn't guarantee they always will be.
Therefore all variables declared within template files also need to be prefixed with a theme specific prefix.
As these are "local" variables, renaming them does not constitute a BC-break.
* Reverts this commit: https://github.com/Automattic/_s/pull/927 The issue for that, #928 referenced an old commit. The `id` is still in the source though.
* Brought up by #982. The `id` was correct, should not have been changed and this fixes everything.
Fixes#982
Rationale:
1. The principle of pingbacks is based on articles. Pingbacks are a special kind of comments and the article being 'pinged-back' has to be identifiable (which they're not on archive pages and the like).
2. WP only registers a ping if it can identify the article which is supposed to have been 'pung'. See: https://developer.wordpress.org/reference/classes/wp_xmlrpc_server/pingback_ping/
3. Pingbacks, like comments, can be disabled on a per article basis.
Therefore, having the pingback url auto-discovery header in place, only makes sense on singular pages where pings are open.
In header.php: Site title set to H1 on front page, div on other pages
In functions.php: Widget title set to H2 for semantic hierarchy
In content-search.php and content.php: Heading set to H2 as page title is "Search" or "Archive title" etc.