Commit Graph

1379 Commits

Author SHA1 Message Date
David A. Kennedy bce3197a42 Merge pull request #1121 from jrfnl/feature/fix-WPCS-url
PHPCS ruleset: Improve documentation links
2017-06-16 00:57:33 +02:00
jrfnl 755619e74d WPCS: Allow for typical theme specific file names based on the theme hierarchy.
Ref: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#themes-allow-filename-exceptions
2017-06-16 00:53:50 +02:00
jrfnl b560425ff1 PHPCS ruleset: add link to the PHPCompatibility repo.
At the top of the ruleset there were links to the PHPCS and the WPCS repo, but not to the PHPCompatibility repo which is also being used.
2017-06-16 00:48:12 +02:00
jrfnl bc9d5f742e Fix link to WPCS in the PHPCS ruleset.
The link was pointing to the `WordPress-Core` ruleset, while `_s` uses the `WordPress` ruleset which encompasses more than just the core rules.

Pointing to the repo + the wiki seems more appropriate to me.
2017-06-16 00:48:11 +02:00
David A. Kennedy 67d6d59235 Merge branch 'feature/rename-phpcs-ruleset' 2017-06-16 00:39:39 +02:00
David A. Kennedy 23f963f322 Merge pull request #1115 from jrfnl/feature/check-correct-text-domain
Verify the text domain provided for all translatable strings for WPCS
2017-06-16 00:25:34 +02:00
David A. Kennedy fcf923ea44 Merge pull request #1119 from gatespace/pot-file-update
Regenerated the .pot file to be in line with recent code changes
2017-06-16 00:22:22 +02:00
David A. Kennedy aa0ae6c1b5 Merge pull request #1120 from JulienMelissas/patch-2
Add consistent formatting for skip-link-focus-fix.js
2017-06-16 00:13:51 +02:00
David A. Kennedy 379c999ae2 Merge pull request #1090 from kkalvaa/patch-1
Make sure dropdown menu container is always flush with the parent box regardless of the font size
2017-06-15 23:51:44 +02:00
Julien Melissas b51b81a311 Consistent formatting for skip-link-focus-fix.js
Just noticed the spacing on the other files and not this one... See https://github.com/Automattic/_s/blob/master/js/customizer.js#L9 and https://github.com/Automattic/_s/blob/master/js/customizer.js#L42
2017-06-15 14:28:19 +02:00
Kazue Igarashi 79a76a97c2 _s.pot file update.
* Update copyright year.
* Add comments for translators.
* Translation fix for a comment strings
* Added translation word by code change. see #1100, #1066 #1117
2017-06-15 21:01:23 +09:00
Joseph Fusco e72425f1c4 Add comment describing loop 2017-06-14 14:18:22 -04:00
David A. Kennedy 0f49e8a530 Merge pull request #1117 from Automattic/continue-reading-i18n
Improve "Continue reading" word order for internationalization.

Fixes #1088
2017-06-12 06:28:38 -04:00
Kristian Kalvå d814c78aa7 Create style.css 2017-06-12 12:27:32 +02:00
Naoko Takano (McCracken) ef2a0e7c00 Improve "Continue reading" word order for i18n
Resolves translation word order issue for some locales when the screen reader only text is invisible.
Fixes #1088
2017-06-12 16:08:10 +09:00
jrfnl 1bf6817e44 WPCS: verify the text domain provided for all translatable strings.
Ref: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#internationalization-setting-your-text-domain
2017-06-12 01:41:31 +02:00
jrfnl b78d053772 PHPCS: Move the recommended command line arguments into the custom ruleset. 2017-06-12 00:21:34 +02:00
jrfnl 0d353e1c0c Rename the PHPCS ruleset.
If the file is called `phpcs.xml` or `phpcs.xml.dist`, it is automatically picked up by PHPCS.

A `phpcs.xml` is given preference over a `phpcs.xml.dist` file. So renaming the file to `phpcs.xml.dist` allows for people to use the file provided by `_s` if they choose not to add their own, but also leaves people the freedom to easily overrule it.
2017-06-12 00:11:53 +02:00
David A. Kennedy 59b66c7dd5 Merge pull request #1098 from iliman/patch-1
Update readme.txt to make tags consistent with style.css
2017-06-10 14:41:48 -04:00
Ilya cd88228bf3 Create readme.txt 2017-06-10 16:18:38 +04:00
David A. Kennedy ef5351227e Merge pull request #1001 from Clorith/master
Make the `content.php` more flexible with post types by using `is_singular()`
2017-06-10 01:26:55 -04:00
David A. Kennedy 7a04605a0b Remove invalid rel="designer" attribute
Refresh of #1016
Fixes #1020
2017-06-10 00:58:56 -04:00
David A. Kennedy 9b576d5852 Merge pull request #1060 from gatespace/license-add-sass
Add license and update Normalize site link to Sass file.
2017-06-10 00:49:10 -04:00
David A. Kennedy 3cad864383 Merge pull request #1081 from bahiirwa/master
Add new accessibility `word-wrap` styles to Sass files to match main stylesheet
2017-06-10 00:40:07 -04:00
David A. Kennedy 7320fe67a3 Merge pull request #1106 from vinoddalvi/master
Adding ID to comment labels for post articles
2017-06-10 00:29:24 -04:00
David A. Kennedy 606e1135dd Merge pull request #1093 from B-07/patch-2
Make doctype lowercase for better consistency with other HTML tags
2017-06-09 23:02:24 -04:00
David A. Kennedy c6d64b63fc Merge pull request #1112 from davidakennedy/master
Fix build errors related to #1066
2017-06-09 16:33:12 -04:00
David A. Kennedy 4d66f92ea4 Merge branch 'master' of github.com:davidakennedy/_s 2017-06-09 16:30:19 -04:00
David A. Kennedy 1e9b0c686e Fix build errors related to #1066
Tweak #1066 to fix build errors

Adjust location of placeholder text
2017-06-09 16:29:17 -04:00
David A. Kennedy 187caf5d69 Adjust location of placeholder text 2017-06-09 16:24:18 -04:00
David A. Kennedy b408191a9c Tweak #1066 to fix build errors 2017-06-09 16:19:21 -04:00
David A. Kennedy 007f792515 Fix build errors related to #1066 2017-06-09 16:10:50 -04:00
Ilya 94bbb1cbf7 Remove tags 2017-06-09 23:47:31 +04:00
David A. Kennedy 3aa7934d56 Merge pull request #1066 from yoavf/fix/edit-post-link-i18n
Prevent broken translations in some locales for the edit post link
2017-06-09 15:46:16 -04:00
David A. Kennedy ba3966924f Merge pull request #1078 from mtomas7/patch-1
Allow category display in post preview even when only one category
2017-06-09 15:36:46 -04:00
David A. Kennedy df40a3da23 Update README.md to be consistent with new file name
See #1064
2017-06-09 15:22:15 -04:00
David A. Kennedy bfa0b9a024 Merge pull request #1111 from grappler/feature/1064-extras
Replace extras.php with template-functions.php to make the file name more useful

Fixes #1064
2017-06-09 15:17:42 -04:00
David A. Kennedy cc7ca98ab4 Merge pull request #1034 from joshmcrty/master
Update .site-title styles instead of anchor in customizer script.

Closes #990
2017-06-09 15:00:38 -04:00
Ulrich Pogson 118dc76631 Replace extras.php with template-functions.php
fixes #1064
2017-06-09 20:37:13 +02:00
David A. Kennedy 458a207fe5 Update WordPress version and copyright date 2017-06-09 12:32:15 -04:00
David A. Kennedy b28c6d6ca2 Merge pull request #1110 from davidakennedy/master
Switch versions of PHP Code Sniffer for build process
2017-06-09 12:10:54 -04:00
David A. Kennedy 521b475f3b Switch versions of PHP Code Sniffer for build process
* Switches to 2.9 branch to avoid failed builds for now.

See: https://github.com/Automattic/_s/issues/1067#issuecomment-307258832

See #1079
2017-06-09 12:03:55 -04:00
David A. Kennedy 812fefd66e Merge pull request #1101 from jrfnl/feature/i18n-and-code-layout
I18n and code layout improvements.

* Fixes missing /* translators */ comments for translatable text strings containing placeholders.
* Fixes infractions against the "For associative arrays, values should start on a new line." code style rule.
2017-06-09 11:51:46 -04:00
David A. Kennedy d2b58f60fe Merge pull request #1100 from jrfnl/feature/i18n-translation-call-context
I18n: Fix a translation call for a text string which needs context
2017-06-09 11:25:37 -04:00
David A. Kennedy 923d8f1f6a Merge pull request #1099 from jrfnl/feature/fix-code-obfuscation
Code obfuscation: Fix assignment within a condition
2017-06-09 11:23:59 -04:00
David A. Kennedy 97eb58a129 Merge pull request #1012 from jrfnl/feature/fix-i18n-issue
Fix translatability of comments title
2017-06-08 19:37:17 -04:00
David A. Kennedy f0867cf9b5 Merge pull request #1084 from mrwweb/theme-team-contrib
Clarify who maintains _s
2017-06-08 19:21:11 -04:00
Vinod Dalvi d61599b1ef Adding ID to comment labels for post 2017-05-10 14:11:46 +05:30
jrfnl a65be48368 CS: Fix code layout of nested function calls with associative arrays. 2017-04-03 00:46:36 +02:00
jrfnl 8cefd8f258 I18n: ensure all text strings with placeholders have translators comments. 2017-04-03 00:46:24 +02:00