Commit Graph

96 Commits

Author SHA1 Message Date
jrfnl 54ad32a598 🔖 CS: whitelist two global variable overrides
The one in `functions.php` can be considered a bug in WPCS and has been reported as such.
Once that issue is fixed, the whitelisting can be removed.

The one in `inc/wpcom.php` will need to remain as WPCS does not keep track of globals introduced by wpcom.
2018-02-27 14:34:53 +01:00
Tiago Noronha 46a41b2042 Newlines, data validation, and translators comment. 2017-08-01 15:42:22 +01:00
Tiago Noronha 27e68252f6 Basic WooCommerce Integration. 2017-08-01 14:21:13 +01:00
Truong Giang 9fcb8dab40 Correct code indentation 2017-07-27 00:37:56 +07:00
Juliette 4a2e99e691 Conditionally include Jetpack compatibility file. (#858)
Only include the Jetpack file if Jetpack is available on a site
2017-07-14 12:37:12 -04:00
Dominik Schilling fd89fb8a10 Update comment for template-functions.php include
Syncs the comment with the change in 7b8db5678f
2017-06-30 23:05:45 +02:00
David A. Kennedy 2bef512355 _s: Add basic custom logo support
See: https://codex.wordpress.org/Theme_Logo

Closes #922
2017-06-26 18:47:12 -04:00
jrfnl 7b8db5678f Move pingback function back to the `template-functions` file. 2017-06-16 01:17:42 +02:00
Ulrich Pogson 118dc76631 Replace extras.php with template-functions.php
fixes #1064
2017-06-09 20:37:13 +02:00
Tammie Lister 9700947f74 Merge pull request #1018 from mrwweb/tux-menu-naming
Change primary menu idea to menu-1: props @mrwweb
2016-12-23 14:40:15 +00:00
Tammie Lister 69cdd5361c Merge pull request #1049 from samikeijonen/issue/994
Add theme support for selective refresh for widgets: props @samikeijonen
2016-12-23 14:31:19 +00:00
Sami Keijonen 77645d7818 Add theme support for selective refresh for widgets. 2016-11-26 18:42:28 +02:00
Bappi 7a7c6e7d89 Remove period from file header 2016-09-27 12:21:19 +06:00
mrwweb 396b9cbcd4 change primary menu idea to menu-1 to align with new Automattic "Theme User Experiences Requirements" 2016-09-15 18:06:11 -07:00
Caroline Moore 2316b1981c Removing post formats support and styles from _s 2016-06-13 16:39:54 -04:00
Emil Uzelac d92026bb8f Update functions.php 2016-03-28 17:51:13 -05:00
Emil Uzelac debdbd5c6e Add widget description
I keep seeing authors leave description as-is (empty) and believe that it wouldn't hurt to add something in by default. This is a general description taken from https://github.com/WordPress/twentysixteen/blob/master/functions.php#L150

At the same time it shows good practice how to escape the content and translate the string too.
2016-03-22 16:42:46 -05:00
Konstantin Obenland 6ae11474be Merge pull request #888 from jrfnl/feature/slim-down-travis
Slim down the travis script - remove superfluous checks.

Fixes #881.
2016-02-11 09:42:09 -10:00
jrfnl 4a3cd975ec Let's not forget to clear the js cache as they have changed. 2015-12-15 10:38:37 +01:00
Konstantin Obenland cdd101e16c Remove comments not ending in a period.
Helps avoid Travis CI errors for wrongly formatted comments. Most of
these end of function comments (if not all) are useless anyway.

Props @WPAddiction for reporting.
Fixes #891.
2015-12-14 18:05:14 -08:00
sarah ✈ semark 181dda8f01 Merge pull request #867 from WPAddiction/change-aside
Use a single aside for sidebar element, with sections for each widget.
2015-11-30 18:11:36 +00:00
sarah f3fe297585 Update 'primary menu' location to 'primary' to simplify for users. 2015-11-30 12:59:37 +00:00
Mark Batchelder 77e3087c2e Changed widget wrapper from div to section
Per https://github.com/WordPress/twentysixteen/issues/355
2015-11-24 00:06:27 -08:00
Mark Batchelder 15cef7e795 Move aside from the widgets to the entire sidebar.
It appears that the entire sidebar should be one large aside instead of
making each widget it's own aside. At least that's how I understand it
when reading w3. It would make sense to make each widget it's own aside
if not all of the widgets were asides, but otherwise the entire sidebar
should be considered one aside.

Plus I think this would make more sense for accessibility and with the
widgets titles being h2 because if the entire sidebar had a title that
would be the h1.

https://www.w3.org/wiki/HTML/Elements/aside
2015-11-20 23:14:31 -08:00
Tammie Lister 6b00d94ea7 Merge pull request #809 from emiluzelac/patch-43
Header link update and capitalization
2015-09-16 20:43:58 +01:00
Dmitry Mayorov 9d6eade725 Added missing period in a load_theme_textdomain() comment. 2015-08-22 10:31:12 +03:00
Emil Uzelac 3bac555d40 Update functions.php 2015-08-21 22:31:14 -05:00
Emil Uzelac 4b519c124b Update functions.php 2015-08-21 22:24:25 -05:00
Emil Uzelac fd58ebd1cb Header link update and capitalization
Itty-bitty update for header comment block and new functions link.
2015-08-21 22:19:26 -05:00
Konstantin Obenland d02cc4fa70 Merge pull request #778 from emiluzelac/patch-41
Link to developer resources for further reading.
2015-08-04 11:19:20 -07:00
Konstantin Obenland 4b36cf3053 Merge pull request #781 from PJ-Finlay/add-documentation-in-comments
Updated file documentation.
2015-08-03 12:13:35 -07:00
PJ de9c9888b7 Updated documentation in comments at the top of files.
I tried to standardize and expand the documentation and links to
codex.wordpress.org in the comments at the top of most files.
2015-07-12 12:38:18 -04:00
Emil Uzelac b685b89b3f Inline link update
I believe that we can update inline links to https://developer.wordpress.org. Please confirm.
2015-06-29 14:18:47 -05:00
Morten Rand-Hendriksen dc6d3fa08c New heading structure - redux of #651. Provides proper semantic structure for titles throughout theme:
In header.php: Site title set to H1 on front page, div on other pages
In functions.php: Widget title set to H2 for semantic hierarchy
In content-search.php and content.php: Heading set to H2 as page title is "Search" or "Archive title" etc.
2015-06-28 12:06:02 -07:00
Fränk Klein 175524922c Fix Codesniffer errors. 2015-05-27 22:19:14 +02:00
Fränk Klein ce796e39a5 Merge pull request #460 from grappler/content_width
Move $content_width within setup function
2015-05-11 10:05:26 +02:00
Fränk Klein 2d86340f43 Escape translations in functions.php
See #737.
2015-05-05 12:38:55 +02:00
Ulrich Pogson 8e1ec40b79 Move $content_width within a function 2015-04-25 08:47:20 +02:00
Philip Arthur Moore 108799d104 Revert #638 for a bit. 2014-12-03 18:46:33 +07:00
Philip Arthur Moore c000d6489a Merge branch 'child-theme-support' of github.com:grappler/_s into grappler-child-theme-support 2014-12-03 17:00:09 +07:00
Philip Arthur Moore 83792b8566 First pass at better title handling for WordPress 4.1+ with proper back compatibility baked in. 2014-11-11 21:41:10 +07:00
Ulrich Pogson 58111f9cde Load parent styles when child theme is activated 2014-11-02 22:14:05 +01:00
Kirk Wight 348886e168 Comment correction: "setup" is a noun, "set up" is the action. 2014-10-07 18:58:25 -07:00
Philip Arthur Moore 895b7a93ab Prepare Underscores for Coding Standards. See https://github.com/Automattic/_s/issues/553. 2014-08-17 23:40:13 +07:00
Konstantin Obenland 91d2514a62 _s: List post formats in their own line.
d8a88d2097 brought the HTML5 support declaration close to how Twenty Thirteen and Twenty Fourteen do it, leaving post formats doing their own thing.

Let's make displaying array values consistent with the latest default themes.
2014-05-29 14:14:25 -07:00
Emil Uzelac d8a88d2097 Post Formats code re-formatting
See: https://github.com/Automattic/_s/pull/498#issuecomment-44492997
2014-05-29 01:54:04 -05:00
Konstantin Obenland 16a0d47af6 Merge pull request #443 from joshmcrty/master
Add support for HTML5 captions.
2014-04-25 11:04:47 -05:00
Konstantin Obenland 32350a8103 _s: Encourage the use of sidebar descriptions.
Sidebar descriptions provide an opportunity to provide context about
where the sidebar is located or when it is loaded. We should encourage
theme developers to use them, similar to how we hint default images for
custom headers and backgrounds.

The callback’s outdated documentation describes the function in an
early state of Toolbox (introduced in r3678-wpcom-themes), the earliest
public record would be
https://themes.trac.wordpress.org/browser/toolbox/0.3/functions.php#L99
This is as good an opportunity to update it as any.

Props @emiluzelac for initial patch.
Fixes #433.
2014-04-10 19:03:23 -07:00
Josh McCarty d193c519b4 Add support for html5 caption 2014-03-23 21:46:35 -07:00
Konstantin Kovshenin 85bce0cc74 Add HTML5 support for WordPress galleries. 2014-02-27 13:27:00 -06:00