Commit Graph

906 Commits

Author SHA1 Message Date
Konstantin Obenland de7a9b576b _s: Remove leading white space for theme name.
At some point in the past it was believed that a leading whitespace was
necessary for a proper replacement.

Let’s see if the existing replace handler can indeed handle it without
it.

See
https://github.com/Automattic/underscores.me/commit/7671cad5685ae8df50a0
2f871a1ae28119b8dbf1
2014-12-30 20:05:47 -08:00
Fränk Klein c4f6755f61 Remove home link from wp_page_menu() args. 2014-12-30 14:53:42 +01:00
Konstantin Obenland 6c47be98c1 Normalize rather than Reset.
The reset we used was a mix of Normalize, the Paul Irish reset,
sprinkled with some blueprint.css, and base styles. It was hard to
maintain and just seemed outdated (setting the base font-size to 10px
instead of 16px, among other things).

Normalize sets saner defaults and is generally just not as disruptive
as a full reset.

The code was added as is, has only its comments stripped (for now), and
is not mixed with any styles to make future updates to it as easy as
possible.

See #3, #44, #174, #267, #617.
2014-12-30 01:28:19 +01:00
Julien Melissas 67fb1af3f3 Add braces around if statement.
Running jshint on this file returned an error, adding braces fixed it. Please add braces around if statements!!! :)
2014-12-24 00:19:34 -05:00
Konstantin Obenland 37d283481f Avoid repeatedly checking specific post format.
Will only check for a specific post format if it’s a post format
archive page.

See https://core.trac.wordpress.org/changeset/30854
Fixes #664.
2014-12-22 10:11:39 +01:00
Konstantin Obenland 47ee126fb4 Don't check for a private function.
Even with WordPress’ commitment to backwards compatibility, we should
probably not bank on private functions being around for ever, and tying
our functionality to it.

This will go old school and do a version check to provide compatibility
with older versions of WordPress. Again, this is only temporary until
4.3 is out.

See #644.
Fixes #636.
2014-12-22 10:06:15 +01:00
Konstantin Obenland f2d2495630 Switch in and out of PHP to render fallback title.
The upload checks for the .org Theme Directory are rightfully strict about the contents of the title tag.
Switching in and out of PHP should make `_s`-based themes pass those tests again.

See https://github.com/Automattic/_s/pull/644#discussion-diff-22153263
See #644.
2014-12-22 09:16:13 +01:00
sixhours 204654ac1f Revert previous (unintentional) commit 2014-12-17 15:09:44 -05:00
sixhours 88f94a9a4e First pass at fixing drop-down menus for touch
This patch allows the user to view a site on a touch screen tablet and
access child menus by clicking on the parent once, or access the parent
by clicking on it twice. Props @iamtakashi for the original fix.
2014-12-17 15:03:17 -05:00
Philip Arthur Moore 108799d104 Revert #638 for a bit. 2014-12-03 18:46:33 +07:00
Philip Arthur Moore 687e5e6e92 Merge branch 'grappler-child-theme-support' 2014-12-03 17:06:24 +07:00
Philip Arthur Moore c000d6489a Merge branch 'child-theme-support' of github.com:grappler/_s into grappler-child-theme-support 2014-12-03 17:00:09 +07:00
Philip Arthur Moore 0750bd029b Update POT. Fixes #645. 2014-12-03 16:47:10 +07:00
Philip Arthur Moore cfda0096b3 Merge pull request #644 from Automattic/title-theme-support
Better WordPress title handling for WordPress 4.1+ with proper back compat.
2014-12-02 20:25:57 +07:00
Philip Arthur Moore 3a25519cc7 Adjust todo notice for wp_title shim. 2014-12-02 20:23:28 +07:00
Philip Arthur Moore 8b23932190 Merge remote-tracking branch 'origin/master' into title-theme-support 2014-12-02 20:11:14 +07:00
Konstantin Obenland b550416497 Merge pull request #648 from nickdaugherty/check-autosaves
Check DOING_AUTOSAVE before flushing transients.

Fixes #646.
2014-11-14 00:33:57 -05:00
Philip Arthur Moore 648a5467e9 Better title handling for WordPress 4.1. See #644. 2014-11-14 08:46:20 +07:00
Nick Daugherty 711ce1967e Check DOING_AUTOSAVE before flushing transients
So that we don’t flush transients more often than necessary.

Fixes #646
2014-11-13 17:44:08 -07:00
Konstantin Obenland bb867c0fcb _s: Introduce 4.1 archive template tags.
Now uses the new archive template tags and makes archive template
titling way simpler!

Added shims for backwards compatibility, which can be removed once
WordPress 4.3 was released.

See https://core.trac.wordpress.org/changeset/30223
Closes #556.
2014-11-12 15:52:31 -05:00
Konstantin Obenland 6c783cd09f Merge pull request #580 from jgclarke/patch-1
Use `div`s consistently throughout templates.
2014-11-12 14:49:17 -05:00
Konstantin Obenland e142af3a27 Merge pull request #643 from Automattic/aria-toggle
Improve menu toggle accessibility.

Fixes #575.
2014-11-12 14:35:29 -05:00
Philip Arthur Moore 83792b8566 First pass at better title handling for WordPress 4.1+ with proper back compatibility baked in. 2014-11-11 21:41:10 +07:00
Konstantin Obenland d8d89bc681 _s: Improve menu toggle accessibility.
Makes it a little easier to use the primary navigation with assistive
devices.

See #545.
2014-11-05 17:37:48 -08:00
Konstantin Obenland 23d0a41722 Merge branch 'master' of https://github.com/Automattic/_s 2014-11-05 17:19:15 -08:00
Konstantin Obenland e4a252b630 _s: Merge branch 'pr/609'.
Props @mor10 for documentation.
Fixes #641.
2014-11-05 17:19:10 -08:00
Konstantin Obenland 34859539c1 Merge pull request #640 from emiluzelac/patch-34
Closing DIV comment for site-branding.
2014-11-05 17:05:59 -08:00
Konstantin Obenland 921992277d _s: Merge branch 'pr/616'. 2014-11-05 17:02:58 -08:00
Konstantin Obenland 8ba2a53f3a _s: Remove remaining box-sizing prefix.
Also removes the box-sizing mixin, as it is of no use anymore.

See http://caniuse.com/#feat=css3-boxsizing
See #558.

Fixes #561.
2014-11-05 16:53:52 -08:00
Konstantin Obenland 69171d3ea3 _s: Merge branch 'pr/561'. 2014-11-05 16:49:07 -08:00
Emil Uzelac 78afbb911b Closing DIV comment for site-branding
Call it OCD, but I feel like we need a closing DIV comment for  ```site-branding``` :)
2014-11-02 22:40:09 -06:00
Ulrich Pogson 58111f9cde Load parent styles when child theme is activated 2014-11-02 22:14:05 +01:00
Philip Arthur Moore 964c19070f The commit 6986e21182 (diff-9dbd3b63f5d2589b5eb1701e92893803) began (in part) breaking Travis CI builds in _s. There’s most certainly room for improvement to _s code with regard to WordPress Coding Standards, but let’s exclude WordPress.Variables.GlobalVariables and correct all coding standards errors on localhost before removing the excludes from our GitHub-hosted ruleset. 2014-11-01 08:06:22 +07:00
Philip Arthur Moore 7de804d3b3 Better rules for Travis CI. 2014-11-01 08:02:31 +07:00
Philip Arthur Moore b443161ed6 Better build config for Travis CI. [skip ci] 2014-11-01 07:45:39 +07:00
Philip Arthur Moore 2540fb7b7f Better WordPress Coding standards.
This minor commit kicks off code improvements to _s so that it’s fully in line with WordPress Coding Standards rules.
2014-11-01 07:09:58 +07:00
Konstantin Obenland eab9f19d63 Merge pull request #633 from sdavis2702/master
Remove unnecessary comparisons. Closes #632.
2014-10-14 18:02:44 -07:00
Sean Davis 5ab860c48b remove unnecessary comparison 2014-10-14 19:57:47 -05:00
Sean Davis b9ebebb28b remove unnecessary comparison 2014-10-14 19:57:29 -05:00
Kirk Wight 348886e168 Comment correction: "setup" is a noun, "set up" is the action. 2014-10-07 18:58:25 -07:00
Konstantin Obenland 71e1f948b4 Merge pull request #628 from grappler/languages-readme
Update links to those relevant to themes.
2014-10-05 17:50:41 +02:00
Ulrich Pogson 8404380366 Update links to those relevant to themes 2014-10-05 18:31:20 +03:00
Tim Moore 85247e7996 Merge pull request #605 from 1upon0/master
Update style.css fixes #587
2014-09-21 09:48:40 -06:00
Tim Moore bdab57a53f Fix child menu styling inheritance. See #587 2014-09-21 09:47:04 -06:00
Ram Ratan Maurya 1ca71befe2 Remove border-radius mixin 2014-09-14 22:56:29 +05:30
Konstantin Obenland b9191d970e Merge pull request #612 from emiluzelac/patch-33
Double quotes for consistency.
2014-09-14 09:41:41 -07:00
Philip Arthur Moore 097b54dda2 Merge branch 'Entry-Meta-Output' 2014-09-11 08:45:31 +07:00
Konstantin Obenland 907403fc52 Merge branch 'Entry-Meta-Output' of https://github.com/Automattic/_s into Entry-Meta-Output
Conflicts:
	content-single.php
2014-09-10 18:06:15 -07:00
Konstantin Obenland 7a9b1656f6 _s: Update pot file to reflect changes. 2014-09-10 17:50:08 -07:00
Konstantin Obenland a14b802e75 _s: Move edit link in template tag for consistency
Every time `_s_entry_footer()` is used, it’s followed by
`edit_post_link()`. Might as well just move that back in the template
tag.
2014-09-10 17:41:19 -07:00