Commit Graph

181 Commits

Author SHA1 Message Date
David A. Kennedy 812fefd66e Merge pull request #1101 from jrfnl/feature/i18n-and-code-layout
I18n and code layout improvements.

* Fixes missing /* translators */ comments for translatable text strings containing placeholders.
* Fixes infractions against the "For associative arrays, values should start on a new line." code style rule.
2017-06-09 11:51:46 -04:00
David A. Kennedy d2b58f60fe Merge pull request #1100 from jrfnl/feature/i18n-translation-call-context
I18n: Fix a translation call for a text string which needs context
2017-06-09 11:25:37 -04:00
jrfnl a65be48368 CS: Fix code layout of nested function calls with associative arrays. 2017-04-03 00:46:36 +02:00
jrfnl 8cefd8f258 I18n: ensure all text strings with placeholders have translators comments. 2017-04-03 00:46:24 +02:00
jrfnl 9c0cb095c7 Code obfuscation: Fix assignment within a condition 2017-04-03 00:44:57 +02:00
jrfnl 5c27fded17 I18n: Fix a translation call for a text string which needs context 2017-04-03 00:39:36 +02:00
Tammie Lister 6e04a5f802 Merge pull request #1035 from bjorn2404/master
The header change to use a get_bloginfo : props @bjorn2404 
Can you please make sure you explain beyond just using technical calls.
2016-12-23 14:48:15 +00:00
Tammie Lister 3c7fe6f91e Merge pull request #1051 from samikeijonen/issue/1041
Remove link around header image: props @samikeijonen
2016-12-23 14:29:25 +00:00
Tammie Lister 59fc136158 Merge pull request #991 from grappler/custom-header
Remove deprecated constant HEADER_TEXTCOLOR : props @grappler
2016-12-23 14:22:52 +00:00
Sami Keijonen 2370c59676 Use the_header_image_tag() function. 2016-11-27 12:57:24 +02:00
Sami Keijonen 31a9e90437 Remove link around header image. 2016-11-26 19:26:12 +02:00
Bjorn 8e1367bce3 _s_pingback_header should use get_bloginfo instead of bloginfo because echo is already being used to output the link tag (entire line) 2016-10-18 17:48:16 -05:00
Bappi 1ed9d1a85e Remove period from file header 2016-09-27 12:05:53 +06:00
Bappi d362be1e30 Remove period from file header 2016-09-27 12:05:33 +06:00
Bappi f3ee8eb485 Remove period from file header 2016-09-27 12:04:56 +06:00
Bappi 99cc3ff5b4 Update customizer.php 2016-09-27 12:04:03 +06:00
Bappi 394e02a5d5 Remove period from file header 2016-09-27 12:03:40 +06:00
Bappi c19b43fe3a Remove period from file header 2016-09-27 11:58:22 +06:00
David A. Kennedy ff4b374d6b Merge pull request #853 from jrfnl/feature/conditional-pingback-header
Only generate pingback url header tag when relevant.
2016-09-02 19:37:25 -04:00
Ulrich Pogson 71771d92d7 Remove deprecated constant HEADER_TEXTCOLOR 2016-07-24 21:22:27 +02:00
Kazue Igarashi d1ea3e1a75 Using tabs instead of mixed tabs/spaces
Mixed usage of tabs/spaces for `/inc/jetpack.php` and `/sass/style.scss`.
2016-07-05 13:04:11 +09:00
Tammie Lister 21208ab381 Merge pull request #915 from samikeijonen/master
comments_popup_link arguments props @samikeijonen.
I think Travis is having a moment about other issues so going to commit as on testing this it does work. Thanks.
2016-03-29 00:01:17 +01:00
Eugene Kopich ff3b49e7ae New Jetpack domain 2016-03-10 13:36:21 +02:00
Konstantin Obenland 6ae11474be Merge pull request #888 from jrfnl/feature/slim-down-travis
Slim down the travis script - remove superfluous checks.

Fixes #881.
2016-02-11 09:42:09 -10:00
Sami Keijonen 21e812e748 Let the Core handle all the others arguments but the first one. This is better
for accessibility. And fewer strings to translate in your theme.
2016-02-10 13:51:10 +02:00
jrfnl 4a3cd975ec Let's not forget to clear the js cache as they have changed. 2015-12-15 10:38:37 +01:00
Konstantin Obenland cdd101e16c Remove comments not ending in a period.
Helps avoid Travis CI errors for wrongly formatted comments. Most of
these end of function comments (if not all) are useless anyway.

Props @WPAddiction for reporting.
Fixes #891.
2015-12-14 18:05:14 -08:00
jrfnl 9638b7e3c6 Only generate pingback url header tag when relevant.
Rationale:
1. The principle of pingbacks is based on articles. Pingbacks are a special kind of comments and the article being 'pinged-back' has to be identifiable (which they're not on archive pages and the like).
2. WP only registers a ping if it can identify the article which is supposed to have been 'pung'. See: https://developer.wordpress.org/reference/classes/wp_xmlrpc_server/pingback_ping/
3. Pingbacks, like comments, can be disabled on a per article basis.

Therefore, having the pingback url auto-discovery header in place, only makes sense on singular pages where pings are open.
2015-12-04 16:44:38 +01:00
sarah ead318fd20 Remove custom header admin callbacks.
These haven't been needed since 4.1, when the Header page under
Appearance was deprecated and linked to the Customizer instead.
2015-12-03 20:29:32 +00:00
patryk 4433c1f0b7 Last 3 non-https WordPress URLs updated and custom header link updated too - issue #734 2015-12-01 21:06:47 +01:00
patryk be085c6d0c Last 3 non-https WordPress URLs updated - issue #734 2015-12-01 19:34:53 +01:00
David A. Kennedy 22b035ad55 Fix failing Travis build because of extra whitespace 2015-11-11 17:51:13 -05:00
Tammie Lister 2eb3836006 Merge pull request #848 from ernilambar/master
respect content-search.php for search result in Jetpack Infinite Scroll
Merging as comments and second opinion given in ticket.
2015-11-11 20:33:37 +00:00
Tammie Lister 7c2d3ce6eb Merge pull request #820 from sixhours/master
Remove hfeed from header.php, add to body_class filter. See #740
2015-11-11 20:27:21 +00:00
ernilambar a64e3a8092 respect content-search.php for search result in Jetpack Infinite Scroll 2015-11-10 11:22:39 +05:45
David A. Kennedy 82e852c454 Fix failing build in Travis
* See: https://travis-ci.org/Automattic/_s
* Build failed because of empty lines are not allowed in multi-line function.
2015-10-29 12:25:14 -04:00
Thomas Guillot 6f39c5ecf8 Update PHP Documentation 2015-10-26 16:33:55 +01:00
Thomas Guillot a29f4497a8 Add theme support for Responsive Videos. 2015-10-13 12:39:42 +02:00
sarah cdd7f9b333 Simplify check for hidden header text. 2015-09-17 16:58:03 +01:00
Caroline Moore 1f85e9b067 Add 'hfeed' class via body_class
* Only add the 'hfeed' class when viewing a non-singular page, such as an index or archive
2015-09-16 15:08:02 -04:00
sarah ✈ semark b1b13f58d8 Merge pull request #775 from davidakennedy/editlinkposttitle
Add post title to `edit_post_link`
2015-09-16 19:58:22 +01:00
David A. Kennedy 268a1e2ced Merge pull request #792 from grantpalin/master
Update comparisons to resolve the strict comparison warnings
2015-08-21 19:28:13 -04:00
Tom de Bruin bdc9a8c52a Remove _s_wp_title function
No longer required under 2 version back support requirements.
2015-08-21 15:10:34 +01:00
sarah ✈ semark 149a40d70f Merge pull request #800 from iamdmitrymayorov/master
Remove template-tag shims for versions prior to 4.1. Solves #799.
2015-08-21 14:11:11 +01:00
Dmitry Mayorov 72a9a3b7e6 Removing the_posts_navigation(), the_post_navigation(), the_archive_title(), the_archive_description() since 4.3 is out. 2015-08-19 17:40:51 +03:00
Emil Uzelac 6f621af060 Remove _s_render_title()
Removing `_s_render_title()`, no longer needed as of 4.3.
2015-08-18 21:55:47 -05:00
Grant Palin af0a4749be Update comparisons to resolve the strict comparison warnings. See https://github.com/Automattic/_s/issues/784 2015-08-07 09:59:26 -07:00
PJ de9c9888b7 Updated documentation in comments at the top of files.
I tried to standardize and expand the documentation and links to
codex.wordpress.org in the comments at the top of most files.
2015-07-12 12:38:18 -04:00
David A. Kennedy 0a0e5c631f Add post title to `edit_post_link`
* Use `__()` instead of `_x()`
* Add translator comment, remove context modifier.
* Remove escaping on `the_title()`; it's trusted data.

Resolves: #774
2015-07-02 17:37:30 -04:00
David A. Kennedy c60811bf94 Add post title to `edit_post_link`
This improves the accessibility of these links, and gives more context for screen reader users. Now, they know exactly where the link goes.

Escaped output with `esc_html_x` and `wp_kses`.

Resolves: #774
2015-06-26 14:22:38 -04:00