Commit Graph

38 Commits

Author SHA1 Message Date
Morten Rand-Hendriksen 31df4716c8 Refactor the css layout to use grid and flex
Remove #primary

Remove #primary, take 2

Change primary layout module to CSS grid.

Remove ::before / ::after based clearfixes. When using flex and grid, pseudo-elements are considered flex/grid elements and cause unexpected behavior. Clearfix is a tool to resolve clearing when using float-based layouts. Modern flex/grid-based layouts do not need them.

Main menu: Use flex as layout module.

Main menu cleanup.

Comments, Posts, and Post Navigation: Use flex for layout. Automatic RTL.

Remove errant test data.

- Fixed skip to content link to point to main content (#primary).
- Changed ID for <main> to #primary to preserve original separation between main and sidebar (#secondary).
- Removed superfluous ID reference to #secondary in CSS.
- Cleaned up whitespace triggering Travis errors.

Fix wpcs issues

Cleaning the rebase

Compile CSS

Remove primary div from WooCommerce too

grid-template-columns property doesn't support negative values
2020-04-18 19:26:11 +01:00
Ismail El Korchi f94fc1e59b Fix PHP, CSS AND JS coding standards 2020-04-05 21:49:27 +01:00
jrfnl 98e3e75109 CS: prefix all variables
While template files are intended to be included from within a function, this doesn't guarantee they always will be.

Therefore all variables declared within template files also need to be prefixed with a theme specific prefix.

As these are "local" variables, renaming them does not constitute a BC-break.
2018-02-27 14:34:54 +01:00
jrfnl ec877e48c3 CS: fix up embedded PHP inconsistencies introduced in the mean time. 2018-02-27 14:34:54 +01:00
Ulrich Pogson b26b6ebfa4 Move PHP tags on it’s own line & correct indention
This fixes a few of the errors from the news sniffs in WPCS 0.12.0 and also standardizes the indention between the PHP and HTML
2018-02-27 14:34:53 +01:00
Laurel e25ab26c05 Merge pull request #1133 from Automattic/feature/remove-landmarks
Remove landmark roles
2017-06-26 12:59:15 -07:00
David A. Kennedy 5efec5e6b4 Remove call to `_s_categorized_blog()` (#1134)
* It was removed in #1131.
2017-06-23 13:16:37 -04:00
David A. Kennedy f56a070c2b Remove landmark roles
* With better browser support, these roles aren't needed now.
* Most newer browsers imply them via HTML5 semantics. See: http://html5doctor.com/on-html-belts-and-aria-braces/

Fixes #1132
2017-06-23 12:41:05 -04:00
Bappi 160e9f0301 Remove period from file header 2016-09-27 12:16:03 +06:00
Konstantin Obenland cdd101e16c Remove comments not ending in a period.
Helps avoid Travis CI errors for wrongly formatted comments. Most of
these end of function comments (if not all) are useless anyway.

Props @WPAddiction for reporting.
Fixes #891.
2015-12-14 18:05:14 -08:00
jrfnl 8470f55f92 Avoid going in and out of PHP unnecessarily.
Closes #854

Includes minor alignment changes for easier readability/detection of start/end of conditions.
2015-11-11 22:59:40 +01:00
PJ de9c9888b7 Updated documentation in comments at the top of files.
I tried to standardize and expand the documentation and links to
codex.wordpress.org in the comments at the top of most files.
2015-07-12 12:38:18 -04:00
Fränk Klein 89c2d8e4dc Escape translations on 404.php
See #737.
2015-05-05 12:34:08 +02:00
Philip Arthur Moore 66d350aa3c Get rid of coding standards errors in the 404 page template by making sure that potentially unsafe output is escaped. See #737. 2015-04-24 09:39:05 +07:00
Jack Lenox 776eaf6e94 Correcting some irregular capitalisation and coding standards issues 2014-06-25 00:13:36 +01:00
Emil Uzelac 6d0886c0d7 widgettitle value
```widgettitle``` doesn't really have any value here or in core. Proposing to change to ```widget-title``` instead and maybe add that into stylesheet too. 

The class is available only in /widgets.php and not present in any of the stylesheet's, at least I could not locate one. As in my previous proposal, this is for the consistency reasons only.
2014-05-24 16:20:23 -05:00
Kazue Igarashi e3ff3dfb5d Add tab to indent 404.php(L43 to L45). 2014-04-18 22:15:42 +09:00
Vinod Dalvi d295590742 Removed extra lines 2013-09-14 03:51:56 -07:00
obenland 810e499b93 _s: Use `<main>` element for main content.
See: http://www.w3.org/TR/html51/grouping-content.html#the-main-element

Props @BFTrick for initial patch.
Fixes #222.
2013-07-30 12:12:45 -07:00
obenland d406dc8f8c _s: Add `.page-content` class to `style.css` to encourage styling. Also
removes some redundant comments.
2013-07-11 12:18:47 -07:00
obenland 98c1c82c62 _s: Move away from using `<article>` for content that is not a post,
page, or attachment.
2013-07-11 12:12:59 -07:00
obenland 49bc3a577a _s: Remove .error404 class, it is used by core in `body_class()`. Props
@mfields. Fixes #195.
2013-05-25 11:59:09 +02:00
Takashi Irie c780bc0559 Add trailing commas to the last elements of arrays 2013-04-20 16:45:36 +01:00
Takashi Irie 7be757759c Minor code style clean-up 2013-04-20 01:26:43 +01:00
obenland a298e8c2bd _s: Revert partial heading change. 2013-03-26 15:56:47 -07:00
obenland 32d2432487 _s: Minor updates to categories widget. Closes #183. 2013-03-26 15:55:49 -07:00
Slobodan Manic dfbf5f5d2e Corrected if statement formatting 2013-03-26 21:03:29 +01:00
Slobodan Manic 153c76c92b Skip printing categories widget in 404 template if there's only one category
Addresses issue 183 - https://github.com/Automattic/_s/issues/183
2013-03-21 06:42:55 +01:00
Philip Arthur Moore fe19f5433b Ditch all @since DocBlocks from theme. 2013-03-18 14:53:23 -05:00
obenland c4f2aa32ce _s: Formatting changes:
- Reduce element comments to either the element id or the first element
class.
- Tabs > Spaces.
- Improve adherence to formatting guidelines.
2013-03-04 16:41:38 -08:00
kobenland 5905cc3889 _s: Move away from using <article> for content that is not syndicated. 2013-03-01 17:28:18 -08:00
Philip Arthur Moore e652d9f130 Change apos back to the correct rsquo. See #84. 2013-02-12 16:48:51 -06:00
pixolin 13efab7ac6 Corrected two typos
"don't" with &apos; should be more correct than &rsquot; (or is it better to escape it \' ?)
I personally find the line * translators: %1$s: smiley */ pretty confusing, but at least it should be singular (not smilies)
2012-09-18 11:48:12 +03:00
Matias 752d08afd7 Update the HTML "class" system
Improving on the naming convention of our classes with consistency
adjustments. Also creates a better hierarchy (matched pairs) for them.
2012-08-25 14:06:33 -03:00
kobenland b9fa5c0dd2 Add missing 'class' comments 2012-05-23 21:01:41 +02:00
Ian Stewart afe244fe68 _s: More consistency with class names in the structural markup 2012-02-01 16:55:36 +00:00
Ian Stewart ae85c2b76e _s
* Make the 404 page a little friendlier
* Add a missing tab to the header.php
2012-01-11 04:51:12 +00:00
Ian Stewart edfeccc255 _s: initial fork of Toolbox 2012-01-07 03:25:13 +00:00