comments_popup_link arguments props @samikeijonen.
I think Travis is having a moment about other issues so going to commit as on testing this it does work. Thanks.
I keep seeing authors leave description as-is (empty) and believe that it wouldn't hurt to add something in by default. This is a general description taken from https://github.com/WordPress/twentysixteen/blob/master/functions.php#L150
At the same time it shows good practice how to escape the content and translate the string too.
Many might choose multiple words as theme name, and they may not be sure where they should use a space, a hyphen or an underscore to separate words when doing the initial replacements. The example provided in the README file should cover that scenario.
* Include skip-link-focus-fix.js in the js hint/lint tests & fix up the file.
* Pull in .jshintrc from WP SVN.
* Add PHPCompatibility Sniffs.
* Sync the ignore statements to always exclude .min.js files.
* Slim down the tested against PHP versions even more.
Helps avoid Travis CI errors for wrongly formatted comments. Most of
these end of function comments (if not all) are useless anyway.
Props @WPAddiction for reporting.
Fixes#891.
What it will now do:
- Lint the php files against relevant PHP versions.
- Lint the js files once - the result won't change across PHP versions.
- Check against WPCS once - the result won't change across PHP versions.
What I have changed:
- Added linting against PHP 7 and HHVM, with HHVM being allowed to fail.
- Added js linting and style check per example from Twenty Sixteen.
- Moved to the faster container based environment for running travis.
- Script will no longer pull in PHPCS, WPCS and the JS linters in every build. Now they will only be pulled in when needed.
- Limited the clone depth for quicker cloning of external repositories.
- Removed the pulling in of WP and running builds against different WP versions as this wasn't used at all in the actual test scripts.
Rationale:
1. The principle of pingbacks is based on articles. Pingbacks are a special kind of comments and the article being 'pinged-back' has to be identifiable (which they're not on archive pages and the like).
2. WP only registers a ping if it can identify the article which is supposed to have been 'pung'. See: https://developer.wordpress.org/reference/classes/wp_xmlrpc_server/pingback_ping/
3. Pingbacks, like comments, can be disabled on a per article basis.
Therefore, having the pingback url auto-discovery header in place, only makes sense on singular pages where pings are open.
Emil Uzelac
mrwweb
Caroline Moore
Tammie Lister
Thomas Guillot
Eugene Kopich
Jasper de Groot
David Uzelac
Konstantin Obenland
Sami Keijonen
Benoît Chantre
Prayag Verma
Chris Schmieder
Ardalan Naghshineh
David A. Kennedy
Takashi Irie
Greg Rickaby
jrfnl
Konstantin Obenland
byjml
sarah ✈ semark
Ulrich Pogson
alaczek