David A. Kennedy
44f41babcd
Fix skip to content link.
...
* Reverts this commit: https://github.com/Automattic/_s/pull/927 The issue for that, #928 referenced an old commit. The `id` is still in the source though.
* Brought up by #982 . The `id` was correct, should not have been changed and this fixes everything.
Fixes #982
2016-07-15 09:53:29 -04:00
Jasper de Groot
0f81201b53
Correct href for skip to content link
2016-02-27 13:26:48 +01:00
jrfnl
8470f55f92
Avoid going in and out of PHP unnecessarily.
...
Closes #854
Includes minor alignment changes for easier readability/detection of start/end of conditions.
2015-11-11 22:59:40 +01:00
Tammie Lister
7c2d3ce6eb
Merge pull request #820 from sixhours/master
...
Remove hfeed from header.php, add to body_class filter. See #740
2015-11-11 20:27:21 +00:00
jrfnl
6ba9dbcf6b
Ignore WPCS output escape warning for description as it *is* already correctly escaped.
...
Fixes failing travis build.
2015-11-11 15:34:03 +01:00
Ty Carlson
9bfae01ae4
only output tagline markup when tagline exists or is_customize_preview
2015-09-21 16:59:28 -05:00
Caroline Moore
3e8580d518
Remove 'hfeed' class from header.php
...
* This was moved to inc/extras.php to be added via body_class filter
2015-09-16 15:09:09 -04:00
Konstantin Obenland
4b36cf3053
Merge pull request #781 from PJ-Finlay/add-documentation-in-comments
...
Updated file documentation.
2015-08-03 12:13:35 -07:00
PJ
de9c9888b7
Updated documentation in comments at the top of files.
...
I tried to standardize and expand the documentation and links to
codex.wordpress.org in the comments at the top of most files.
2015-07-12 12:38:18 -04:00
Morten Rand-Hendriksen
069d708834
Amended patch to display site-title as paragraph on single posts and pages as per discussion in PR.
2015-07-03 14:04:38 -07:00
Morten Rand-Hendriksen
dc6d3fa08c
New heading structure - redux of #651 . Provides proper semantic structure for titles throughout theme:
...
In header.php: Site title set to H1 on front page, div on other pages
In functions.php: Widget title set to H2 for semantic hierarchy
In content-search.php and content.php: Heading set to H2 as page title is "Search" or "Archive title" etc.
2015-06-28 12:06:02 -07:00
Sagar Jadhav
8d7f3b9c11
Updated Tagline markup as per WC3 guidelines.
2015-05-29 19:55:58 +05:30
Fränk Klein
175524922c
Fix Codesniffer errors.
2015-05-27 22:19:14 +02:00
Philip Arthur Moore
1c7f560662
Better coding standards for theme header. See #737 .
2015-04-29 08:58:07 +07:00
Jasper de Groot
412bdd8b81
Header: Made aria-controls refer to an ID instead of a class
2015-02-27 11:56:43 +01:00
Philip Arthur Moore
8b23932190
Merge remote-tracking branch 'origin/master' into title-theme-support
2014-12-02 20:11:14 +07:00
Philip Arthur Moore
83792b8566
First pass at better title handling for WordPress 4.1+ with proper back compatibility baked in.
2014-11-11 21:41:10 +07:00
Konstantin Obenland
d8d89bc681
_s: Improve menu toggle accessibility.
...
Makes it a little easier to use the primary navigation with assistive
devices.
See #545 .
2014-11-05 17:37:48 -08:00
Emil Uzelac
78afbb911b
Closing DIV comment for site-branding
...
Call it OCD, but I feel like we need a closing DIV comment for ```site-branding``` :)
2014-11-02 22:40:09 -06:00
Jack Lenox
b6ad3b341a
Changed lone uppercase H to lower
2014-06-25 00:04:59 +01:00
Philip Arthur Moore
513c17268d
Move skip-to-content link
2014-05-16 08:49:04 -05:00
Morten Rand-Hendriksen
4df5790db7
Move skip-to-content link to top to make it first focusable element for keyboard navigation.
2014-05-16 00:43:23 -07:00
Philip Arthur Moore
4b883e2aee
a11y improvements on primary navigation menu toggle
2014-04-13 04:02:17 -05:00
Ulrich Pogson
88cdc5222e
Remove wpcom actions
2014-02-10 21:19:41 +01:00
obenland
628ec71614
_s: Simplify skip link markup.
2013-10-15 21:07:14 +02:00
David A. Kennedy
3ae7a5e310
Make skip link focusable.
2013-10-01 21:30:53 -04:00
obenland
543cae8bbf
Merge branch 'master' of https://github.com/davidakennedy/_s into titles
...
Conflicts:
image.php
inc/custom-header.php
searchform.php
2013-09-25 14:59:11 -07:00
Vinod Dalvi
1a60b6cf85
Corrected wrong comments.
2013-09-14 03:29:53 -07:00
obenland
129c238239
_s: Define initial-scale for a better mobile experience when changing
...
device orientation. Fixes : #285 .
2013-09-02 17:33:32 -07:00
David A. Kennedy
22e859857e
Fix merge conflict.
2013-08-23 23:58:40 -04:00
David A. Kennedy
889491de53
First round of removing title attributes.
2013-08-23 23:48:19 -04:00
Matias Vad
7145d9fb58
<div id="main"> in comments corrected to the new <main>-element
2013-08-04 20:32:11 +02:00
obenland
810e499b93
_s: Use `<main>` element for main content.
...
See: http://www.w3.org/TR/html51/grouping-content.html#the-main-element
Props @BFTrick for initial patch.
Fixes #222 .
2013-07-30 12:12:45 -07:00
michaeldcain
d480e820c3
Switch ".navigation-main" back to ".main-navigation"
...
Original edit not needed for `[class*="navigation"]` selector. Matches
other class/id navigation naming conventions.
2013-07-11 16:17:12 -04:00
Shea Bunge
a4168fdb74
Leave empty tags open in accordance with the HTML5 spec. Resolves #234
2013-06-05 21:08:55 +10:00
Philip Arthur Moore
c186c5ee0b
Remove HTML5Shiv from _s. See #215 .
2013-05-11 10:00:08 +09:00
Philip Arthur Moore
07c44bbeef
Restore site-header class to header element and give site-branding class to title and description wrapper div. See #206 .
2013-04-24 15:08:06 +09:00
Philip Arthur Moore
1ea2ccd909
Remove hgroup from theme. It's dead now: http://www.sitepoint.com/html5-hgroup-element-dropped/ . In its place a div will be use that inherits the old class that was being applied to header.
2013-04-23 15:45:23 +09:00
Philip Arthur Moore
fe19f5433b
Ditch all @since DocBlocks from theme.
2013-03-18 14:53:23 -05:00
obenland
1ba2f62752
_s: Use .screen-reader-text rather than .assistive-text.
...
With 3.6 introducing many HTML5 improvements the need for custom
searchform and comment templates will vanish. To cope with core's
.screen-reader-text class, let's make the switch early.
Commit also adds core's focus styles for screen reader texts, so they
can actually be used.
2013-03-13 15:39:05 -07:00
Braden Jonsson
e6f6225214
Changed nav closing tag comment to indicate CSS id
2013-03-07 23:57:36 -06:00
obenland
c4f2aa32ce
_s: Formatting changes:
...
- Reduce element comments to either the element id or the first element
class.
- Tabs > Spaces.
- Improve adherence to formatting guidelines.
2013-03-04 16:41:38 -08:00
obenland
fa3d86936a
_s: Simplify and unify navigation classes throughout Underscores.
...
For more information about the philosophy behind the new approach,
see http://24ways.org/2012/a-harder-working-class/
2013-02-27 14:47:03 -08:00
sixhours
620b8e5e53
Merge pull request #66 from kovshenin/patch-8
...
Replace small-menu.js with navigation.js inspired by Twenty Twelve.
2013-02-27 13:28:31 -08:00
Michael Fields
b6b88b4201
Merge pull request #113 from sixhours/patch-3
...
Escape home_url() in #site-title link. props @sixhours
2012-11-28 10:19:42 -08:00
sixhours
c2c282e983
Escape home_url() in #site-title link
...
We escape the URL when displaying custom-header.php and searchform.php, which leads me to believe it should also be escaped here.
2012-11-20 10:37:37 -05:00
Konstantin Kovshenin
3517c7a36b
Use a filter for wp_title instead of hard-coding things in header.php
2012-09-14 20:49:06 +04:00
Konstantin Kovshenin
22e1613bde
Replace small-menu.js with navigation.js inspired by Twenty Twelve.
...
Doesn't use jQuery, slightly easier to understand, uses a media query for max-width, rather than JS events making it faster to respond.
2012-09-03 21:45:28 +04:00
Matias
752d08afd7
Update the HTML "class" system
...
Improving on the naming convention of our classes with consistency
adjustments. Also creates a better hierarchy (matched pairs) for them.
2012-08-25 14:06:33 -03:00
kobenland
b9fa5c0dd2
Add missing 'class' comments
2012-05-23 21:01:41 +02:00