Commit Graph

799 Commits

Author SHA1 Message Date
Konstantin Obenland aeaf200a58 _s: Simplify caption styles to work in HTML5 mode.
Since HTML5 captions removed the additional 10px that HTML4 versions
come with, the `max-width: 98%;` rule made images blurry. This slightly
simplifies caption styles while still providing support for both HTML4
and HTML5 versions.

See #443.
2014-04-25 11:25:48 -05:00
Konstantin Obenland 16a0d47af6 Merge pull request #443 from joshmcrty/master
Add support for HTML5 captions.
2014-04-25 11:04:47 -05:00
Konstantin Obenland e389dee561 Merge pull request #463 from gatespace/formating-source-code
Indent multiline PHP code.
2014-04-23 16:42:59 -05:00
Konstantin Obenland 8319773e51 _s: Add context for translations and styles.
The referenced items are decisions we made for `_s`, that a re likely to be brought up again in pull requests or issues. Since our stance on them is not likely to change any time soon, let's include them in the Contributing FAQs.

See #464.
2014-04-21 12:37:29 -07:00
Kazue Igarashi e3ff3dfb5d Add tab to indent 404.php(L43 to L45). 2014-04-18 22:15:42 +09:00
Philip Arthur Moore d3dd7fb3fe Remove style redundancy for menu toggle; cursor pointer is already defined for buttons. 2014-04-18 06:43:25 -05:00
Konstantin Obenland 3f1fe1c400 Merge pull request #461 from jefferyto/patch-2
Removed addEvent support.

See #456.
2014-04-15 12:24:49 -07:00
Konstantin Obenland 7cfc749d70 _s: First version of contributing guidelines.
This might change in the future, based on our experiences, but should
be a good first draft of helpful and friendly guidelines for
contributing.

Props @bungeshea.
Fixes #381.
2014-04-15 11:45:02 -07:00
Shea Bunge 11566d6998 Added contributing guidelines
https://github.com/blog/1184-contributing-guidelines
2014-04-15 11:24:33 -07:00
Jeffery To c6ad689d89 Removed addEvent support
As noted in #456, IE8 is no longer supported.

Also, undefined is falsey in JavaScript, so the typeof check was unnecessary.
2014-04-15 17:40:29 +08:00
Konstantin Obenland 2d2f66f9a1 Merge pull request #458 from Automattic/pr/429
Updated gallery styles to work for both HTML4 and HTML5 versions.

Fixes #425.
Closes #429.
2014-04-14 12:00:56 -07:00
Philip Arthur Moore 4b883e2aee a11y improvements on primary navigation menu toggle 2014-04-13 04:02:17 -05:00
Konstantin Obenland 4dd7a16f36 _s: Simplify gallery styles.
It consolidates the duplicate `.gallery` selectors, and removes image
styles that needlessly override their earlier defined styles.

Also switches to use inline-block over floats, and adds documentation
for caption styles, to be coherent with documentation for gallery
styles.
2014-04-11 13:24:38 -07:00
Konstantin Obenland 32350a8103 _s: Encourage the use of sidebar descriptions.
Sidebar descriptions provide an opportunity to provide context about
where the sidebar is located or when it is loaded. We should encourage
theme developers to use them, similar to how we hint default images for
custom headers and backgrounds.

The callback’s outdated documentation describes the function in an
early state of Toolbox (introduced in r3678-wpcom-themes), the earliest
public record would be
https://themes.trac.wordpress.org/browser/toolbox/0.3/functions.php#L99
This is as good an opportunity to update it as any.

Props @emiluzelac for initial patch.
Fixes #433.
2014-04-10 19:03:23 -07:00
Konstantin Obenland 796d8e8c7e _s: Update function return values.
Adds missing documentation for `_s_categorized_blog()` and removes void
statements, in accordance with WordPress documentation guidelines.

See
http://make.wordpress.org/core/handbook/inline-documentation-standards/p
hp-documentation-standards/#phpdoc-tags
2014-03-30 12:15:29 -07:00
Konstantin Obenland 74e9b10a7a Merge branch 'pr/437'
Conflicts:
	inc/template-tags.php
2014-03-30 12:02:05 -07:00
Konstantin Obenland 7d24be9c97 _s: Resolve merge conflicts from master branch.
This also retains `$all_the_cool_cats` for some flavor. It has been
around since the initial fork of Toolbox and makes people smile:
https://twitter.com/TheFrosty/status/449581069231071232
2014-03-30 12:00:47 -07:00
Konstantin Obenland bd665b9d82 _s: Update pot file.
Last update was a good three months ago and we had some string changes
since then.

Fixes #434.
2014-03-30 10:40:43 -07:00
Konstantin Obenland 9a6b539bba _s: Formatting adjustments.
Improves readability of argument array and brings new comment in line with all other comments in this function.
2014-03-24 10:17:59 -07:00
Konstantin Obenland 7dc0ed3410 Merge pull request #445 from Automattic/speedy-cool-cats
_s: Optimize `_s_categorized_blog()`.
2014-03-24 10:00:47 -07:00
Mohammad Jangda 39a256b183 cool-cats: Limit number of categories fetched
We only need to know if there is more than one category so only fetch a
maximum of two categories. The rest of the categories are all gravy.
2014-03-24 16:46:38 +00:00
Mohammad Jangda ad2a2cd9b9 cool-cats: only fetch the ids to limit footprint
We don't really care much about the returned; all we want is the count
so there's no point in fetching all the category data.
2014-03-24 16:43:56 +00:00
Josh McCarty d193c519b4 Add support for html5 caption 2014-03-23 21:46:35 -07:00
Ulrich Pogson 5e62b8dc9e Remove html from string 2014-03-24 00:08:21 +01:00
Konstantin Kovshenin 87ca7b66ad Prefix transient. 2014-03-18 18:43:00 +04:00
Scott Smith adb609bfde Cleaned up gallery styles, per PR review 2014-03-07 15:22:06 -06:00
Konstantin Obenland 43241a811d Merge pull request #430 from philiparthurmoore/ditch-redundant-package-declaration
_s: Remove Redundant @package DocBlock Within Custom Header File
2014-03-07 07:50:20 -06:00
Philip Arthur Moore 16e0ca504d Remove redundant package DocBlock within custom header file 2014-03-07 06:41:14 -06:00
Konstantin Obenland 34aa212143 _s: Restore class delimiter in closing comment.
Removed in e3714be581.
2014-03-06 16:45:34 -06:00
Konstantin Obenland e3714be581 Merge pull request #424 from matthewsimo/master
_s: Add entry-footer class to footer elements in entries. Fixes #420.
2014-03-06 16:44:03 -06:00
Scott Smith 98c0f823e1 Add Gallery Styles
Patch for #425
2014-03-05 23:41:15 -06:00
Konstantin Obenland 0f689b25f4 _s: Restore default styles for `<img>` elements.
Lost in 651b89e497.
2014-03-05 20:41:56 -06:00
Matthew Simo e32f0ded99 Remove the entry-meta class from footer element's in content templates. Keep entry-footer class for this purpose. 2014-03-03 17:38:27 -06:00
Matthew Simo 1a8d576e65 Add entry-footer class to footer elements in an entry. 2014-03-03 17:12:51 -06:00
Konstantin Obenland 5de96cdb72 Merge pull request #419 from kovshenin/master
_s: Add HTML5 support for WordPress galleries.
2014-02-27 11:48:23 -08:00
Konstantin Kovshenin 9b0ae42c56 Maintain backwards compatibility for non-HTML5 galleries. 2014-02-27 13:42:24 -06:00
Konstantin Kovshenin 85bce0cc74 Add HTML5 support for WordPress galleries. 2014-02-27 13:27:00 -06:00
Konstantin Obenland 18928f50d6 Merge pull request #418 from emiluzelac/patch-13
_s: Improved comment specificity.
2014-02-25 08:52:33 -08:00
Konstantin Obenland 2fed8e49bd Merge pull request #417 from emiluzelac/patch-12
_s: Make WordPress.org URL available for translation.

Brings `_s` a little close to what has been the standard in default themes for a while.
2014-02-25 08:46:15 -08:00
Emil Uzelac 1eca4bfff5 Selector Hack
```*vertical-align: middle; /* Improves appearance and consistency in all browsers */``` does not apply to all browsers. 

Selector hack ```*``` is IE6/IE7 only. See https://gist.github.com/necolas/983116
2014-02-24 22:35:49 -06:00
Emil Uzelac a0700ff80e Sanitizing URL
Path was outdated. Please see https://github.com/Automattic/_s/pull/388
2014-02-24 20:42:06 -06:00
Konstantin Obenland 1e6e4d82ca Merge pull request #387 from aahan/patch-1
_s: Switch the order of text replacements.

Change ensures the textdomain in `style.css` is not replaced with the theme name, but rather with the theme slug. Broken in 1f15c20.
2014-02-24 16:22:52 -08:00
Takashi Irie cb528a14e4 Merge pull request #415 from emiluzelac/patch-11
Reword Inputs and Buttons with Forms.
2014-02-24 18:57:05 +00:00
Emil Uzelac d5d6d146ed Forms
Proposing to reword Inputs and Buttons with Forms. This way we can cover more than just couple of elements. Select feels like an outsider and textarea too, even though it's technically an input.

This will also be a perfect match with the rest :)

N.B. Something went wrong with my last proposal, sorry about that.
2014-02-23 18:16:53 -06:00
Tammie Lister e68c231ed1 Merge pull request #406 from grappler/remove-actions
Remove wpcom actions
2014-02-10 21:12:11 +00:00
Ulrich Pogson 88cdc5222e Remove wpcom actions 2014-02-10 21:19:41 +01:00
Ian Stewart ccb587cb26 Merge pull request #403 from karmatosed/master
Adds in specific classes rather than using wider navigation selector to prevent accidentally selecting, for example, posts tagged with navigation.
2014-02-10 12:01:39 -06:00
Tammie Lister 9f4d5a9188 Adds in specific classes rather than using wider navigation selector 2014-02-10 17:35:23 +00:00
Tammie Lister 8606665b5e Merge pull request #402 from sdavis2702/master
Fixed 'Media' table of contents number
2014-02-10 16:33:17 +00:00
Sean Davis 8349625b87 Fixed 'Media' table of contents number
The table of contents labeled both ‘Infinite scroll’ and ‘Media’ as
11.0. Media is 12.0.
2014-02-08 12:39:35 -06:00