The one in `functions.php` can be considered a bug in WPCS and has been reported as such.
Once that issue is fixed, the whitelisting can be removed.
The one in `inc/wpcom.php` will need to remain as WPCS does not keep track of globals introduced by wpcom.
I keep seeing authors leave description as-is (empty) and believe that it wouldn't hurt to add something in by default. This is a general description taken from https://github.com/WordPress/twentysixteen/blob/master/functions.php#L150
At the same time it shows good practice how to escape the content and translate the string too.
Helps avoid Travis CI errors for wrongly formatted comments. Most of
these end of function comments (if not all) are useless anyway.
Props @WPAddiction for reporting.
Fixes#891.
It appears that the entire sidebar should be one large aside instead of
making each widget it's own aside. At least that's how I understand it
when reading w3. It would make sense to make each widget it's own aside
if not all of the widgets were asides, but otherwise the entire sidebar
should be considered one aside.
Plus I think this would make more sense for accessibility and with the
widgets titles being h2 because if the entire sidebar had a title that
would be the h1.
https://www.w3.org/wiki/HTML/Elements/aside
In header.php: Site title set to H1 on front page, div on other pages
In functions.php: Widget title set to H2 for semantic hierarchy
In content-search.php and content.php: Heading set to H2 as page title is "Search" or "Archive title" etc.
d8a88d2097 brought the HTML5 support declaration close to how Twenty Thirteen and Twenty Fourteen do it, leaving post formats doing their own thing.
Let's make displaying array values consistent with the latest default themes.
Sidebar descriptions provide an opportunity to provide context about
where the sidebar is located or when it is loaded. We should encourage
theme developers to use them, similar to how we hint default images for
custom headers and backgrounds.
The callback’s outdated documentation describes the function in an
early state of Toolbox (introduced in r3678-wpcom-themes), the earliest
public record would be
https://themes.trac.wordpress.org/browser/toolbox/0.3/functions.php#L99
This is as good an opportunity to update it as any.
Props @emiluzelac for initial patch.
Fixes#433.
jrfnl
Tiago Noronha
Truong Giang
Dominik Schilling
David A. Kennedy
Ulrich Pogson
Tammie Lister
Sami Keijonen
Bappi
mrwweb
Caroline Moore
Emil Uzelac
Konstantin Obenland
jrfnl
Konstantin Obenland
sarah ✈ semark
Mark Batchelder
Dmitry Mayorov
PJ
Morten Rand-Hendriksen
Fränk Klein
Philip Arthur Moore
Kirk Wight
Josh McCarty
Konstantin Kovshenin