From 40e943d1455f626d87fead19f20ce5166e0d9ae9 Mon Sep 17 00:00:00 2001
From: Andrew Nelless <andrew@symless.com>
Date: Fri, 12 May 2017 20:40:07 +0100
Subject: [PATCH] #6037 Use of non-memsize type for pointer arithmetic

---
 src/lib/arch/IArchString.cpp | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/lib/arch/IArchString.cpp b/src/lib/arch/IArchString.cpp
index 05cc2dfb..57365363 100644
--- a/src/lib/arch/IArchString.cpp
+++ b/src/lib/arch/IArchString.cpp
@@ -42,7 +42,7 @@ int
 IArchString::convStringWCToMB(char* dst,
                 const wchar_t* src, UInt32 n, bool* errors)
 {
-    int len = 0;
+    ptrdiff_t len = 0;
 
     bool dummyErrors;
     if (errors == NULL) {
@@ -58,14 +58,14 @@ IArchString::convStringWCToMB(char* dst,
     if (dst == NULL) {
         char dummy[MB_LEN_MAX];
         for (const wchar_t* scan = src; n > 0; ++scan, --n) {
-            int mblen = wctomb(dummy, *scan);
+            ptrdiff_t mblen = wctomb(dummy, *scan);
             if (mblen == -1) {
                 *errors = true;
                 mblen   = 1;
             }
             len += mblen;
         }
-        int mblen = wctomb(dummy, L'\0');
+        ptrdiff_t mblen = wctomb(dummy, L'\0');
         if (mblen != -1) {
             len += mblen - 1;
         }
@@ -73,7 +73,7 @@ IArchString::convStringWCToMB(char* dst,
     else {
         char* dst0 = dst;
         for (const wchar_t* scan = src; n > 0; ++scan, --n) {
-            int mblen = wctomb(dst, *scan);
+            ptrdiff_t mblen = wctomb(dst, *scan);
             if (mblen == -1) {
                 *errors = true;
                 *dst++  = '?';
@@ -82,12 +82,12 @@ IArchString::convStringWCToMB(char* dst,
                 dst    += mblen;
             }
         }
-        int mblen = wctomb(dst, L'\0');
+        ptrdiff_t mblen = wctomb(dst, L'\0');
         if (mblen != -1) {
             // don't include nul terminator
             dst += mblen - 1;
         }
-        len = (int)(dst - dst0);
+        len = dst - dst0;
     }
     ARCH->unlockMutex(s_mutex);
 
@@ -98,7 +98,7 @@ int
 IArchString::convStringMBToWC(wchar_t* dst,
                 const char* src, UInt32 n, bool* errors)
 {
-    int len = 0;
+    ptrdiff_t len = 0;
     wchar_t dummy;
 
     bool dummyErrors;
@@ -114,7 +114,7 @@ IArchString::convStringMBToWC(wchar_t* dst,
 
     if (dst == NULL) {
         for (const char* scan = src; n > 0; ) {
-            int mblen = mbtowc(&dummy, scan, n);
+            ptrdiff_t mblen = mbtowc(&dummy, scan, n);
             switch (mblen) {
             case -2:
                 // incomplete last character.  convert to unknown character.
@@ -150,7 +150,7 @@ IArchString::convStringMBToWC(wchar_t* dst,
     else {
         wchar_t* dst0 = dst;
         for (const char* scan = src; n > 0; ++dst) {
-            int mblen = mbtowc(dst, scan, n);
+            ptrdiff_t mblen = mbtowc(dst, scan, n);
             switch (mblen) {
             case -2:
                 // incomplete character.  convert to unknown character.
@@ -181,7 +181,7 @@ IArchString::convStringMBToWC(wchar_t* dst,
                 break;
             }
         }
-        len = (int)(dst - dst0);
+        len = dst - dst0;
     }
     ARCH->unlockMutex(s_mutex);