From 2cd21cc95f043fa415dc3800ab7af564f7ec17a2 Mon Sep 17 00:00:00 2001 From: Dom Rodriguez Date: Tue, 29 Sep 2020 17:21:38 +0100 Subject: [PATCH 1/5] [chore](stale bot): Bump Stale bot version to v3 Previous was v1, v3 fixes bugs, and makes the action 'smarter'. Signed-off-by: Dom Rodriguez --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 011e61bc..ff292778 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/stale@v1 + - uses: actions/stale@v3 with: repo-token: ${{ secrets.GITHUB_TOKEN }} From 7756557204b7b379257ea8bf1dce2e7a66d50258 Mon Sep 17 00:00:00 2001 From: Dom Rodriguez Date: Tue, 29 Sep 2020 17:22:13 +0100 Subject: [PATCH 2/5] [fix](stale bot): Change cron time to midnight This fits in better across various time zones (I'm GMT, for example, some devs EST/CEST). Signed-off-by: Dom Rodriguez --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index ff292778..b1d94542 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -2,7 +2,7 @@ name: Mark stale issues and pull requests on: schedule: - - cron: "30 1 * * *" + - cron: "00 0 * * *" jobs: stale: From 8122484c3db3c32903c0aae4b298c9fd03b76a06 Mon Sep 17 00:00:00 2001 From: Dom Rodriguez Date: Tue, 29 Sep 2020 17:33:04 +0100 Subject: [PATCH 3/5] [fix](stale bot): Make stale bot less aggressive [1/2] This commit changes the configuration of the stale bot. It no longer closes stale issues, and instead gives a friendly 'nudge' for stale issues. The next commit will change the time for issues to be marked stale to 6 months. This should help reduce the noise from the bot. Signed-off-by: Dom Rodriguez --- .github/workflows/stale.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index b1d94542..ad1a4b25 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -14,14 +14,14 @@ jobs: with: repo-token: ${{ secrets.GITHUB_TOKEN }} - stale-issue-message: "This issue has been automatically marked as stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions." - stale-pr-message: "This PR has been automatically marked as stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions." + stale-issue-message: "Is this issue still an issue for you? Please do comment and let us know!" + stale-pr-message: "Is this PR still being worked on? Please do comment and let us know!" close-issue-message: "This issue will now be closed due to inactivty. It may be reopened if the demand indicates it should be." close-pr-message: "This PR will now be closed due to inactivty. It may be reopened if the demand indicates it should be." days-before-stale: 60 - days-before-close: 7 + days-before-close: -1 stale-issue-label: "no-issue-activity" stale-pr-label: "no-pr-activity" From dbe4dc5d12024832890ea880c8744823ed497012 Mon Sep 17 00:00:00 2001 From: Dom Rodriguez Date: Tue, 29 Sep 2020 17:34:57 +0100 Subject: [PATCH 4/5] [fix](stale bot): Make stale bot less aggressive [2/2] This commit changes the configuration of the stale bot. It will now mark issues as stale after 6 months. In days, this is 182(.5, if you want to be super precise, but let's go with 182). This should reduce the noise made by the bot. Signed-off-by: Dom Rodriguez --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index ad1a4b25..9cc69689 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -20,7 +20,7 @@ jobs: close-issue-message: "This issue will now be closed due to inactivty. It may be reopened if the demand indicates it should be." close-pr-message: "This PR will now be closed due to inactivty. It may be reopened if the demand indicates it should be." - days-before-stale: 60 + days-before-stale: 182 days-before-close: -1 stale-issue-label: "no-issue-activity" From 9b55aaae1e6aff685c2d027edf1b55b1add0f21f Mon Sep 17 00:00:00 2001 From: Dom Rodriguez Date: Tue, 29 Sep 2020 23:29:44 +0100 Subject: [PATCH 5/5] [improve](stale bot): Adjust stale messages to encourage self-closing What the subject line says really. As per @walker0643's feedback, the stale bot now encourages the author of the issue/PR to close it themselves, if it is no longer an issue, or if they no longer want to work on the PR. Signed-off-by: Dom Rodriguez --- .github/workflows/stale.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 9cc69689..26584bfb 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -14,8 +14,8 @@ jobs: with: repo-token: ${{ secrets.GITHUB_TOKEN }} - stale-issue-message: "Is this issue still an issue for you? Please do comment and let us know!" - stale-pr-message: "Is this PR still being worked on? Please do comment and let us know!" + stale-issue-message: "Is this issue still an issue for you? Please do comment and let us know! Alternatively, you may close the issue yourself if it is no longer an problem" + stale-pr-message: "Is this PR still being worked on? Please do comment and let us know! Alternatively, you may close the PR yourself if you no longer wish to work on the PR." close-issue-message: "This issue will now be closed due to inactivty. It may be reopened if the demand indicates it should be." close-pr-message: "This PR will now be closed due to inactivty. It may be reopened if the demand indicates it should be."