rayelliott
/
barrier
mirror of https://github.com/debauchee/barrier.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix #1531: Revert control key remapping from grave/tilde to zenkaku 

The bug was introduced in the pull request #1214, and even in the description of the request it had been acknowledged that there is no such key on mac keyboards.

As a consequence, it led to inability to transfer the grave accent and and the tilde, at least from macOS to Windows on default "ABC" keyboard layout.

Unfortunately, I don't have a JIS keyboard, nor understand how to use it. The only thing I can suggest now is to revert the controversial remapping.
This commit is contained in:
Vladimir Lagunov 2022-01-27 01:49:17 +07:00
parent 433126e7a1
commit 4fa7f250c7
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
doc/newsfragments/1531_remove_zenkaku_remapping.bugfix Normal file
View File

@ -0,0 +1 @@
macOS servers can send the grave accent and the tilde to clients.

1
doc/newsfragments/1531_zenkaku_remapping.removal Normal file
View File

@ -0,0 +1 @@
Removed remapping from the grave accent to the zenkaku.

3
src/lib/platform/OSXKeyState.cpp
View File

@ -131,8 +131,7 @@ static const KeyEntry s_controlKeys[] = {
{ kKeyEisuToggle, kVK_JIS_Eisu }, { kKeyEisuToggle, kVK_JIS_Eisu },
{ kKeyKana, kVK_JIS_Kana }, { kKeyKana, kVK_JIS_Kana },
{ kKeyMuhenkan, s_int5VK }, { kKeyMuhenkan, s_int5VK },
{ kKeyHenkan, s_int4VK }, { kKeyHenkan, s_int4VK }
{ kKeyZenkaku, kVK_ANSI_Grave }
}; };