From 952be51c8c805cbd41a2a9d77c339d6d02112023 Mon Sep 17 00:00:00 2001 From: jerry Date: Wed, 25 Sep 2013 15:57:10 +0000 Subject: [PATCH] fixed sending file twice when drag a file from Mac server to Windows client --- src/lib/server/CServer.cpp | 17 ++++++++++++++++- src/lib/server/CServer.h | 1 + 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/lib/server/CServer.cpp b/src/lib/server/CServer.cpp index 308ec982..6e451704 100644 --- a/src/lib/server/CServer.cpp +++ b/src/lib/server/CServer.cpp @@ -76,7 +76,8 @@ CServer::CServer(CConfig& config, CPrimaryClient* primaryClient, CScreen* screen m_lockedToScreen(false), m_screen(screen), m_sendFileThread(NULL), - m_writeToDropDirThread(NULL) + m_writeToDropDirThread(NULL), + m_ignoreFileTransfer(false) { // must have a primary client and it must have a canonical name assert(m_primaryClient != NULL); @@ -1660,6 +1661,11 @@ CServer::onMouseUp(ButtonID id) // relay m_active->mouseUp(id); + if (m_ignoreFileTransfer) { + m_ignoreFileTransfer = false; + return; + } + if (!m_screen->isOnScreen()) { CString& dir = m_screen->getDraggingFileDir(); if (!dir.empty()) { @@ -1754,6 +1760,15 @@ CServer::onMouseMovePrimary(SInt32 x, SInt32 y) m_screen->keyUp(kKeyEscape, 8192, 1); m_screen->mouseUp(kButtonLeft); +#if defined(__APPLE__) + + // on mac it seems that after faking a LMB up, system would signal back + // to synergy a mouse up event, which doesn't happen on windows. as a + // result, synergy would send dragging file to client twice. This variable + // is used to ignore the first file sending. + m_ignoreFileTransfer = true; +#endif + LOG((CLOG_DEBUG2 "sending drag information to client")); LOG((CLOG_DEBUG3 "dragging file list: %s", fileList)); LOG((CLOG_DEBUG3 "dragging file list string size: %i", size)); diff --git a/src/lib/server/CServer.h b/src/lib/server/CServer.h index 28f39a8a..f82a323c 100644 --- a/src/lib/server/CServer.h +++ b/src/lib/server/CServer.h @@ -471,6 +471,7 @@ private: CThread* m_sendFileThread; CThread* m_writeToDropDirThread; CString m_dragFileExt; + bool m_ignoreFileTransfer; }; #endif