diff --git a/doc/newsfragments/fix-wrong-encoding-for-text-copied-between-linux-and-windows.bugfix b/doc/newsfragments/fix-wrong-encoding-for-text-copied-between-linux-and-windows.bugfix new file mode 100644 index 00000000..3b76d060 --- /dev/null +++ b/doc/newsfragments/fix-wrong-encoding-for-text-copied-between-linux-and-windows.bugfix @@ -0,0 +1,2 @@ +Fix wrong encoding for text copied between Linux and Windows +(https://github.com/debauchee/barrier/issues/1037, https://github.com/debauchee/barrier/issues/1137). diff --git a/src/lib/platform/XWindowsClipboardHTMLConverter.cpp b/src/lib/platform/XWindowsClipboardHTMLConverter.cpp index a13e80e4..eae032d5 100644 --- a/src/lib/platform/XWindowsClipboardHTMLConverter.cpp +++ b/src/lib/platform/XWindowsClipboardHTMLConverter.cpp @@ -56,10 +56,17 @@ XWindowsClipboardHTMLConverter::getDataSize() const std::string XWindowsClipboardHTMLConverter::fromIClipboard(const std::string& data) const { - return Unicode::UTF8ToUTF16(data); + return data; } std::string XWindowsClipboardHTMLConverter::toIClipboard(const std::string& data) const { - return Unicode::UTF16ToUTF8(data); + // Older Firefox [1] and possibly other applications use UTF-16 for text/html - handle both + // [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1497580 + if (Unicode::isUTF8(data)) { + return data; + } else { + return Unicode::UTF16ToUTF8(data); + } + return data; }