basic config validation added

config/validator.go

@@ -1,10 +1,55 @@
 package config
 
-/*
- TODO validation
- - title uniquness and mandatory within a single type of widget
- - label uniqueness and mandatory (if > 1 data bullets)
-*/
+import (
+	"fmt"
+	"github.com/sqshq/sampler/console"
+)
+
 func (c *Config) validate() {
 
+	var components []ComponentConfig
+
+	for _, c := range c.RunCharts {
+		components = append(components, c.ComponentConfig)
+		validateLabelsUniqueness(c.Title, c.Items)
+	}
+	for _, c := range c.BarCharts {
+		components = append(components, c.ComponentConfig)
+		validateLabelsUniqueness(c.Title, c.Items)
+	}
+	for _, c := range c.SparkLines {
+		components = append(components, c.ComponentConfig)
+	}
+	for _, c := range c.Gauges {
+		components = append(components, c.ComponentConfig)
+	}
+	for _, c := range c.AsciiBoxes {
+		components = append(components, c.ComponentConfig)
+	}
+	for _, c := range c.TextBoxes {
+		components = append(components, c.ComponentConfig)
+	}
+
+	validateTitlesUniqueness(components)
+}
+
+func validateLabelsUniqueness(title string, items []Item) {
+	labels := make(map[string]bool)
+	for _, c := range items {
+		label := *c.Label
+		if _, contains := labels[label]; contains {
+			console.Exit(fmt.Sprintf("Config validation error: item labels should be unique. Please rename '%s' in '%s'", label, title))
+		}
+		labels[label] = true
+	}
+}
+
+func validateTitlesUniqueness(components []ComponentConfig) {
+	titles := make(map[string]bool)
+	for _, c := range components {
+		if _, contains := titles[c.Title]; contains {
+			console.Exit(fmt.Sprintf("Config validation error: component titles should be unique. Please rename '%s'", c.Title))
+		}
+		titles[c.Title] = true
+	}
 }

example.yml

@@ -1,7 +1,7 @@
 variables:
   mongoconnection: mongo --quiet --host=localhost blog
 runcharts:
-- title: SEARCH ENGINE RESPONSE TIME (sec)
+  - title: SEARCH ENGINE RESPONSE TIME (sec)
     position: [[0, 0], [52, 16]]
     triggers:
       - title: Latency threshold exceeded
@@ -19,7 +19,7 @@ runcharts:
         sample: curl -o /dev/null -s -w '%{time_total}'  https://search.yahoo.com
       - label: BING
         sample: curl -o /dev/null -s -w '%{time_total}'  https://www.bing.com
-- title: MONGO COLLECTIONS COUNT
+  - title: MONGO COLLECTIONS COUNT
     position: [[53, 0], [27, 8]]
     legend:
       enabled: true
@@ -33,7 +33,7 @@ runcharts:
         init: $mongoconnection
         sample: db.getCollection('posts').find({status:'INACTIVE'}).itcount()
 barcharts:
-- title: EVENTS BY STATUS
+  - title: EVENTS BY STATUS
     position: [[0, 17], [28, 12]]
     rate-ms: 300
     scale: 0
@@ -54,7 +54,7 @@ barcharts:
         init: $mongoconnection
         sample: db.getCollection('posts').find({status:'INACTIVE'}).itcount()
 gauges:
-- title: YEAR PROGRESS
+  - title: YEAR PROGRESS
     position: [[53, 8], [27, 2]]
     cur:
       sample: date +%j
@@ -62,7 +62,7 @@ gauges:
       sample: echo 365
     min:
       sample: echo 0
-- title: DAY PROGRESS
+  - title: DAY PROGRESS
     position: [[53, 10], [27, 2]]
     cur:
       sample: date +%H
@@ -70,7 +70,7 @@ gauges:
       sample: echo 24
     min:
       sample: echo 0
-- title: HOUR PROGRESS
+  - title: HOUR PROGRESS
     position: [[53, 12], [27, 2]]
     cur:
       sample: date +%M
@@ -78,7 +78,7 @@ gauges:
       sample: echo 60
     min:
       sample: echo 0
-- title: MINUTE PROGRESS
+  - title: MINUTE PROGRESS
     position: [[53, 14], [27, 2]]
     triggers:
       - title: CLOCK BELL EVERY MINUTE
@@ -93,35 +93,36 @@ gauges:
     min:
       sample: echo 0
 sparklines:
-- title: CPU usage
+  - title: CPU usage
     position: [[28, 22], [24, 7]]
     scale: 0
     sample: ps -A -o %cpu | awk '{s+=$1} END {print s}'
-- title: Memory pages free
+  - title: Memory pages free
     position: [[28, 17], [24, 5]]
     scale: 0
     sample: memory_pressure | grep 'Pages free' | awk '{print $3}'
 textboxes:
-- title: Local weather
+  - title: Local weather
     position: [[0, 30], [13, 7]]
     rate-ms: 10000
     sample: curl wttr.in?0ATQF
     border: false
-- title: New York weather
+  - title: New York weather
     position: [[8, 30], [13, 7]]
     rate-ms: 10000
     sample: curl wttr.in/newyork?0ATQF
     border: false
-- title: San Francisco weather
+    transform: echo 1
+  - title: San Francisco weather
     position: [[17, 30], [13, 7]]
     rate-ms: 10000
     sample: curl wttr.in/sanfrancisco?0ATQF
     border: false
 asciiboxes:
-- title: LOCAL TIME
+  - title: LOCAL TIME
     position: [[53, 17], [27, 5]]
     sample: date +%r
-- title: UTC TIME
+  - title: UTC TIME
     position: [[53, 22], [27, 7]]
     sample: env TZ=UTC date +%r
     font: 3d