From 1576a0e3e2bca6887ebf9fdb2c0079508a50b406 Mon Sep 17 00:00:00 2001 From: koenemann Date: Fri, 27 Jan 2017 13:08:05 +0100 Subject: [PATCH] Fixing comments.php build errors FIXING FILE: /home/travis/build/holger1411/understrap/comments.php ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 28 | ERROR | Expected next thing to be an escaping function (see Codex | | for 'Data Validation'), not '_nx' | | (WordPress.XSS.EscapeOutput.OutputNotEscaped) 28 | ERROR | Missing singular placeholder, needed for some languages. | | See | | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals | | (WordPress.WP.I18n.MissingSingularPlaceholder) 30 | ERROR | Expected next thing to be an escaping function (see Codex | | for 'Data Validation'), not 'number_format_i18n' | | (WordPress.XSS.EscapeOutput.OutputNotEscaped) ---------------------------------------------------------------------- --- comments.php | 10 ++++++---- inc/theme-settings.php | 2 ++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/comments.php b/comments.php index 4d20251..e29109f 100644 --- a/comments.php +++ b/comments.php @@ -25,11 +25,13 @@ if ( post_password_required() ) {

' . get_the_title() . '' ); + printf( // WPCS: XSS OK. + esc_html( _nx( 'One thought on “%2$s”', '%1$s thoughts on “%2$s”', get_comments_number(), 'comments title', '_s' ) ), + number_format_i18n( get_comments_number() ), + '' . get_the_title() . '' + ); ?> -

+ 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through. ?>