ARIA roles update

# Removed unneccessary ARIA roles to make it ARIA and HTML5 compliant.
# Added SCSS to show a pointer on any occasion of buttons (menu, save,
submit, reset etc.)
This commit is contained in:
Thomas A. Reinert 2016-11-04 02:27:07 +01:00
parent 321bc65369
commit 47b0db392b
7 changed files with 37 additions and 31 deletions

1
.gitignore vendored
View File

@ -8,3 +8,4 @@ understrap.zip
src src
dist dist
/gulpfile.js

View File

@ -31,7 +31,7 @@ if ( post_password_required() ) {
</h2> </h2>
<?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through ?> <?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through ?>
<nav class="comment-navigation" id="comment-nav-above" role="navigation"> <nav class="comment-navigation" id="comment-nav-above">
<h1 class="screen-reader-text"><?php _e( 'Comment navigation', 'understrap' ); ?></h1> <h1 class="screen-reader-text"><?php _e( 'Comment navigation', 'understrap' ); ?></h1>
<?php if ( get_previous_comments_link() ) { ?> <?php if ( get_previous_comments_link() ) { ?>
<div class="nav-previous"><?php previous_comments_link( __( '&larr; Older Comments', 'understrap' ) ); ?></div> <div class="nav-previous"><?php previous_comments_link( __( '&larr; Older Comments', 'understrap' ) ); ?></div>
@ -51,7 +51,7 @@ if ( post_password_required() ) {
</ol><!-- .comment-list --> </ol><!-- .comment-list -->
<?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through ?> <?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through ?>
<nav class="comment-navigation" id="comment-nav-below" role="navigation"> <nav class="comment-navigation" id="comment-nav-below">
<h1 class="screen-reader-text"><?php _e( 'Comment navigation', 'understrap' ); ?></h1> <h1 class="screen-reader-text"><?php _e( 'Comment navigation', 'understrap' ); ?></h1>
<?php if ( get_previous_comments_link() ) { ?> <?php if ( get_previous_comments_link() ) { ?>
<div class="nav-previous"><?php previous_comments_link( __( '&larr; Older Comments', 'understrap' ) );?></div> <div class="nav-previous"><?php previous_comments_link( __( '&larr; Older Comments', 'understrap' ) );?></div>

View File

@ -5027,7 +5027,6 @@ a.skip-link {
.dropdown-menu .dropdown-menu { .dropdown-menu .dropdown-menu {
position: relative; position: relative;
display: block; display: block;
width: 140px;
margin-left: 10px; margin-left: 10px;
border: none; border: none;
box-shadow: none; } box-shadow: none; }
@ -5040,6 +5039,9 @@ a.skip-link {
.dropdown-menu .menu-item a:hover { .dropdown-menu .menu-item a:hover {
background-color: #895cd1; } background-color: #895cd1; }
button {
cursor: pointer; }
/*! /*!
* Font Awesome 4.5.0 by @davegandy - http://fontawesome.io - @fontawesome * Font Awesome 4.5.0 by @davegandy - http://fontawesome.io - @fontawesome
* License - http://fontawesome.io/license (Font: SIL OFL 1.1, CSS: MIT License) * License - http://fontawesome.io/license (Font: SIL OFL 1.1, CSS: MIT License)

2
css/theme.min.css vendored

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View File

@ -15,7 +15,7 @@ var browserSyncWatchFiles = [
// browser-sync options // browser-sync options
// see: https://www.browsersync.io/docs/options/ // see: https://www.browsersync.io/docs/options/
var browserSyncOptions = { var browserSyncOptions = {
proxy: "localhost/theme_test/", proxy: "localhost/wordpress/",
notify: false notify: false
}; };
@ -38,7 +38,7 @@ var browserSync = require('browser-sync').create();
var reload = browserSync.reload; var reload = browserSync.reload;
// Run: // Run:
// gulp sass + cssnano + rename // gulp sass + cssnano + rename
// Prepare the min.css for production (with 2 pipes to be sure that "child-theme.css" == "child-theme.min.css") // Prepare the min.css for production (with 2 pipes to be sure that "child-theme.css" == "child-theme.min.css")
gulp.task('scss-for-prod', function() { gulp.task('scss-for-prod', function() {
@ -53,14 +53,14 @@ gulp.task('scss-for-prod', function() {
var pipe2 = source.pipe(clone()) var pipe2 = source.pipe(clone())
.pipe(cssnano()) .pipe(cssnano())
.pipe(rename({suffix: '.min'})) .pipe(rename({suffix: '.min'}))
.pipe(gulp.dest('./css')); .pipe(gulp.dest('./css'));
return merge(pipe1, pipe2); return merge(pipe1, pipe2);
}); });
// Run: // Run:
// gulp sourcemaps + sass + reload(browserSync) // gulp sourcemaps + sass + reload(browserSync)
// Prepare the child-theme.css for the developpment environment // Prepare the child-theme.css for the developpment environment
gulp.task('scss-for-dev', function() { gulp.task('scss-for-dev', function() {
@ -78,7 +78,7 @@ gulp.task('watch-scss', ['browser-sync'], function () {
}); });
// Run: // Run:
// gulp sass // gulp sass
// Compiles SCSS files in CSS // Compiles SCSS files in CSS
gulp.task('sass', function () { gulp.task('sass', function () {
@ -88,7 +88,7 @@ gulp.task('sass', function () {
.pipe(gulp.dest('./css')); .pipe(gulp.dest('./css'));
}); });
// Run: // Run:
// gulp watch // gulp watch
// Starts watcher. Watcher runs gulp sass task on changes // Starts watcher. Watcher runs gulp sass task on changes
gulp.task('watch', function () { gulp.task('watch', function () {
@ -96,7 +96,7 @@ gulp.task('watch', function () {
gulp.watch('./css/theme.css', ['cssnano']); gulp.watch('./css/theme.css', ['cssnano']);
}); });
// Run: // Run:
// gulp nanocss // gulp nanocss
// Minifies CSS files // Minifies CSS files
gulp.task('cssnano', ['cleancss'], function(){ gulp.task('cssnano', ['cleancss'], function(){
@ -108,28 +108,28 @@ gulp.task('cssnano', ['cleancss'], function(){
.pipe(sourcemaps.write('./')) .pipe(sourcemaps.write('./'))
.pipe(gulp.dest('./css/')) .pipe(gulp.dest('./css/'))
.pipe(reload({stream: true})); .pipe(reload({stream: true}));
}); });
gulp.task('cleancss', function() { gulp.task('cleancss', function() {
return gulp.src('./css/*.min.css', { read: false }) // much faster return gulp.src('./css/*.min.css', { read: false }) // much faster
.pipe(ignore('theme.css')) .pipe(ignore('theme.css'))
.pipe(rimraf()); .pipe(rimraf());
}); });
// Run: // Run:
// gulp browser-sync // gulp browser-sync
// Starts browser-sync task for starting the server. // Starts browser-sync task for starting the server.
gulp.task('browser-sync', function() { gulp.task('browser-sync', function() {
browserSync.init(browserSyncWatchFiles, browserSyncOptions); browserSync.init(browserSyncWatchFiles, browserSyncOptions);
}); });
// Run: // Run:
// gulp watch-bs // gulp watch-bs
// Starts watcher with browser-sync. Browser-sync reloads page automatically on your browser // Starts watcher with browser-sync. Browser-sync reloads page automatically on your browser
gulp.task('watch-bs', ['browser-sync', 'watch', 'cssnano'], function () { }); gulp.task('watch-bs', ['browser-sync', 'watch', 'cssnano'], function () { });
// Run: // Run:
// gulp scripts. // gulp scripts.
// Uglifies and concat all JS files into one // Uglifies and concat all JS files into one
gulp.task('scripts', function() { gulp.task('scripts', function() {
gulp.src([ gulp.src([
@ -137,7 +137,7 @@ gulp.task('scripts', function() {
basePaths.dev + 'js/tether.js', // Must be loaded before BS4 basePaths.dev + 'js/tether.js', // Must be loaded before BS4
// Start - All BS4 stuff // Start - All BS4 stuff
basePaths.dev + 'js/bootstrap4/bootstrap.js', basePaths.dev + 'js/bootstrap4/bootstrap.js',
// End - All BS4 stuff // End - All BS4 stuff
@ -152,7 +152,7 @@ gulp.task('scripts', function() {
basePaths.dev + 'js/tether.js', // Must be loaded before BS4 basePaths.dev + 'js/tether.js', // Must be loaded before BS4
// Start - All BS4 stuff // Start - All BS4 stuff
basePaths.dev + 'js/bootstrap4/bootstrap.js', basePaths.dev + 'js/bootstrap4/bootstrap.js',
// End - All BS4 stuff // End - All BS4 stuff
@ -162,15 +162,15 @@ gulp.task('scripts', function() {
.pipe(gulp.dest('./js/')); .pipe(gulp.dest('./js/'));
}); });
// Run: // Run:
// gulp copy-assets. // gulp copy-assets.
// Copy all needed dependency assets files from bower_component assets to themes /js, /scss and /fonts folder. Run this task after bower install or bower update // Copy all needed dependency assets files from bower_component assets to themes /js, /scss and /fonts folder. Run this task after bower install or bower update
////////////////// All Bootstrap SASS Assets ///////////////////////// ////////////////// All Bootstrap SASS Assets /////////////////////////
gulp.task('copy-assets', function() { gulp.task('copy-assets', function() {
////////////////// All Bootstrap 4 Assets ///////////////////////// ////////////////// All Bootstrap 4 Assets /////////////////////////
// Copy all Bootstrap JS files // Copy all Bootstrap JS files
gulp.src(basePaths.node + 'bootstrap/dist/js/**/*.js') gulp.src(basePaths.node + 'bootstrap/dist/js/**/*.js')
.pipe(gulp.dest(basePaths.dev + '/js/bootstrap4')); .pipe(gulp.dest(basePaths.dev + '/js/bootstrap4'));
@ -216,10 +216,10 @@ gulp.task('copy-assets', function() {
.pipe(gulp.dest(basePaths.dev + '/css')); .pipe(gulp.dest(basePaths.dev + '/css'));
}); });
// Run // Run
// gulp dist // gulp dist
// Copies the files to the /dist folder for distributon // Copies the files to the /dist folder for distributon
gulp.task('dist', function() { gulp.task('dist', function() {
gulp.src(['**/*','!sass','!bower_components', '!node_modules','!src','!dist','!bower.json', '!gulpfile.js', '!package.json', '*']) gulp.src(['**/*','!sass','!bower_components', '!node_modules','!src','!dist','!bower.json', '!gulpfile.js', '!package.json', '*'])
.pipe(gulp.dest('dist/')) .pipe(gulp.dest('dist/'))
}); });

View File

@ -134,7 +134,6 @@ a.skip-link {
.dropdown-menu .dropdown-menu { .dropdown-menu .dropdown-menu {
position: relative; position: relative;
display: block; display: block;
width: 140px;
margin-left: 10px; margin-left: 10px;
border: none; border: none;
box-shadow: none; box-shadow: none;
@ -148,3 +147,7 @@ a.skip-link {
width: 100%; width: 100%;
a:hover { background-color: $brand-primary; } a:hover { background-color: $brand-primary; }
} }
button {
cursor: pointer;
}