rayelliott
/
understrap
Archived
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove duplicate theme JS enqueue, update comment 

Howdy Holger,

I believe the `theme.min.js` file was enqueued twice; once using old method and again using new. This pull request removes the old enqueue method.

I also added _CSS_ to the comment as it's enqueuing more than JS.

I hope that helps!
This commit is contained in:
Eric Amundson 2018-04-11 21:30:49 -07:00 committed by GitHub
parent 2743321cd1
commit cf0109af54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
inc/enqueue.php
View File

@ -7,7 +7,7 @@
if ( ! function_exists( 'understrap_scripts' ) ) { if ( ! function_exists( 'understrap_scripts' ) ) {
/** /**
* Load theme's JavaScript sources. * Load theme's JavaScript and CSS sources.
*/ */
function understrap_scripts() { function understrap_scripts() {
// Get the theme data. // Get the theme data.
@ -22,7 +22,6 @@ if ( ! function_exists( 'understrap_scripts' ) ) {
$js_version = $theme_version . '.' . filemtime(get_template_directory() . '/js/theme.min.js'); $js_version = $theme_version . '.' . filemtime(get_template_directory() . '/js/theme.min.js');
wp_enqueue_script( 'understrap-scripts', get_template_directory_uri() . '/js/theme.min.js', array(), $js_version, true ); wp_enqueue_script( 'understrap-scripts', get_template_directory_uri() . '/js/theme.min.js', array(), $js_version, true );
wp_enqueue_script( 'understrap-scripts', get_template_directory_uri() . '/js/theme.min.js', array(), $the_theme->get( 'Version' ), true );
if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) { if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) {
wp_enqueue_script( 'comment-reply' ); wp_enqueue_script( 'comment-reply' );
} }