From bf792512ce21ba12799e35cb5279c483da44561b Mon Sep 17 00:00:00 2001
From: IanDelMar <42134098+IanDelMar@users.noreply.github.com>
Date: Sat, 14 Dec 2019 08:26:31 +0100
Subject: [PATCH 1/3] Fix space usage

See https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#space-usage
---
 inc/pagination.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/inc/pagination.php b/inc/pagination.php
index 6db6170..0d53261 100644
--- a/inc/pagination.php
+++ b/inc/pagination.php
@@ -35,7 +35,7 @@ if ( ! function_exists( 'understrap_pagination' ) ) {
 
 		<nav aria-label="<?php echo $args['screen_reader_text']; ?>">
 
-			<ul class="<?php echo esc_attr($class); ?>">
+			<ul class="<?php echo esc_attr( $class ); ?>">
 
 				<?php
 				foreach ( $links as $key => $link ) {

From ae43f9b620520b7f401331b44211456b9a340f7f Mon Sep 17 00:00:00 2001
From: IanDelMar <42134098+IanDelMar@users.noreply.github.com>
Date: Sat, 14 Dec 2019 08:29:21 +0100
Subject: [PATCH 2/3] Use aria-labelledby

Use aria-labelledby + heading instead of aria-label. (For a discussion see #1063.)
---
 inc/pagination.php | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/inc/pagination.php b/inc/pagination.php
index 0d53261..9398803 100644
--- a/inc/pagination.php
+++ b/inc/pagination.php
@@ -33,7 +33,11 @@ if ( ! function_exists( 'understrap_pagination' ) ) {
 
 		?>
 
-		<nav aria-label="<?php echo $args['screen_reader_text']; ?>">
+		<nav aria-labelledby="posts-nav-label">
+
+			<h2 id="posts-nav-label" class="sr-only">
+				<?php echo esc_html( $args['screen_reader_text'] ); ?>
+			</h2>
 
 			<ul class="<?php echo esc_attr( $class ); ?>">
 

From e4cc30f990e5c45dac30bcdcd05b313296cfe6c5 Mon Sep 17 00:00:00 2001
From: IanDelMar <42134098+IanDelMar@users.noreply.github.com>
Date: Sat, 14 Dec 2019 09:19:36 +0100
Subject: [PATCH 3/3] Add DocBlock

plus switch keys order
of the defaults array to keep the arguments for paginate_links() together.
---
 inc/pagination.php | 35 +++++++++++++++++++++++++++++++----
 1 file changed, 31 insertions(+), 4 deletions(-)

diff --git a/inc/pagination.php b/inc/pagination.php
index 9398803..9b9f6fc 100644
--- a/inc/pagination.php
+++ b/inc/pagination.php
@@ -9,7 +9,36 @@
 defined( 'ABSPATH' ) || exit;
 
 if ( ! function_exists( 'understrap_pagination' ) ) {
-
+	/**
+	 * Displays the navigation to next/previous set of posts.
+	 *
+	 * @param string|array $args {
+	 *     (Optional) Array of arguments for generating paginated links for archives.
+	 *
+	 *     @type string $base               Base of the paginated url. Default empty.
+	 *     @type string $format             Format for the pagination structure. Default empty.
+	 *     @type int    $total              The total amount of pages. Default is the value WP_Query's
+	 *                                      `max_num_pages` or 1.
+	 *     @type int    $current            The current page number. Default is 'paged' query var or 1.
+	 *     @type string $aria_current       The value for the aria-current attribute. Possible values are 'page',
+	 *                                      'step', 'location', 'date', 'time', 'true', 'false'. Default is 'page'.
+	 *     @type bool   $show_all           Whether to show all pages. Default false.
+	 *     @type int    $end_size           How many numbers on either the start and the end list edges.
+	 *                                      Default 1.
+	 *     @type int    $mid_size           How many numbers to either side of the current pages. Default 2.
+	 *     @type bool   $prev_next          Whether to include the previous and next links in the list. Default true.
+	 *     @type bool   $prev_text          The previous page text. Default '&laquo;'.
+	 *     @type bool   $next_text          The next page text. Default '&raquo;'.
+	 *     @type string $type               Controls format of the returned value. Possible values are 'plain',
+	 *                                      'array' and 'list'. Default is 'array'.
+	 *     @type array  $add_args           An array of query args to add. Default false.
+	 *     @type string $add_fragment       A string to append to each link. Default empty.
+	 *     @type string $before_page_number A string to appear before the page number. Default empty.
+	 *     @type string $after_page_number  A string to append after the page number. Default empty.
+	 *     @type string $screen_reader_text Screen reader text for the nav element. Default 'Posts navigation'.
+	 * }
+	 * @param string       $class           (Optional) Classes to be added to the <ul> element. Default 'pagination'.
+	 */
 	function understrap_pagination( $args = array(), $class = 'pagination' ) {
 
 		if ( $GLOBALS['wp_query']->max_num_pages <= 1 ) {
@@ -23,9 +52,9 @@ if ( ! function_exists( 'understrap_pagination' ) ) {
 				'prev_next'          => true,
 				'prev_text'          => __( '&laquo;', 'understrap' ),
 				'next_text'          => __( '&raquo;', 'understrap' ),
-				'screen_reader_text' => __( 'Posts navigation', 'understrap' ),
 				'type'               => 'array',
 				'current'            => max( 1, get_query_var( 'paged' ) ),
+				'screen_reader_text' => __( 'Posts navigation', 'understrap' ),
 			)
 		);
 
@@ -58,5 +87,3 @@ if ( ! function_exists( 'understrap_pagination' ) ) {
 		<?php
 	}
 }
-
-