Merge pull request #112 from Thomas-A-Reinert/dev

ARIA roles update +1 @Thomas-A-Reinert  Thx again!

.gitignore

@@ -8,3 +8,4 @@ understrap.zip
 src
 
 dist
+/gulpfile.js

comments.php

@@ -31,7 +31,7 @@ if ( post_password_required() ) {
     </h2>
 
     <?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through ?>
-      <nav class="comment-navigation" id="comment-nav-above" role="navigation">
+      <nav class="comment-navigation" id="comment-nav-above">
         <h1 class="screen-reader-text"><?php _e( 'Comment navigation', 'understrap' ); ?></h1>
         <?php if ( get_previous_comments_link() ) { ?>
           <div class="nav-previous"><?php previous_comments_link( __( '&larr; Older Comments', 'understrap' ) ); ?></div>
@@ -51,7 +51,7 @@ if ( post_password_required() ) {
     </ol><!-- .comment-list -->
 
     <?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through ?>
-      <nav class="comment-navigation" id="comment-nav-below" role="navigation">
+      <nav class="comment-navigation" id="comment-nav-below">
         <h1 class="screen-reader-text"><?php _e( 'Comment navigation', 'understrap' ); ?></h1>
         <?php if ( get_previous_comments_link() ) { ?>
           <div class="nav-previous"><?php previous_comments_link( __( '&larr; Older Comments', 'understrap' ) );?></div>

css/theme.css

@@ -5027,7 +5027,6 @@ a.skip-link {
 .dropdown-menu .dropdown-menu {
   position: relative;
   display: block;
-  width: 140px;
   margin-left: 10px;
   border: none;
   box-shadow: none; }
@@ -5040,6 +5039,12 @@ a.skip-link {
   .dropdown-menu .menu-item a:hover {
     background-color: #895cd1; }
 
+button,
+[type="button"],
+[type="reset"],
+[type="submit"] {
+  cursor: pointer; }
+
 /*!
  *  Font Awesome 4.5.0 by @davegandy - http://fontawesome.io - @fontawesome
  *  License - http://fontawesome.io/license (Font: SIL OFL 1.1, CSS: MIT License)

gulpfile.js

@@ -15,7 +15,7 @@ var browserSyncWatchFiles = [
 // browser-sync options
 // see: https://www.browsersync.io/docs/options/
 var browserSyncOptions = {
-    proxy: "localhost/theme_test/",
+    proxy: "localhost/wordpress/",
     notify: false
 };
 
@@ -38,7 +38,7 @@ var browserSync = require('browser-sync').create();
 var reload = browserSync.reload;
 
 
-// Run: 
+// Run:
 // gulp sass + cssnano + rename
 // Prepare the min.css for production (with 2 pipes to be sure that "child-theme.css" == "child-theme.min.css")
 gulp.task('scss-for-prod', function() {
@@ -53,14 +53,14 @@ gulp.task('scss-for-prod', function() {
 
     var pipe2 = source.pipe(clone())
         .pipe(cssnano())
-        .pipe(rename({suffix: '.min'})) 
+        .pipe(rename({suffix: '.min'}))
         .pipe(gulp.dest('./css'));
 
     return merge(pipe1, pipe2);
 });
 
 
-// Run: 
+// Run:
 // gulp sourcemaps + sass + reload(browserSync)
 // Prepare the child-theme.css for the developpment environment
 gulp.task('scss-for-dev', function() {
@@ -78,7 +78,7 @@ gulp.task('watch-scss', ['browser-sync'], function () {
 });
 
 
-// Run: 
+// Run:
 // gulp sass
 // Compiles SCSS files in CSS
 gulp.task('sass', function () {
@@ -88,7 +88,7 @@ gulp.task('sass', function () {
         .pipe(gulp.dest('./css'));
 });
 
-// Run: 
+// Run:
 // gulp watch
 // Starts watcher. Watcher runs gulp sass task on changes
 gulp.task('watch', function () {
@@ -96,7 +96,7 @@ gulp.task('watch', function () {
     gulp.watch('./css/theme.css', ['cssnano']);
 });
 
-// Run: 
+// Run:
 // gulp nanocss
 // Minifies CSS files
 gulp.task('cssnano', ['cleancss'], function(){
@@ -108,28 +108,28 @@ gulp.task('cssnano', ['cleancss'], function(){
     .pipe(sourcemaps.write('./'))
     .pipe(gulp.dest('./css/'))
     .pipe(reload({stream: true}));
-}); 
+});
 
 gulp.task('cleancss', function() {
-  return gulp.src('./css/*.min.css', { read: false }) // much faster 
+  return gulp.src('./css/*.min.css', { read: false }) // much faster
     .pipe(ignore('theme.css'))
     .pipe(rimraf());
 });
 
-// Run: 
+// Run:
 // gulp browser-sync
 // Starts browser-sync task for starting the server.
 gulp.task('browser-sync', function() {
     browserSync.init(browserSyncWatchFiles, browserSyncOptions);
 });
 
-// Run: 
+// Run:
 // gulp watch-bs
 // Starts watcher with browser-sync. Browser-sync reloads page automatically on your browser
 gulp.task('watch-bs', ['browser-sync', 'watch', 'cssnano'], function () { });
 
-// Run: 
+// Run:
-// gulp scripts. 
+// gulp scripts.
 // Uglifies and concat all JS files into one
 gulp.task('scripts', function() {
   gulp.src([
@@ -137,7 +137,7 @@ gulp.task('scripts', function() {
     basePaths.dev + 'js/tether.js', // Must be loaded before BS4
 
     // Start - All BS4 stuff
-    basePaths.dev + 'js/bootstrap4/bootstrap.js', 
+    basePaths.dev + 'js/bootstrap4/bootstrap.js',
 
     // End - All BS4 stuff
 
@@ -152,7 +152,7 @@ gulp.task('scripts', function() {
     basePaths.dev + 'js/tether.js', // Must be loaded before BS4
 
     // Start - All BS4 stuff
-    basePaths.dev + 'js/bootstrap4/bootstrap.js', 
+    basePaths.dev + 'js/bootstrap4/bootstrap.js',
 
     // End - All BS4 stuff
 
@@ -162,15 +162,15 @@ gulp.task('scripts', function() {
     .pipe(gulp.dest('./js/'));
 });
 
-// Run: 
+// Run:
-// gulp copy-assets. 
+// gulp copy-assets.
 // Copy all needed dependency assets files from bower_component assets to themes /js, /scss and /fonts folder. Run this task after bower install or bower update
 
 ////////////////// All Bootstrap SASS  Assets /////////////////////////
 gulp.task('copy-assets', function() {
 
 ////////////////// All Bootstrap 4 Assets /////////////////////////
-// Copy all Bootstrap JS files 
+// Copy all Bootstrap JS files
     gulp.src(basePaths.node + 'bootstrap/dist/js/**/*.js')
        .pipe(gulp.dest(basePaths.dev + '/js/bootstrap4'));
 
@@ -216,10 +216,10 @@ gulp.task('copy-assets', function() {
         .pipe(gulp.dest(basePaths.dev + '/css'));
 });
 
-// Run 
+// Run
-// gulp dist 
+// gulp dist
-// Copies the files to the /dist folder for distributon 
+// Copies the files to the /dist folder for distributon
-gulp.task('dist', function() { 
+gulp.task('dist', function() {
-    gulp.src(['**/*','!sass','!bower_components', '!node_modules','!src','!dist','!bower.json', '!gulpfile.js', '!package.json', '*']) 
+    gulp.src(['**/*','!sass','!bower_components', '!node_modules','!src','!dist','!bower.json', '!gulpfile.js', '!package.json', '*'])
-    .pipe(gulp.dest('dist/')) 
+    .pipe(gulp.dest('dist/'))
-});
+});

package.json

@@ -42,6 +42,6 @@
     "gulp-watch": "^4.3.6",
     "merge2": "^1.0.2",
     "owl.carousel": "^2.2.0",
-    "undescores-for-npm": "^1.0.0"
+    "underscores-for-npm": "^1.0.0"
   }
 }

sass/understrap/understrap.scss

@@ -134,7 +134,6 @@ a.skip-link {
 .dropdown-menu .dropdown-menu {
   position: relative;
   display: block;
-  width: 140px;
   margin-left: 10px;
   border: none;
   box-shadow: none;
@@ -148,3 +147,10 @@ a.skip-link {
   width: 100%;
   a:hover { background-color: $brand-primary; }
 }
+
+button,
+[type="button"],
+[type="reset"],
+[type="submit"] {
+  cursor: pointer;
+}