Commit Graph

621 Commits

Author SHA1 Message Date
Vinod Dalvi c7f8623716 Made Changes in CSS to Make it Adhere to WordPress CSS Coding Standards. 2013-09-12 14:15:25 -07:00
obenland dff92a0e9e _s: Be more specific about clearing elements.
(Introduced in b1d3b53)

While class attribute selectors are very powerful and might help in
keeping stylesheets concise and easier to maintain, they don't work very
well with a project like WordPress. Not only can third-party scripts
insert and rely on specific class names that get picked up by attribute
selectors for common class names. But more importantly WordPress passes
category and tag slugs on to post classes, which can result in
unpredictible results.

Fixes #284, fixes #309.
2013-09-12 13:11:38 +09:00
obenland 6e80d01bd0 _s: Make footer markup optional with edit post link. 2013-09-12 12:45:44 +09:00
Konstantin Obenland f804d4d3b2 Merge pull request #306 from sabreuse/patch-1
_s: Simplify comment labeling.
2013-09-11 20:43:38 -07:00
michiecat 7f4c689188 Merge pull request #293 from SnowDayGroup/code-comments-grammar
minor code comment comma grammar fixes
2013-09-02 21:12:05 -07:00
obenland 129c238239 _s: Define initial-scale for a better mobile experience when changing
device orientation. Fixes: #285.
2013-09-02 17:33:32 -07:00
Amy Hendrix d41371c9f9 Simplify comment labeling in image.php
The image template is the only one to label "comments and trackbacks are open" "comments are closed but trackbacks are open" etc. ad nauseam. Few people are using those options any more, and it's a lot of clutter on a template that (if anything) should be simpler and cleaner than all the rest - we should delete all that and match the comment presentation to the way it's done in page.php and single.php
2013-08-29 10:59:27 -04:00
Konstantin Obenland a224b393c4 Merge pull request #305 from andrewspittle/master
_s: Update small-menu.js reference in README.
2013-08-28 14:42:41 -07:00
Andrew Spittle b260e2906e Update small-menu reference in README
The old reference was to `js/small-menu.js` which no longer exists. Current file is `js/navigation.js`.
2013-08-28 14:38:11 -07:00
Konstantin Obenland d598324b67 Merge pull request #303 from thomasguillot/keyboard-image-navigation
_s: Fix element for left arrow key code.
2013-08-27 09:05:12 -07:00
Thomas Guillot f87479f70d _s: Fix element for left arrow key code
Previous one was deprecated
2013-08-27 10:29:46 +01:00
Konstantin Obenland 8495f99e2b Merge pull request #292 from SnowDayGroup/docfixes
_s: Add comma in docs.
2013-08-26 08:36:14 -07:00
Konstantin Obenland 14b6cd55fc Merge pull request #291 from SnowDayGroup/image-optimization
_s: Optimize screenshot.png.
2013-08-26 08:35:38 -07:00
David A. Kennedy 48ac0da4e1 Second round of removing title attributes. 2013-08-24 02:06:06 -04:00
David A. Kennedy 22e859857e Fix merge conflict. 2013-08-23 23:58:40 -04:00
David A. Kennedy 889491de53 First round of removing title attributes. 2013-08-23 23:48:19 -04:00
Brad Parbs bf6ecae7c4 minor code comment comma grammar fixes 2013-08-21 12:04:29 -05:00
Brad Parbs c4c0fa992e Comma fix in docs 2013-08-21 11:55:53 -05:00
Brad Parbs 067dac2ddd Optimized screenshot image - 93.8% savings 2013-08-21 11:53:25 -05:00
obenland 0ac069a0bf _s: Update selectors to reflect the changes in 810e499. Fixes #288. 2013-08-21 10:38:39 -04:00
Konstantin Obenland 76c68722cc Merge pull request #290 from BFTrick/rename-overload
Use 'override' instead of 'overload' to avoid confusion with overloading properties and methods in PHP.
2013-08-21 07:30:20 -07:00
Patrick Rauland 3d98e794d3 also changing overload to override in comments.php & archive.php 2013-08-20 07:27:46 -05:00
Patrick Rauland 1d134ab298 renaming overload to override. props emiluzelac. 2013-08-20 07:16:42 -05:00
Thomas Guillot 966d649f3c _s: Use comment_reply_link arguments to wrap reply link
Avoid empty div if no reply link
2013-08-19 10:18:10 +01:00
Konstantin Obenland a462ad5720 Merge pull request #280 from jayj/jayj-underscores-url-selector
Add `url` to the list of input selectors.
2013-08-11 15:06:15 -07:00
Konstantin Obenland 3c4b905086 Merge pull request #279 from jayj/jayj-underscores-heading-spacing
Add spaces between heading selectors.
2013-08-07 08:26:21 -07:00
Konstantin Obenland 74370a2148 Merge pull request #278 from jayj/jayj-underscores-main-element
Add the `<main>` element to the list of HTML5 selectors.
2013-08-07 08:24:59 -07:00
Jesper Johansen b5864622ee Add the <main> element to the list of HTML5 selectors 2013-08-07 00:59:28 +02:00
Jesper Johansen c8ca427356 Add a space between the heading selectors 2013-08-07 00:58:31 +02:00
Jesper Johansen 1108a8a582 Add `url` to the list of input selectors 2013-08-07 00:57:17 +02:00
Michael Cain c3901be10c Merge pull request #277 from lucasmullens/patch-1
Update README.md layouts
2013-08-05 09:48:04 -07:00
lucasmullens 684fd1626f Update README.md 2013-08-05 01:21:28 -05:00
Philip Arthur Moore 407b666216 Merge pull request #275 from matiasvad/patch-1
<div id="main"> in comments corrected to the new <main>-element
2013-08-04 12:01:08 -07:00
Matias Vad 7145d9fb58 <div id="main"> in comments corrected to the new <main>-element 2013-08-04 20:32:11 +02:00
Konstantin Obenland 5199a56b05 Merge pull request #271 from kovshenin/patch-15
Add a domain path header to the stylesheet for translation.
2013-07-30 12:47:22 -07:00
Konstantin Kovshenin 167197dd07 Add a domain path header to the stylesheet for translation 2013-07-30 23:45:55 +04:00
obenland 810e499b93 _s: Use `<main>` element for main content.
See: http://www.w3.org/TR/html51/grouping-content.html#the-main-element

Props @BFTrick for initial patch.
Fixes #222.
2013-07-30 12:12:45 -07:00
obenland 1f15c20995 _s: Make theme headers translatable. Props @grappler. Fixes #203. 2013-07-30 11:58:13 -07:00
obenland 4227e37e47 _s: Remove three column layouts.
We don't register a second sidebar and styles seem to be incomplete.
Let's revisit this once we have a more modular way of putting `_s`
together.

Closes #199.
2013-07-30 11:19:38 -07:00
obenland 1a12794a21 _s: Make file paths more consistent in readme file. Props @asdfgh746.
Fixes #269.
2013-07-30 11:07:13 -07:00
Konstantin Obenland 9fc508f362 Merge pull request #265 from sixhours/Author-Link
Remove author link from archive.php. Fixes #264.
2013-07-29 09:56:19 -07:00
sixhours 9f866cde82 Remove author link from archive.php 2013-07-26 11:59:25 -04:00
Philip Arthur Moore db5cc6d3ce Remove WordPress.com-specific functions and definitions require line from functions.php; wpcom.php is now automatically included via plugin on WordPress.com. 2013-07-24 16:04:56 -07:00
Konstantin Obenland fa2f9e3434 Merge pull request #262 from calvinwinter/master
_s: Update `.toggled` class to reflect revised `navigation.js` syntax. Fixes #261.
2013-07-18 08:38:46 -07:00
Calvin Winter 7276a13a4b Fixed bug where menu does not toggle on click
fixes the error described here: https://github.com/Automattic/_s/issues/261
2013-07-17 23:28:49 -04:00
Konstantin Obenland 2c23f460ab Merge pull request #260 from bungeshea/fix-js-errors
_s: Fix JSHint errors.
2013-07-15 18:09:12 -07:00
Shea Bunge e5a8931afc Add missing semicolon 2013-07-14 16:39:03 +10:00
Shea Bunge 4c99b2aba8 Use === and !== instead of == and != 2013-07-14 16:38:08 +10:00
Konstantin Obenland 79d69e7593 Merge pull request #256 from michaeldcain/master
_s: Switch "navigation-" classes back to "-navigation".
2013-07-11 14:22:20 -07:00
michaeldcain 31331b4b64 Switch "navigation-" back to "-navigation"
Original edit not needed for `[class*="navigation"]` selector. Matches
other class/id navigation naming conventions.
2013-07-11 16:42:45 -04:00