Commit Graph

38 Commits

Author SHA1 Message Date
Amy Hendrix d41371c9f9 Simplify comment labeling in image.php
The image template is the only one to label "comments and trackbacks are open" "comments are closed but trackbacks are open" etc. ad nauseam. Few people are using those options any more, and it's a lot of clutter on a template that (if anything) should be simpler and cleaner than all the rest - we should delete all that and match the comment presentation to the way it's done in page.php and single.php
2013-08-29 10:59:27 -04:00
obenland 810e499b93 _s: Use `<main>` element for main content.
See: http://www.w3.org/TR/html51/grouping-content.html#the-main-element

Props @BFTrick for initial patch.
Fixes #222.
2013-07-30 12:12:45 -07:00
michaeldcain 31331b4b64 Switch "navigation-" back to "-navigation"
Original edit not needed for `[class*="navigation"]` selector. Matches
other class/id navigation naming conventions.
2013-07-11 16:42:45 -04:00
Kirk Wight 2930ba91be _s: Escape URLs in image.php 2013-07-11 12:04:40 -04:00
obenland 514b2aa62d _s: Don't show separator between meta data. Fixes #72. 2013-06-27 07:03:43 -07:00
obenland 6c83cfb5cc _s: Simplify image.php:
* Extracts logic in a custom template tag.
* Reduces switching in and out of php in `.entry-meta`.
* Minor code styling changes.

Fixes #233.
2013-06-04 13:13:15 -07:00
obenland 655ee71d60 _s: Better use of template tags in the image template. 2013-05-20 12:59:09 +02:00
Takashi Irie c780bc0559 Add trailing commas to the last elements of arrays 2013-04-20 16:45:36 +01:00
Takashi Irie 7be757759c Minor code style clean-up 2013-04-20 01:26:43 +01:00
obenland 6056c1ed66 _s: Re-introduce `nav-` prefix for previous/next links.
This way we can select both links with `[class*="nav-"]`.
2013-04-05 09:34:08 -07:00
obenland 9af47bab03 _s: Use the_title_attrinute() when we don't need to specify a post.
See #188, closes #184.
2013-03-26 12:00:34 -07:00
Slobodan Manic 410ca3b1df Added strip_tags when get_the_title is used for title attribute in image.php
Aaddresses _s issue 184 - https://github.com/Automattic/_s/issues/184
2013-03-21 06:35:08 +01:00
Philip Arthur Moore fe19f5433b Ditch all @since DocBlocks from theme. 2013-03-18 14:53:23 -05:00
Eduardo Zulian 37253e11f4 Image navigation improvements
Add a navigation role, replace spans with divs and also add a
'.meta-nav' for both previous and next image links.
2013-03-16 14:50:02 -03:00
obenland c4f2aa32ce _s: Formatting changes:
- Reduce element comments to either the element id or the first element
class.
- Tabs > Spaces.
- Improve adherence to formatting guidelines.
2013-03-04 16:41:38 -08:00
sixhours 4134038278 Merge pull request #132 from davidensinger/master
Load comments template only when comments are open or there's at least one comment in image.php and page.php
2013-02-28 08:45:06 -08:00
obenland fa3d86936a _s: Simplify and unify navigation classes throughout Underscores.
For more information about the philosophy behind the new approach,
see http://24ways.org/2012/a-harder-working-class/
2013-02-27 14:47:03 -08:00
David Ensinger cfb7f7fcdf Load comments template only when comments are open or there's at least one comment
To be consistent with single.php and to ensure that an empty div (<div
id="comments" class="comments-area">) isn't outputted when both
comments are closed and there aren't any comments.
2013-01-04 16:09:37 -05:00
Michael Fields 56023b2194 Remove debugging code from image.php 2012-12-31 16:59:42 -08:00
Michael Fields d64b796669 Escape the value of get_the_title() when printed in an attribute. 2012-12-31 16:57:14 -08:00
Michael Fields 1db4236e4c Better indentation of the images query in image.php. props @ashfame see #45 2012-12-28 17:48:34 -08:00
Michael Fields 0d20442227 Remove invalid pubdate value from time elements in image.php 2012-12-28 17:27:07 -08:00
Philip Arthur Moore 3833150b44 _s: Add 'site-navigation' class to image.php's image navigation container. 2012-09-04 19:05:25 -04:00
Matias 752d08afd7 Update the HTML "class" system
Improving on the naming convention of our classes with consistency
adjustments. Also creates a better hierarchy (matched pairs) for them.
2012-08-25 14:06:33 -03:00
kobenland b9fa5c0dd2 Add missing 'class' comments 2012-05-23 21:01:41 +02:00
Michael Fields bd4719e73f _s: Better image filtering for self-hosted users. fixes #1216
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9481 d957f892-c61d-0410-b221-f235e6eecf30
2012-04-24 14:38:15 -05:00
Michael Fields c71f030c18 _s: Move post meta separators inside conditionals ensuring that separators will not be orphaned. Use consistent 'edit link' whitespace in image.php as well.
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@9087 d957f892-c61d-0410-b221-f235e6eecf30
2012-03-06 14:40:49 +00:00
Lance Willett 93a334bc97 _s: refix footer URL and extra spaces, originally fixed in r8766 but reverted in r8831
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@8981 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-21 06:28:24 +00:00
Ian Stewart f3dc4c227d _s: move scripts into one function added to wp_enqueue_scripts
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@8936 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-14 16:10:45 +00:00
Matías Ventura 926f6bd0e4 _s: fix double-defined class attributes
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@8895 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-08 14:59:38 +00:00
Ian Stewart e8b2bb81c6 _s: A better name for the image navigation script and better experience by cycling through a gallery when done
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@8849 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-03 14:02:28 +00:00
Ian Stewart 5f2d6758e7 _s: Using the standard format for versioning of JS
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@8848 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-03 02:36:18 +00:00
Ian Stewart 293458cbd7 _s: First pass at keyboard navigation in image templates
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@8845 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-02 20:49:40 +00:00
Ian Stewart 2428d6a051 _s: using the time element image attachments to match posts
git-svn-id: https://wpcom-themes.svn.automattic.com/_s/@8844 d957f892-c61d-0410-b221-f235e6eecf30
2012-02-02 16:39:41 +00:00
Ian Stewart afe244fe68 _s: More consistency with class names in the structural markup 2012-02-01 16:55:36 +00:00
Lance Willett 9ce5deb7af _s fixes
Spacing, trailing slash; no need to translate the footer generator URI.
2012-01-20 18:18:59 +00:00
Ian Stewart a81dc6a810 _s: Adding starter styles along with a few markup changes to accomodate them 2012-01-13 20:10:17 +00:00
Ian Stewart edfeccc255 _s: initial fork of Toolbox 2012-01-07 03:25:13 +00:00