rayelliott
/
understrap
Archived
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixing comments.php build errors 

FIXING

FILE: /home/travis/build/holger1411/understrap/comments.php

----------------------------------------------------------------------

FOUND 3 ERRORS AFFECTING 2 LINES

----------------------------------------------------------------------

 28 | ERROR | Expected next thing to be an escaping function (see Codex

    |       | for 'Data Validation'), not '_nx'

    |       | (WordPress.XSS.EscapeOutput.OutputNotEscaped)

 28 | ERROR | Missing singular placeholder, needed for some languages.

    |       | See

    |       |
https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals

    |       | (WordPress.WP.I18n.MissingSingularPlaceholder)

 30 | ERROR | Expected next thing to be an escaping function (see Codex

    |       | for 'Data Validation'), not 'number_format_i18n'

    |       | (WordPress.XSS.EscapeOutput.OutputNotEscaped)

----------------------------------------------------------------------
This commit is contained in:
koenemann 2017-01-27 13:08:05 +01:00
parent b0fcba1829
commit 1576a0e3e2
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
comments.php
View File

@ -25,11 +25,13 @@ if ( post_password_required() ) {
<?php if ( have_comments() ) : ?> <?php if ( have_comments() ) : ?>
<h2 class="comments-title"> <h2 class="comments-title">
<?php <?php
printf( _nx( 'One thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', printf( // WPCS: XSS OK.
get_comments_number(), 'comments title', 'understrap' ), esc_html( _nx( 'One thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', get_comments_number(), 'comments title', '_s' ) ),
number_format_i18n( get_comments_number() ), '<span>' . get_the_title() . '</span>' ); number_format_i18n( get_comments_number() ),
'<span>' . get_the_title() . '</span>'
);
?> ?>
</h2> </h2><!-- .comments-title -->
<?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through. ?> <?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // are there comments to navigate through. ?>
<nav class="comment-navigation" id="comment-nav-above"> <nav class="comment-navigation" id="comment-nav-above">

2
inc/theme-settings.php
View File

@ -1,6 +1,8 @@
<?php <?php
/** /**
* Check and setup theme's default settings * Check and setup theme's default settings
*
* @package understrap
*/ */
function setup_theme_default_settings() { function setup_theme_default_settings() {